Mismap and possible mismatch with Material in mid-Indev

[FubyCutie]

Type
Field, maybe Class

Describe where the element is
net.minecraft.block.material.Material(.f1017744)

Description of the element
In indev-20100201-0025: the mentioned field is used for any block that is not lava/water. And the class in general is focused on liquids entirely.

In indev-20100201-2227: the mentioned field is used for wooden materials specifically. The class in general is now focused on Materials in general, and lava/water are defined using an extending class, with a method to check for liquid/not.

Expected name
Field: NON_LIQUID
maybe Class: LiquidState

Additional Context
The class in general seems to have been re-purposed from liquids, to generic materials, with liquids being a subset. I think there are arguments that this is anywhere between a mis-mapped field, and a mismatched class, depending on how you look at it. The field has undeniably changed purpose, a name change is necessary at least, and there's no reason it to should match to anything in particular, since there's nothing that lines up, which leads me to believe it's a mismatch too. The class is arguably doing the same thing (determining subsets of blocks and their properties), but simply changed scope massively, this is quite possibly a good match, and maybe even a good mapping too.

Least extensive suggested change: rename Material.WOOD to Material.NON_LIQUID in indev-20100201-0025 and below.

Most extensive suggested change: rematch the class net.minecraft.block.material.Material for indev-20100201-0025 and below, remap to LiquidState, and remap fields as LAVA, WATER, and NON_LIQUID

[SpaceWalkerRS]

I think it's worth keeping the class match. It seems to me to serve most of the same functions, just more specialized in 2227 and above. In 0025 it's mostly about distinguishing between liquids and "regular" blocks, and between water and lava, and in one case it even appears to be used as a check for air. In 2227 I spotted some uses related to mob spawning and mining speed, too, using more specialized "materials".

That field match definitely needs to go though, which I'll get on to. As for the name, the field is used as a sort of catch-all for anything not fitting into other materials, so I'd lean more to naming it something generic, like BLOCK, to distinguish it from the liquid materials. Unfortunately we cannot get a hint from the official names as this isn't one of the magic classes that wasn't obfuscated in classic. Oh, well.