Minor Breaking Change - Move Some BaseWriter Properties

When Conditional and Table Formatting were added to Html Reader, properties, getters, and setters were added to BaseReader. They should have been added to Html Reader instead, and this PR moves them from one to the other. It is technically a breaking change, but, since there is no reason to use them with any writer other than Html, I don't anticipate anyone seeing any adverse effects.

Author: oleibman

src/PhpSpreadsheet/Writer/BaseWriter.php

@@ -2,8 +2,6 @@
 
 namespace PhpOffice\PhpSpreadsheet\Writer;
 
-use PhpOffice\PhpSpreadsheet\Exception as PhpSpreadsheetException;
-
 abstract class BaseWriter implements IWriter
 {
     /**
@@ -19,18 +17,6 @@ abstract class BaseWriter implements IWriter
      */
     protected bool $preCalculateFormulas = true;
 
-    /**
-     * Table formats
-     * Enables table formats in writer, disabled here, must be enabled in writer via a setter.
-     */
-    protected bool $tableFormats = false;
-
-    /**
-     * Conditional Formatting
-     * Enables conditional formatting in writer, disabled here, must be enabled in writer via a setter.
-     */
-    protected bool $conditionalFormatting = false;
-
     /**
      * Use disk caching where possible?
      */
@@ -72,34 +58,6 @@ public function setPreCalculateFormulas(bool $precalculateFormulas): self
         return $this;
     }
 
-    public function getTableFormats(): bool
-    {
-        return $this->tableFormats;
-    }
-
-    public function setTableFormats(bool $tableFormats): self
-    {
-        if ($tableFormats) {
-            throw new PhpSpreadsheetException('Table formatting not implemented for this writer');
-        }
-
-        return $this;
-    }
-
-    public function getConditionalFormatting(): bool
-    {
-        return $this->conditionalFormatting;
-    }
-
-    public function setConditionalFormatting(bool $conditionalFormatting): self
-    {
-        if ($conditionalFormatting) {
-            throw new PhpSpreadsheetException('Conditional Formatting not implemented for this writer');
-        }
-
-        return $this;
-    }
-
     public function getUseDiskCaching(): bool
     {
         return $this->useDiskCaching;

src/PhpSpreadsheet/Writer/Html.php

@@ -158,6 +158,18 @@ class Html extends BaseWriter
 
     private string $getFalse = 'FALSE';
 
+    /**
+     * Table formats
+     * Enables table formats in writer, disabled here, must be enabled in writer via a setter.
+     */
+    protected bool $tableFormats = false;
+
+    /**
+     * Conditional Formatting
+     * Enables conditional formatting in writer, disabled here, must be enabled in writer via a setter.
+     */
+    protected bool $conditionalFormatting = false;
+
     /**
      * Create a new HTML.
      */
@@ -1849,13 +1861,23 @@ public function setUseInlineCss(bool $useInlineCss): static
         return $this;
     }
 
+    public function getTableFormats(): bool
+    {
+        return $this->tableFormats;
+    }
+
     public function setTableFormats(bool $tableFormats): self
     {
         $this->tableFormats = $tableFormats;
 
         return $this;
     }
 
+    public function getConditionalFormatting(): bool
+    {
+        return $this->conditionalFormatting;
+    }
+
     public function setConditionalFormatting(bool $conditionalFormatting): self
     {
         $this->conditionalFormatting = $conditionalFormatting;