Skip to content
This repository was archived by the owner on Jun 6, 2023. It is now read-only.

Commit 045918e

Browse files
sanfilipsanfilip
committed
rename resp return result to res
1 parent 1ef1196 commit 045918e

37 files changed

+131
-130
lines changed

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ All of the methods are namespaced by category ("machines.create" or "invoices.sh
109109

110110
paperspace.machines.create({
111111
// parameters
112-
}, function (err, resp) {
112+
}, function (err, res) {
113113
// callback
114114
});
115115

‎lib/jobs/artifactsDestroy.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ var assign = require('lodash.assign');
1818
* paperspace.jobs.artifactsDestroy({
1919
* jobId: 'j123abc',
2020
* files: 'myfiles*' // optional
21-
* }, function(err, resp) {
22-
* // handle error or http response
21+
* }, function(err, res) {
22+
* // handle error or result
2323
* });
2424
* @example
2525
* $ paperspace jobs artifactsDestroy \

‎lib/jobs/artifactsGet.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ var mkdirp = require('mkdirp');
2525
* paperspace.jobs.artifactsGet({
2626
* jobId: 'j123abc',
2727
* files: 'myfiles*' // optional
28-
* }, function(err, resp) {
29-
* // handle error or http response
28+
* }, function(err, res) {
29+
* // handle error or result
3030
* });
3131
* @example
3232
* $ paperspace jobs artifactsGet \

‎lib/jobs/artifactsList.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ var assign = require('lodash.assign');
1717
* @example
1818
* paperspace.jobs.artifactsList({
1919
* jobId: 'j123abc',
20-
* }, function(err, resp) {
21-
* // handle error or http response
20+
* }, function(err, res) {
21+
* // handle error or result
2222
* });
2323
* @example
2424
* $ paperspace jobs artifactsList \

‎lib/jobs/clone.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ var assign = require('lodash.assign');
1414
* @example
1515
* paperspace.jobs.clone({
1616
* jobId: 'j123abc',
17-
* }, function(err, resp) {
18-
* // handle error or http response
17+
* }, function(err, res) {
18+
* // handle error or result
1919
* });
2020
* @example
2121
* $ paperspace jobs clone --jobId "j123abc"
@@ -36,10 +36,10 @@ var assign = require('lodash.assign');
3636

3737
function clone(params, cb) {
3838
params.jobId = projectConfig.getLastJobId(null, params.jobId);
39-
return method(clone, params, function _methodCb(err, resp) {
39+
return method(clone, params, function _methodCb(err, res) {
4040
if (err) return cb(err);
41-
if (resp) projectConfig.setLastJobId(resp.project, resp.id);
42-
return cb(err, resp);
41+
if (res) projectConfig.setLastJobId(res.project, res.id);
42+
return cb(err, res);
4343
});
4444
}
4545

‎lib/jobs/create.js‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ var jobs_show = require('./../jobs/show.js');
3535
* paperspace.jobs.create({
3636
* container: 'http://dockerhub.com/mycontainer',
3737
* machineType: 'P6000',
38-
* }, function(err, resp) {
39-
* // handle error or http response
38+
* }, function(err, res) {
39+
* // handle error or result
4040
* });
4141
* @example
4242
* $ paperspace jobs create \
@@ -213,37 +213,37 @@ function create(params, cb) {
213213
return cb(err);
214214
}
215215

216-
function maybeTailLogs(err, resp) {
216+
function maybeTailLogs(err, res) {
217217
if (global.paperspace_cli && !json && tail) {
218218
if (err) return cb(err);
219-
if (!resp.id) return new Error('Job create failed; job id not found.');
220-
var jobId = resp.id;
221-
console.log('New jobId: ' + resp.id);
222-
console.log('Job ' + resp.state);
223-
if (resp.state === 'Pending') console.log('Waiting for job to run...');
224-
return jobs_waitfor({ jobId: jobId, state: 'Running' }, function _waitforCb(err, resp) {
219+
if (!res.id) return new Error('Job create failed; job id not found.');
220+
var jobId = res.id;
221+
console.log('New jobId: ' + res.id);
222+
console.log('Job ' + res.state);
223+
if (res.state === 'Pending') console.log('Waiting for job to run...');
224+
return jobs_waitfor({ jobId: jobId, state: 'Running' }, function _waitforCb(err, res) {
225225
if (err) return cb(err);
226-
if (!resp.state) return new Error('Job state not found.');
227-
var state = resp.state;
226+
if (!res.state) return new Error('Job state not found.');
227+
var state = res.state;
228228
console.log('Job ' + state);
229229
if (state !== 'Stopped' && state !== 'Failed' && state !== 'Running') {
230-
if (state === 'Error' || resp.jobError) console.log('Error: ' + resp.jobError);
230+
if (state === 'Error' || res.jobError) console.log('Error: ' + res.jobError);
231231
return cb();
232232
}
233233
console.log('Awaiting logs...');
234234
return jobs_logs({ jobId: jobId, tail: true }, function _logsCb(err) {
235235
if (err) return cb(err);
236-
return jobs_show({ jobId: jobId }, function _showCb(err, resp) {
236+
return jobs_show({ jobId: jobId }, function _showCb(err, res) {
237237
if (err) return cb(err);
238-
if (!resp.state) return new Error('Job state not found.');
239-
console.log('Job ' + resp.state + (resp.exitCode || resp.exitCode === 0 ? ', exitCode ' + resp.exitCode : ''));
240-
if (resp.state === 'Error' || resp.jobError) console.log('Error: ' + resp.jobError);
238+
if (!res.state) return new Error('Job state not found.');
239+
console.log('Job ' + res.state + (res.exitCode || res.exitCode === 0 ? ', exitCode ' + res.exitCode : ''));
240+
if (res.state === 'Error' || res.jobError) console.log('Error: ' + res.jobError);
241241
return cb();
242242
});
243243
});
244244
});
245245
}
246-
return cb(err, resp);
246+
return cb(err, res);
247247
}
248248

249249
// don't allow zipping of the root directory
@@ -292,10 +292,10 @@ function create(params, cb) {
292292

293293
// save workspace file name as a extra parameter since we are not using multer to parse the files on the server
294294
params.workspaceFileName = path.basename(params.workspace);
295-
return method(create, params, function _methodCb(err, resp) {
295+
return method(create, params, function _methodCb(err, res) {
296296
if (err) return cb(err);
297-
if (resp) projectConfig.setLastJobId(resp.project, resp.id);
298-
return maybeTailLogs(err, resp);
297+
if (res) projectConfig.setLastJobId(res.project, res.id);
298+
return maybeTailLogs(err, res);
299299
});
300300
});
301301

@@ -367,10 +367,10 @@ function create(params, cb) {
367367

368368
// save workspace file name as a extra parameter since we are not using multer to parse the files on the server
369369
params.workspaceFileName = path.basename(params.workspace);
370-
return method(create, params, function _methodCb(err, resp) {
370+
return method(create, params, function _methodCb(err, res) {
371371
if (err) return cb(err);
372-
if (resp) projectConfig.setLastJobId(resp.project, resp.id);
373-
return maybeTailLogs(err, resp);
372+
if (res) projectConfig.setLastJobId(res.project, res.id);
373+
return maybeTailLogs(err, res);
374374
});
375375
}
376376
} else {
@@ -381,10 +381,10 @@ function create(params, cb) {
381381

382382
// don't try to upload it; we normally attempt to upload anything in the workspace param specified in assign() below
383383
delete params.workspace;
384-
return method(create, params, function _methodCb(err, resp) {
384+
return method(create, params, function _methodCb(err, res) {
385385
if (err) return cb(err);
386-
if (resp) projectConfig.setLastJobId(resp.project, resp.id);
387-
return maybeTailLogs(err, resp);
386+
if (res) projectConfig.setLastJobId(res.project, res.id);
387+
return maybeTailLogs(err, res);
388388
});
389389
}
390390
}

‎lib/jobs/destroy.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ var assign = require('lodash.assign');
1616
* @example
1717
* paperspace.jobs.destroy({
1818
* jobId: 'j123abc',
19-
* }, function(err, resp) {
20-
* // handle error or http response
19+
* }, function(err, res) {
20+
* // handle error or result
2121
* });
2222
* @example
2323
* $ paperspace jobs destroy --jobId "j123abc"
@@ -32,10 +32,10 @@ var assign = require('lodash.assign');
3232
function destroy(params, cb) {
3333
params.jobId = projectConfig.getLastJobId(null, params.jobId);
3434
var lastJobId = params.jobId;
35-
return method(destroy, params, function _methodCb(err, resp) {
35+
return method(destroy, params, function _methodCb(err, res) {
3636
if (err) return cb(err);
3737
projectConfig.removeLastJobId(lastJobId);
38-
return cb(err, resp);
38+
return cb(err, res);
3939
});
4040
}
4141

‎lib/jobs/list.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ var path = require('path');
2626
* @example
2727
* paperspace.jobs.list(
2828
* project: 'MyProject'
29-
* } function(err, resp) {
30-
* // handle error or http response
29+
* } function(err, res) {
30+
* // handle error or result
3131
* });
3232
* @example
3333
* $ paperspace jobs list --project "MyProject"

‎lib/jobs/logs.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ var assign = require('lodash.assign');
1919
* @example
2020
* paperspace.jobs.logs({
2121
* jobId: 'j123abc',
22-
* }, function(err, resp) {
23-
* // handle error or http response
22+
* }, function(err, res) {
23+
* // handle error or result
2424
* });
2525
* @example
2626
* $ paperspace jobs logs \

‎lib/jobs/show.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ var assign = require('lodash.assign');
1515
* @example
1616
* paperspace.jobs.show({
1717
* jobId: 'j123abc',
18-
* }, function(err, resp) {
19-
* // handle error or http response
18+
* }, function(err, res) {
19+
* // handle error or result
2020
* });
2121
* @example
2222
* $ paperspace jobs show \

0 commit comments

Comments
 (0)