Skip to content
This repository was archived by the owner on Jun 6, 2023. It is now read-only.

Commit b339932

Browse files
committed
Revert "Remove lodash dependency"
This reverts commit a38efb7. Not sure how to get this to work: getting "TypeError: Cannot assign to read only property for all methods" when running with this commit. Will revert back for now.
1 parent d478542 commit b339932

35 files changed

+530
-404
lines changed

lib/jobs/artifactsDestroy.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56

67
/**
78
* @memberof jobs
@@ -37,7 +38,7 @@ function artifactsDestroy(params, cb) {
3738
return method(artifactsDestroy, params, cb);
3839
}
3940

40-
Object.assign(artifactsDestroy, {
41+
assign(artifactsDestroy, {
4142
auth: true,
4243
group: 'jobs',
4344
name: 'artifactsDestroy',

lib/jobs/artifactsGet.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56
var AWS = require('aws-sdk');
67
var fs = require('fs');
78
var path = require('path');
@@ -215,7 +216,7 @@ function artifactsGet(params, cb) {
215216
});
216217
}
217218

218-
Object.assign(artifactsGet, {
219+
assign(artifactsGet, {
219220
auth: true,
220221
group: 'jobs',
221222
name: 'artifactsGet',

lib/jobs/artifactsList.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56

67
/**
78
* @memberof jobs
@@ -68,7 +69,7 @@ function artifactsList(params, cb) {
6869
});
6970
}
7071

71-
Object.assign(artifactsList, {
72+
assign(artifactsList, {
7273
auth: true,
7374
group: 'jobs',
7475
name: 'artifactsList',

lib/jobs/clone.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56

67
/**
78
* @memberof jobs
@@ -65,7 +66,7 @@ function clone(params, cb) {
6566
});
6667
}
6768

68-
Object.assign(clone, {
69+
assign(clone, {
6970
auth: true,
7071
group: 'jobs',
7172
name: 'clone',

lib/jobs/create.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22

33
var method = require('./../method');
4+
var assign = require('lodash.assign');
45
var path = require('path');
56
var mkdirp = require('mkdirp');
67
var async = require('async');
@@ -501,7 +502,7 @@ function create(params, cb) {
501502
// if link pass in workspaceFileName param for jobs service to download it when running the job
502503
if (params.workspace.startsWith('https://') || params.workspace.startsWith('git+https://')) params.workspaceFileName = params.workspace;
503504

504-
// don't try to upload it; we normally attempt to upload anything in the workspace param specified in Object.assign() below
505+
// don't try to upload it; we normally attempt to upload anything in the workspace param specified in assign() below
505506
delete params.workspace;
506507
return method(create, params, function _methodCb(err, res) {
507508
if (err) return cb(err);
@@ -517,7 +518,7 @@ function getFilesizeInBytes(filename) {
517518
return fileSizeInBytes;
518519
}
519520

520-
Object.assign(create, {
521+
assign(create, {
521522
auth: true,
522523
group: 'jobs',
523524
name: 'create',

lib/jobs/destroy.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56

67
/**
78
* @memberof jobs
@@ -38,7 +39,7 @@ function destroy(params, cb) {
3839
});
3940
}
4041

41-
Object.assign(destroy, {
42+
assign(destroy, {
4243
auth: true,
4344
group: 'jobs',
4445
name: 'destroy',

lib/jobs/list.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56
var path = require('path');
67
var Table = require('table');
78

@@ -144,7 +145,7 @@ function list(params, cb) {
144145
});
145146
}
146147

147-
Object.assign(list, {
148+
assign(list, {
148149
auth: true,
149150
group: 'jobs',
150151
name: 'list',

lib/jobs/logs.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56

67
/**
78
* @memberof jobs
@@ -131,7 +132,7 @@ function logs(params, cb) {
131132
}
132133

133134

134-
Object.assign(logs, {
135+
assign(logs, {
135136
auth: true,
136137
group: 'jobs',
137138
name: 'logs',

lib/jobs/machineTypes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22

33
var method = require('./../method');
4+
var assign = require('lodash.assign');
45

56
/**
67
* @memberof jobs
@@ -65,7 +66,7 @@ function machineTypes(params, cb) {
6566
return method(machineTypes, params, cb);
6667
}
6768

68-
Object.assign(machineTypes, {
69+
assign(machineTypes, {
6970
auth: true,
7071
group: 'jobs',
7172
name: 'machineTypes',

lib/jobs/show.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var method = require('./../method');
44
var projectConfig = require('./../projectConfig');
5+
var assign = require('lodash.assign');
56

67
/**
78
* @memberof jobs
@@ -63,7 +64,7 @@ function show(params, cb) {
6364
return method(show, params, cb);
6465
}
6566

66-
Object.assign(show, {
67+
assign(show, {
6768
auth: true,
6869
group: 'jobs',
6970
name: 'show',

0 commit comments

Comments
 (0)