Switch PreferContentManagerDataLoader to refer to full asset name

Author: SinZ163

src/SMAPI.ModBuildConfig.Analyzer.Tests/ContentManagerAnalyzerTests.cs

@@ -97,7 +97,7 @@ public void BadType_RaisesDiagnostic(string codeText, int column, string assetNa
             DiagnosticResult preferDataLoader = new()
             {
                 Id = "PreferContentManagerDataLoader",
-                Message = $"'{assetName[5..]}' can be accessed using 'DataLoader.{assetName[5..]}(LocalizedContentManager content)' instead. See https://smapi.io/package/prefer-contentmanager-dataloader for details.",
+                Message = $"'{assetName}' can be accessed using 'DataLoader.{assetName[5..]}(LocalizedContentManager content)' instead. See https://smapi.io/package/prefer-contentmanager-dataloader for details.",
                 Severity = DiagnosticSeverity.Info,
                 Locations = [new DiagnosticResultLocation("Test0.cs", SampleCodeLine, SampleCodeColumn + column)]
             };
@@ -114,15 +114,15 @@ public void BadType_RaisesDiagnostic(string codeText, int column, string assetNa
         /// <param name="expression">The expression which should be reported.</param>
         /// <param name="netType">The net type name which should be reported.</param>
         /// <param name="suggestedProperty">The suggested property name which should be reported.</param>
-        [TestCase("Game1.content.Load<Dictionary<string, string>>(\"Data\\\\Fish\");", 0, "Fish")]
+        [TestCase("Game1.content.Load<Dictionary<string, string>>(\"Data\\\\Fish\");", 0, "Data\\Fish")]
         public void PreferDataLoader_RaisesDiagnostic(string codeText, int column, string assetName)
         {
             // arrange
             string code = SampleProgram.Replace("{{test-code}}", codeText);
             DiagnosticResult preferDataLoader = new()
             {
                 Id = "PreferContentManagerDataLoader",
-                Message = $"'{assetName}' can be accessed using 'DataLoader.{assetName}(LocalizedContentManager content)' instead. See https://smapi.io/package/prefer-contentmanager-dataloader for details.",
+                Message = $"'{assetName}' can be accessed using 'DataLoader.{assetName[5..]}(LocalizedContentManager content)' instead. See https://smapi.io/package/prefer-contentmanager-dataloader for details.",
                 Severity = DiagnosticSeverity.Info,
                 Locations = [new DiagnosticResultLocation("Test0.cs", SampleCodeLine, SampleCodeColumn + column)]
             };

src/SMAPI.ModBuildConfig.Analyzer/ContentManagerAnalyzer.cs

@@ -30,7 +30,7 @@ public class ContentManagerAnalyzer : DiagnosticAnalyzer
         private readonly DiagnosticDescriptor PreferDataLoader = new(
             id: "PreferContentManagerDataLoader",
             title: "Prefer using DataLoader to ContentManager Loads",
-            messageFormat: "'{0}' can be accessed using 'DataLoader.{0}(LocalizedContentManager content)' instead. See https://smapi.io/package/prefer-contentmanager-dataloader for details.",
+            messageFormat: "'{0}' can be accessed using 'DataLoader.{1}(LocalizedContentManager content)' instead. See https://smapi.io/package/prefer-contentmanager-dataloader for details.",
             category: "SMAPI.CommonErrors",
             defaultSeverity: DiagnosticSeverity.Info,
             isEnabledByDefault: true,
@@ -79,7 +79,7 @@ private void AnalyzeContentManagerLoads(SyntaxNodeAnalysisContext context)
                 {
                     context.ReportDiagnostic(Diagnostic.Create(this.AvoidBadTypeRule, context.Node.GetLocation(), assetName, method.ReturnType.ToString(), genericArgument.ToString()));
                 }
-                context.ReportDiagnostic(Diagnostic.Create(this.PreferDataLoader, context.Node.GetLocation(), dataAsset));
+                context.ReportDiagnostic(Diagnostic.Create(this.PreferDataLoader, context.Node.GetLocation(), assetName, dataAsset));
             }
         }
     }