From b581f394c9faa277908f4949bbdb6c487525720d Mon Sep 17 00:00:00 2001
From: RisingOrange <jakub.fidler@protonmail.com>
Date: Sat, 21 Feb 2026 20:46:36 +0100
Subject: [PATCH 1/6] fix: eliminate banner flash on page reload by injecting
 CSS before first paint

Add an inline blocking script in app.html that reads localStorage before
first paint and injects display:none CSS for any dismissed banners. Add
data-banner-id and data-campaign-banner-id attributes to banner elements
for CSS targeting. Move Banner.svelte's hidden state check from onMount to
initialization time. Remove debug console.logs and buggy global DOM click
listener from Banner.svelte. Remove stale india-summit-2026 localStorage
setter from layout.svelte.
---
 src/app.html                             | 21 ++++++++++++
 src/lib/components/Banner.svelte         | 41 ++----------------------
 src/lib/components/CampaignBanner.svelte |  2 +-
 src/routes/+layout.svelte                |  5 ---
 4 files changed, 24 insertions(+), 45 deletions(-)

diff --git a/src/app.html b/src/app.html
index 79f968e3d..8b2f21cfe 100644
--- a/src/app.html
+++ b/src/app.html
@@ -10,6 +10,27 @@
 			document.documentElement.setAttribute('color-scheme', 'dark')
 		</script>
 
+		<script>
+			try {
+				var css = ''
+				for (var i = 0; i < localStorage.length; i++) {
+					var key = localStorage.key(i)
+					if (!key || localStorage.getItem(key) !== 'true') continue
+					var m
+					if ((m = key.match(/^banner_(.+)_hidden$/))) {
+						css += '[data-banner-id="' + m[1] + '"]{display:none!important}'
+					} else if ((m = key.match(/^campaign_banner_(.+)_hidden$/))) {
+						css += '[data-campaign-banner-id="' + m[1] + '"]{display:none!important}'
+					}
+				}
+				if (css) {
+					var s = document.createElement('style')
+					s.textContent = css
+					document.head.appendChild(s)
+				}
+			} catch (e) {}
+		</script>
+
 		<!-- Google Tag Manager -->
 		<script>
 			;(function (w, d, s, l, i) {
diff --git a/src/lib/components/Banner.svelte b/src/lib/components/Banner.svelte
index 61a4a06fd..a9d1540d7 100644
--- a/src/lib/components/Banner.svelte
+++ b/src/lib/components/Banner.svelte
@@ -1,36 +1,19 @@
 <script lang="ts">
 	import X from 'lucide-svelte/icons/x'
 	import { page } from '$app/stores'
-	import { onMount } from 'svelte'
 	import { browser } from '$app/environment'
 	import { fade } from 'svelte/transition'
 
 	export let contrast = false
 	export let target: string | null = null
 	export let id: string | null = null
-	export let hidden = false
+	let hidden = browser && id ? localStorage.getItem(`banner_${id}_hidden`) === 'true' : false
 
-	// Function to check localStorage on mount
-	function checkStoredState() {
-		if (browser && id) {
-			const storedState = localStorage.getItem(`banner_${id}_hidden`)
-			if (storedState === 'true') {
-				hidden = true
-				console.log(`Banner ${id} restored from storage as hidden`)
-			}
-		}
-	}
-
-	// Simplest possible click handler
 	function closeClick() {
-		console.log('Close button clicked! ' + new Date().toISOString())
 		hidden = true
-
-		// Save state if we have an ID
 		if (browser && id) {
 			try {
 				localStorage.setItem(`banner_${id}_hidden`, 'true')
-				console.log('Saved to localStorage')
 			} catch (e) {
 				console.error(e)
 			}
@@ -41,30 +24,10 @@
 		const path = $page.url.pathname
 		if (path === target) hidden = true
 	}
-
-	onMount(() => {
-		checkStoredState()
-
-		// Debug info
-		console.log('Banner component mounted')
-
-		// Extra safety - add global click handler in case event bubbling is an issue
-		if (browser) {
-			const closeBtn = document.querySelector('.banner-close-btn')
-			if (closeBtn) {
-				closeBtn.addEventListener('click', (e) => {
-					e.preventDefault()
-					e.stopPropagation()
-					console.log('Direct DOM click handler fired')
-					closeClick()
-				})
-			}
-		}
-	})
 </script>
 
 {#if !hidden}
-	<div class="banner" class:contrast transition:fade={{ duration: 200 }}>
+	<div class="banner" class:contrast data-banner-id={id} transition:fade={{ duration: 200 }}>
 		<span class="content">
 			<slot />
 		</span>
diff --git a/src/lib/components/CampaignBanner.svelte b/src/lib/components/CampaignBanner.svelte
index 2f35b1374..c8777378b 100644
--- a/src/lib/components/CampaignBanner.svelte
+++ b/src/lib/components/CampaignBanner.svelte
@@ -32,7 +32,7 @@
 </script>
 
 {#if !hidden}
-	<div class="campaign-banner" transition:fade={{ duration: 200 }}>
+	<div class="campaign-banner" data-campaign-banner-id={id} transition:fade={{ duration: 200 }}>
 		<div class="accent-line"></div>
 		<div class="campaign-content">
 			<LinkWithoutIcon {href} class="campaign-link" on:click={close}>
diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte
index 8a9965d0c..d85d2b2e9 100644
--- a/src/routes/+layout.svelte
+++ b/src/routes/+layout.svelte
@@ -1,5 +1,4 @@
 <script lang="ts">
-	import { browser } from '$app/environment'
 	import type { GeoApiResponse } from '$api/geo/+server'
 	import { page } from '$app/stores'
 	import Banner from '$lib/components/Banner.svelte'
@@ -35,10 +34,6 @@
 	// Show the hero on the homepage, but nowhere else
 	$: hero = deLocalizeHref($page.url.pathname) === '/'
 
-	$: if (browser && deLocalizeHref($page.url.pathname) === '/india-summit-2026') {
-		localStorage.setItem('campaign_banner_india-summit-2026_hidden', 'true')
-	}
-
 	onMount(async () => {
 		const response = await fetch('/api/geo')
 		geo = await response.json()

From 949c68bbe01f9d7b338d893c51db452247f45ce8 Mon Sep 17 00:00:00 2001
From: RisingOrange <jakub.fidler@protonmail.com>
Date: Sat, 21 Feb 2026 21:05:23 +0100
Subject: [PATCH 2/6] fix: guard localStorage reads against SecurityError in
 storage-restricted contexts

---
 src/lib/components/Banner.svelte         | 7 ++++++-
 src/lib/components/CampaignBanner.svelte | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/lib/components/Banner.svelte b/src/lib/components/Banner.svelte
index a9d1540d7..c9ebc5b69 100644
--- a/src/lib/components/Banner.svelte
+++ b/src/lib/components/Banner.svelte
@@ -7,7 +7,12 @@
 	export let contrast = false
 	export let target: string | null = null
 	export let id: string | null = null
-	let hidden = browser && id ? localStorage.getItem(`banner_${id}_hidden`) === 'true' : false
+	let hidden = false
+	if (browser && id) {
+		try {
+			hidden = localStorage.getItem(`banner_${id}_hidden`) === 'true'
+		} catch (e) {}
+	}
 
 	function closeClick() {
 		hidden = true
diff --git a/src/lib/components/CampaignBanner.svelte b/src/lib/components/CampaignBanner.svelte
index c8777378b..064dcaf2c 100644
--- a/src/lib/components/CampaignBanner.svelte
+++ b/src/lib/components/CampaignBanner.svelte
@@ -9,7 +9,12 @@
 
 	export let href: string
 	export let id = 'campaign'
-	let hidden = browser && id && localStorage.getItem(`campaign_banner_${id}_hidden`) === 'true'
+	let hidden = false
+	if (browser && id) {
+		try {
+			hidden = localStorage.getItem(`campaign_banner_${id}_hidden`) === 'true'
+		} catch (e) {}
+	}
 
 	function close() {
 		hidden = true

From 4b7f001af3880b6f503af4865cd203e793faef80 Mon Sep 17 00:00:00 2001
From: RisingOrange <jakub.fidler@protonmail.com>
Date: Sat, 21 Feb 2026 21:09:59 +0100
Subject: [PATCH 3/6] fix: satisfy no-empty lint rule in catch blocks

---
 src/lib/components/Banner.svelte         | 4 +++-
 src/lib/components/CampaignBanner.svelte | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/lib/components/Banner.svelte b/src/lib/components/Banner.svelte
index c9ebc5b69..064f1cbb7 100644
--- a/src/lib/components/Banner.svelte
+++ b/src/lib/components/Banner.svelte
@@ -11,7 +11,9 @@
 	if (browser && id) {
 		try {
 			hidden = localStorage.getItem(`banner_${id}_hidden`) === 'true'
-		} catch (e) {}
+		} catch {
+			// SecurityError in storage-restricted contexts
+		}
 	}
 
 	function closeClick() {
diff --git a/src/lib/components/CampaignBanner.svelte b/src/lib/components/CampaignBanner.svelte
index 064dcaf2c..0f31fbcb3 100644
--- a/src/lib/components/CampaignBanner.svelte
+++ b/src/lib/components/CampaignBanner.svelte
@@ -13,7 +13,9 @@
 	if (browser && id) {
 		try {
 			hidden = localStorage.getItem(`campaign_banner_${id}_hidden`) === 'true'
-		} catch (e) {}
+		} catch {
+			// SecurityError in storage-restricted contexts
+		}
 	}
 
 	function close() {

From c16a4874f8279fcab18346286f17872c00a25e24 Mon Sep 17 00:00:00 2001
From: RisingOrange <jakub.fidler@protonmail.com>
Date: Sat, 21 Feb 2026 21:29:51 +0100
Subject: [PATCH 4/6] docs: add comment explaining banner no-flash script

---
 src/app.html | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/app.html b/src/app.html
index 8b2f21cfe..3f92821dd 100644
--- a/src/app.html
+++ b/src/app.html
@@ -10,6 +10,9 @@
 			document.documentElement.setAttribute('color-scheme', 'dark')
 		</script>
 
+		<!-- Prevent dismissed banners from flashing on reload by hiding them before first paint,
+		     same technique as the color-scheme script above. Matches localStorage keys set by
+		     Banner.svelte (banner_<id>_hidden) and CampaignBanner.svelte (campaign_banner_<id>_hidden). -->
 		<script>
 			try {
 				var css = ''

From 42d1d5aee2aeef5a8512f33ee23ea1da2f022f5c Mon Sep 17 00:00:00 2001
From: RisingOrange <jakub.fidler@protonmail.com>
Date: Sat, 21 Feb 2026 21:33:42 +0100
Subject: [PATCH 5/6] refactor: use data-driven bannerTypes map in no-flash
 script

---
 src/app.html | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/app.html b/src/app.html
index 3f92821dd..a87c4e5a9 100644
--- a/src/app.html
+++ b/src/app.html
@@ -11,19 +11,20 @@
 		</script>
 
 		<!-- Prevent dismissed banners from flashing on reload by hiding them before first paint,
-		     same technique as the color-scheme script above. Matches localStorage keys set by
-		     Banner.svelte (banner_<id>_hidden) and CampaignBanner.svelte (campaign_banner_<id>_hidden). -->
+		     same technique as the color-scheme script above. -->
 		<script>
 			try {
+				var bannerTypes = [
+					{ pattern: /^banner_(.+)_hidden$/, attr: 'data-banner-id' },
+					{ pattern: /^campaign_banner_(.+)_hidden$/, attr: 'data-campaign-banner-id' }
+				]
 				var css = ''
 				for (var i = 0; i < localStorage.length; i++) {
 					var key = localStorage.key(i)
 					if (!key || localStorage.getItem(key) !== 'true') continue
-					var m
-					if ((m = key.match(/^banner_(.+)_hidden$/))) {
-						css += '[data-banner-id="' + m[1] + '"]{display:none!important}'
-					} else if ((m = key.match(/^campaign_banner_(.+)_hidden$/))) {
-						css += '[data-campaign-banner-id="' + m[1] + '"]{display:none!important}'
+					for (var j = 0; j < bannerTypes.length; j++) {
+						var m = key.match(bannerTypes[j].pattern)
+						if (m) css += '[' + bannerTypes[j].attr + '="' + m[1] + '"]{display:none!important}'
 					}
 				}
 				if (css) {

From f4787d15f16462db9607dbc0f84439ccc166bfc6 Mon Sep 17 00:00:00 2001
From: RisingOrange <jakub.fidler@protonmail.com>
Date: Sat, 21 Feb 2026 21:36:46 +0100
Subject: [PATCH 6/6] refactor: use template literal in no-flash script

---
 src/app.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app.html b/src/app.html
index a87c4e5a9..ab1de40fa 100644
--- a/src/app.html
+++ b/src/app.html
@@ -24,7 +24,7 @@
 					if (!key || localStorage.getItem(key) !== 'true') continue
 					for (var j = 0; j < bannerTypes.length; j++) {
 						var m = key.match(bannerTypes[j].pattern)
-						if (m) css += '[' + bannerTypes[j].attr + '="' + m[1] + '"]{display:none!important}'
+						if (m) css += `[${bannerTypes[j].attr}="${m[1]}"]{display:none!important}`
 					}
 				}
 				if (css) {