Fix Oracle SQL builder

PhenX · PhenX · commit 58f3936b15a7 · 2026-06-20T22:59:04.000+02:00
diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/OracleDialectBuilder.cs b/src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/OracleDialectBuilder.cs
@@ -101,7 +101,11 @@ public override string BuildMoveDataSql<T>(
                 ? insertedColumns.Where(c => !matchColumnSet.Contains(c.QuotedColumName)).ToList()
                 : new List<ColumnMetadata>();
 
-            if (updateableColumns.Count > 0)
+            var updates = updateableColumns.Count > 0
+                ? GetUpdates(context, target, updateableColumns, onConflictTyped.Update!).ToList()
+                : [];
+
+            if (updates.Count > 0)
             {
                 q.Append("WHEN MATCHED ");
 
@@ -117,7 +121,7 @@ public override string BuildMoveDataSql<T>(
                 }
 
                 q.AppendLine("THEN UPDATE SET ");
-                q.AppendJoin(", ", GetUpdates(context, target, updateableColumns, onConflictTyped.Update));
+                q.AppendJoin(", ", updates);
                 q.AppendLine();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,11 @@ public override string BuildMoveDataSql<T>(`
`101`	`101`	`? insertedColumns.Where(c => !matchColumnSet.Contains(c.QuotedColumName)).ToList()`
`102`	`102`	`: new List<ColumnMetadata>();`
`103`	`103`
`104`		`- if (updateableColumns.Count > 0)`
	`104`	`+ var updates = updateableColumns.Count > 0`
	`105`	`+ ? GetUpdates(context, target, updateableColumns, onConflictTyped.Update!).ToList()`
	`106`	`+ : [];`
	`107`	`+`
	`108`	`+ if (updates.Count > 0)`
`105`	`109`	`{`
`106`	`110`	`q.Append("WHEN MATCHED ");`
`107`	`111`
`@@ -117,7 +121,7 @@ public override string BuildMoveDataSql<T>(`
`117`	`121`	`}`
`118`	`122`
`119`	`123`	`q.AppendLine("THEN UPDATE SET ");`
`120`		`- q.AppendJoin(", ", GetUpdates(context, target, updateableColumns, onConflictTyped.Update));`
	`124`	`+ q.AppendJoin(", ", updates);`
`121`	`125`	`q.AppendLine();`
`122`	`126`	`}`
`123`	`127`	`}`