Fix a bug in multipolygon_to_feature_collection

- This was returning an misformed MultiPolygon. Added a test to
cover this function
- Also fixed a hardcoded value (2) that was intended to be taken from
a function argument (num_features)

Author: stephanerestani-picterra

src/picterra/base_client.py

@@ -86,7 +86,7 @@ def multipolygon_to_feature_collection(mp):
                 "type": "Polygon",
                 "coordinates": p
             }
-        } for p in mp]
+        } for p in mp["coordinates"]]
     }
 
 T = TypeVar("T")

tests/test_client.py

@@ -394,7 +394,7 @@ def add_mock_vector_layer_download_responses(layer_id, num_features):
     }
     add_mock_operations_responses("success", results=results)
     url = results["download_url"]
-    mp = make_geojson_multipolygon(2)
+    mp = make_geojson_multipolygon(num_features)
     responses.add(
         responses.GET,
         url,
@@ -603,6 +603,35 @@ def add_mock_folder_detector_response(folder_id: str):
     )
 
 
+def test_multipolygon_to_feature_collection():
+    mp = {
+        "type": "MultiPolygon",
+        "coordinates": [
+            [[[0, 0], [0, 1], [1, 1], [1, 0], [0, 0]]],
+            [[[1, 1], [1, 2], [2, 2], [2, 1], [1, 1]]]
+        ]
+    }
+    fc = multipolygon_to_feature_collection(mp)
+    assert fc == {
+        "type": "FeatureCollection",
+        "features": [{
+            "type": "Feature",
+            "properties": {},
+            "geometry": {
+                "type": "Polygon",
+                "coordinates": [[[0, 0], [0, 1], [1, 1], [1, 0], [0, 0]]]
+            }
+        },  {
+            "type": "Feature",
+            "properties": {},
+            "geometry": {
+                "type": "Polygon",
+                "coordinates": [[[1, 1], [1, 2], [2, 2], [2, 1], [1, 1]]]
+            }
+        }]
+    }
+
+
 def test_detector_platform_client_base_url(monkeypatch):
     """
     Sanity-check that the client defaults to the correct base url