setup.py: simplified compiler settings

Author: PierreRaybaut

setup.py

@@ -25,22 +25,6 @@ def is_msvc():
     return os.name == "nt" and "mingw" not in "".join(sys.argv)
 
 
-def get_compiler_flags():
-    """Get compiler flags for C++ dependencies compilation"""
-    if is_msvc():
-        cflags = ["/EHsc"]
-    else:
-        cflags = ["-Wall"]
-    for arg, compile_arg in (("--sse2", "-msse2"), ("--sse3", "-msse3")):
-        if arg in sys.argv:
-            sys.argv.pop(sys.argv.index(arg))
-            cflags.insert(0, compile_arg)
-    return cflags
-
-
-CFLAGS_CPP = get_compiler_flags()
-
-
 def compile_cython_extensions():
     """Compile Cython extensions"""
     for fname in os.listdir(SRCPATH):
@@ -52,17 +36,18 @@ def compile_cython_extensions():
 
 INCLUDE_DIRS = [SRCPATH, numpy.get_include()]
 
+MACROS_CYTHON = [("NPY_NO_DEPRECATED_API", "NPY_1_7_API_VERSION")]
+CFLAGS_CYTHON = []
 # -------------------------------------------------------------------------------------
-# TODO: When dropping support for Cython < 3.0, we can remove the following line
-# and uncomment the next one.
+# TODO: When dropping support for Cython < 3.0, we can remove the following lines.
 # In the meantime, we hide the deprecation warnings when building the package.
-DEFINE_MACROS_CYTHON = []
-CFLAGS_CYTHON = ["-Wno-cpp"]
-# DEFINE_MACROS_CYTHON = [("NPY_NO_DEPRECATED_API", "NPY_1_7_API_VERSION")]
-# CFLAGS_CYTHON = []
+if not is_msvc():
+    MACROS_CYTHON = []
+    CFLAGS_CYTHON = ["-Wno-cpp"]
 # -------------------------------------------------------------------------------------
 
-DEFINE_MACROS_CPP = [("NPY_NO_DEPRECATED_API", "NPY_1_7_API_VERSION")]
+MACROS_CPP = [("NPY_NO_DEPRECATED_API", "NPY_1_7_API_VERSION")]
+CFLAGS_CPP = ["/EHsc"] if is_msvc() else ["-Wall"]
 
 setup(
     ext_modules=[
@@ -71,21 +56,21 @@ def compile_cython_extensions():
             sources=[osp.join(SRCPATH, "mandelbrot.c")],
             include_dirs=INCLUDE_DIRS,
             extra_compile_args=CFLAGS_CYTHON,
-            define_macros=DEFINE_MACROS_CYTHON,
+            define_macros=MACROS_CYTHON,
         ),
         Extension(
             name=f"{LIBNAME}.histogram2d",
             sources=[osp.join(SRCPATH, "histogram2d.c")],
             include_dirs=INCLUDE_DIRS,
             extra_compile_args=CFLAGS_CYTHON,
-            define_macros=DEFINE_MACROS_CYTHON,
+            define_macros=MACROS_CYTHON,
         ),
         Extension(
             name=f"{LIBNAME}.contour2d",
             sources=[osp.join(SRCPATH, "contour2d.c")],
             include_dirs=INCLUDE_DIRS,
             extra_compile_args=CFLAGS_CYTHON,
-            define_macros=DEFINE_MACROS_CYTHON,
+            define_macros=MACROS_CYTHON,
         ),
         Extension(
             name=f"{LIBNAME}._scaler",
@@ -99,7 +84,7 @@ def compile_cython_extensions():
                 osp.join(SRCPATH, "debug.hpp"),
             ],
             include_dirs=INCLUDE_DIRS,
-            define_macros=DEFINE_MACROS_CPP,
+            define_macros=MACROS_CPP,
         ),
     ]
 )