[Bug] Datapacks which specify biome do not work with Terra #528
Description
Pre-Issue Checklist
- I have checked that I am on the latest version of Terra.
- I have searched the github issue tracker for similar issues, including
closed ones. - I have made sure that this is not a bug with another mod or plugin, and it
is Terra that is causing the issue. - I have checked that this is an issue with Terra and not an issue with the
pack I am using. - I have attached a copy of the
latest.logfile - I have filled out and provided all the appropriate information.
Environment
| Name | Value |
|---|---|
| Terra Version | 6.6.5-BETA+4ddb741d0 |
| Platform / Platform Version | Paper |
| Any External Plugins or Mods | Citizens, Essentials, Multiverse-Core, PlaceholderAPI, ProtocolLib, Quests, Vault |
| Terra Packs In Use | Custom pack but also tested with OVERWORLD |
| Terra Addons In Use | None |
Issue Description
Datapacks which specify a vanilla biome (such as "biomes": "minecraft:deep_ocean" in the very popular Tidal Towns pack), will not generate when using Terra as the primary world on a Paper server. Please note that the server will not allow specifying a Terra biome in this field.
Steps to reproduce
- Create Paper server with Terra installed. Do not join server, instead
/stop - Place biome-specific pack such as Tidal Towns in
<server>/world/datapacks - Start and join server, try to
/minecraft:locatestructure, command fails or crashes server (see log below)
Expected behavior
Structure should be able to be generated and located by command.
Actual behavior
No applicable structure is generated. It is possible to make the structure generate by changing the biome tag to something like "biomes": "#minecraft:has_structure/ocean_ruin_warm" but this workaround should not be considered a solution.
Full stacktrace
Not applicable, see Minecraft 1.21.8 log for thread dump. Also tested on 1.21.4, same plugins, same result.
Additional details
It is also not possible to locate the vanilla biome for which the structure should be generated in (namely /minecraft:locate biome deep_ocean does not work), although this command does not typically crash the server.