Merge pull request #34 from PortoCode/feature/image-feed/snapshot-tests

UI Snapshot Tests with Dark Mode support

Author: PortoCode

EssentialFeed/EssentialFeed.xcodeproj/project.pbxproj

@@ -75,8 +75,13 @@
 		5BA598BE2CE1998D007B1795 /* XCTestCase+MemoryLeakTracking.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5B8BB9982C02719F00D40D42 /* XCTestCase+MemoryLeakTracking.swift */; };
 		5BA598BF2CE19E50007B1795 /* FeedCacheTestHelpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5B034B422CA3A0C800FB65F8 /* FeedCacheTestHelpers.swift */; };
 		5BA598C02CE19EE0007B1795 /* SharedTestHelpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5B034B442CA3A1A100FB65F8 /* SharedTestHelpers.swift */; };
+		5BB735132D7CD33B00189186 /* UIImage+TestHelpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BB735122D7CD33B00189186 /* UIImage+TestHelpers.swift */; };
+		5BB735152D7CD9F900189186 /* UITableView+HeaderSizing.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BB735142D7CD9F900189186 /* UITableView+HeaderSizing.swift */; };
+		5BB735172D7D0BEE00189186 /* UIViewController+Snapshot.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BB735162D7D0BEE00189186 /* UIViewController+Snapshot.swift */; };
+		5BB735192D7D0CB000189186 /* XCTestCase+Snapshot.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BB735182D7D0CB000189186 /* XCTestCase+Snapshot.swift */; };
 		5BBDA00E2D6FCCF000D68DF0 /* FeedCache.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BBDA00D2D6FCCF000D68DF0 /* FeedCache.swift */; };
 		5BBDA01A2D6FF5F100D68DF0 /* FeedImageDataCache.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BBDA0192D6FF5F100D68DF0 /* FeedImageDataCache.swift */; };
+		5BBDA1AD2D7CCA8000D68DF0 /* FeedSnapshotTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BBDA1AC2D7CCA8000D68DF0 /* FeedSnapshotTests.swift */; };
 		5BC4F6CB2CDAF0B20002D4CF /* CoreDataHelpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BC4F6CA2CDAF0B20002D4CF /* CoreDataHelpers.swift */; };
 		5BC4F6CD2CDAF1B30002D4CF /* ManagedCache.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BC4F6CC2CDAF1B30002D4CF /* ManagedCache.swift */; };
 		5BC4F6CF2CDAF1C60002D4CF /* ManagedFeedImage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5BC4F6CE2CDAF1C60002D4CF /* ManagedFeedImage.swift */; };
@@ -212,8 +217,13 @@
 		5BA598BA2CE194BC007B1795 /* EssentialFeedCacheIntegrationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EssentialFeedCacheIntegrationTests.swift; sourceTree = "<group>"; };
 		5BA598BD2CE1954B007B1795 /* EssentialFeedCacheIntegrationTests.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = EssentialFeedCacheIntegrationTests.xctestplan; sourceTree = "<group>"; };
 		5BA598EA2CFABE45007B1795 /* EssentialFeedAPIEndToEndTests.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = EssentialFeedAPIEndToEndTests.xctestplan; sourceTree = "<group>"; };
+		5BB735122D7CD33B00189186 /* UIImage+TestHelpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIImage+TestHelpers.swift"; sourceTree = "<group>"; };
+		5BB735142D7CD9F900189186 /* UITableView+HeaderSizing.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UITableView+HeaderSizing.swift"; sourceTree = "<group>"; };
+		5BB735162D7D0BEE00189186 /* UIViewController+Snapshot.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIViewController+Snapshot.swift"; sourceTree = "<group>"; };
+		5BB735182D7D0CB000189186 /* XCTestCase+Snapshot.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "XCTestCase+Snapshot.swift"; sourceTree = "<group>"; };
 		5BBDA00D2D6FCCF000D68DF0 /* FeedCache.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeedCache.swift; sourceTree = "<group>"; };
 		5BBDA0192D6FF5F100D68DF0 /* FeedImageDataCache.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeedImageDataCache.swift; sourceTree = "<group>"; };
+		5BBDA1AC2D7CCA8000D68DF0 /* FeedSnapshotTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeedSnapshotTests.swift; sourceTree = "<group>"; };
 		5BC4F6CA2CDAF0B20002D4CF /* CoreDataHelpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CoreDataHelpers.swift; sourceTree = "<group>"; };
 		5BC4F6CC2CDAF1B30002D4CF /* ManagedCache.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ManagedCache.swift; sourceTree = "<group>"; };
 		5BC4F6CE2CDAF1C60002D4CF /* ManagedFeedImage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ManagedFeedImage.swift; sourceTree = "<group>"; };
@@ -393,7 +403,9 @@
 		5B4BAE8D2CFBA12700CE079A /* EssentialFeediOSTests */ = {
 			isa = PBXGroup;
 			children = (
+				5BB735112D7CD30C00189186 /* Helpers */,
 				5B4BAE922CFBA29600CE079A /* EssentialFeediOS.xctestplan */,
+				5BBDA1AC2D7CCA8000D68DF0 /* FeedSnapshotTests.swift */,
 			);
 			path = EssentialFeediOSTests;
 			sourceTree = "<group>";
@@ -449,6 +461,7 @@
 			children = (
 				5B6992D82D0662B200DD47E9 /* UIView+Shimmering.swift */,
 				5B8AB3672D52D73200CDDDEB /* UITableView+Dequeueing.swift */,
+				5BB735142D7CD9F900189186 /* UITableView+HeaderSizing.swift */,
 				5B8AB3692D52DC3600CDDDEB /* UIImageView+Animations.swift */,
 				5B74FD1E2D64A821007478DC /* UIRefreshControl+Helpers.swift */,
 			);
@@ -544,6 +557,16 @@
 			path = EssentialFeedCacheIntegrationTests;
 			sourceTree = "<group>";
 		};
+		5BB735112D7CD30C00189186 /* Helpers */ = {
+			isa = PBXGroup;
+			children = (
+				5BB735122D7CD33B00189186 /* UIImage+TestHelpers.swift */,
+				5BB735162D7D0BEE00189186 /* UIViewController+Snapshot.swift */,
+				5BB735182D7D0CB000189186 /* XCTestCase+Snapshot.swift */,
+			);
+			path = Helpers;
+			sourceTree = "<group>";
+		};
 		5BC4F6C82CDAEF750002D4CF /* Infrastructure */ = {
 			isa = PBXGroup;
 			children = (
@@ -907,6 +930,7 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				5BB735152D7CD9F900189186 /* UITableView+HeaderSizing.swift in Sources */,
 				5B74FD1A2D649D0E007478DC /* ErrorView.swift in Sources */,
 				5B74FD1F2D64A821007478DC /* UIRefreshControl+Helpers.swift in Sources */,
 				5B8AB3682D52D73200CDDDEB /* UITableView+Dequeueing.swift in Sources */,
@@ -923,6 +947,10 @@
 			buildActionMask = 2147483647;
 			files = (
 				5B6992972CFE8D8B00DD47E9 /* XCTestCase+MemoryLeakTracking.swift in Sources */,
+				5BBDA1AD2D7CCA8000D68DF0 /* FeedSnapshotTests.swift in Sources */,
+				5BB735192D7D0CB000189186 /* XCTestCase+Snapshot.swift in Sources */,
+				5BB735172D7D0BEE00189186 /* UIViewController+Snapshot.swift in Sources */,
+				5BB735132D7CD33B00189186 /* UIImage+TestHelpers.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

EssentialFeed/EssentialFeediOS/Feed UI/Composers/FeedImageDataLoaderPresentationAdapter.swift

@@ -32,6 +32,12 @@ public final class FeedViewController: UITableViewController, UITableViewDataSou
         }
     }
 
+    public override func viewDidLayoutSubviews() {
+        super.viewDidLayoutSubviews()
+        
+        tableView.sizeTableHeaderToFit()
+    }
+    
     @IBAction private func refresh() {
         delegate?.didRequestFeedRefresh()
     }

EssentialFeed/EssentialFeediOS/Feed UI/Composers/FeedLoaderPresentationAdapter.swift

@@ -6,24 +6,24 @@
 import UIKit
 
 public final class ErrorView: UIView {
-    @IBOutlet private(set) public var button: UIButton!
+    @IBOutlet private(set) public var label: UILabel!
 
     public var message: String? {
-        get { return isVisible ? button.title(for: .normal) : nil }
+        get { return isVisible ? label.text : nil }
         set { setMessageAnimated(newValue) }
     }
 
-    private var isVisible: Bool {
-        return alpha > 0
-    }
-    
     public override func awakeFromNib() {
         super.awakeFromNib()
 
-        button.setTitle(nil, for: .normal)
+        label.text = nil
         alpha = 0
     }
 
+    private var isVisible: Bool {
+        return alpha > 0
+    }
+    
     private func setMessageAnimated(_ message: String?) {
         if let message = message {
             showAnimated(message)
@@ -33,7 +33,7 @@ public final class ErrorView: UIView {
     }
 
     private func showAnimated(_ message: String) {
-        button.setTitle(message, for: .normal)
+        label.text = message
 
         UIView.animate(withDuration: 0.25) {
             self.alpha = 1
@@ -46,7 +46,7 @@ public final class ErrorView: UIView {
             animations: { self.alpha = 0 },
             completion: { completed in
                 if completed {
-                    self.button.setTitle(nil, for: .normal)
+                    self.label.text = nil
                 }
             })
     }