Skip to content

Commit b715256

Browse files
Fix Additional Packages dropdown becoming permanently disabled (#75)
* Initial plan * Fix Additional Packages dropdown behavior for Virtual/non-Virtual controls Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
1 parent 853d5f6 commit b715256

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

Maverick.PCF.Builder.DataObjects/ControlManifestDetails.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ public ControlManifestDetails()
1919
Properties = new List<ControlProperty>();
2020
Features = new List<Feature>();
2121
IsVirtual = false;
22+
AdditionalPackageIndex = 0; // Default to "None" (first item in the dropdown)
2223
}
2324

2425
public string WorkingFolderPath { get; set; }

Maverick.PCF.Builder/PCFBuilder.cs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -745,6 +745,9 @@ private void PopulateControlDetails()
745745

746746
cboxControlType.SelectedIndex = ControlDetails.IsVirtual ? 1 : 0;
747747
cboxTemplate.SelectedIndex = ControlDetails.IsDatasetTemplate ? 1 : 0;
748+
749+
// Restore the additional package selection from saved control details
750+
cboxAdditionalPackages.SelectedIndex = ControlDetails.AdditionalPackageIndex;
748751

749752
if (!string.IsNullOrEmpty(ControlDetails.PreviewImagePath))
750753
{
@@ -2673,11 +2676,16 @@ private void btnManageFeatures_Click(object sender, EventArgs e)
26732676

26742677
private void cboxControlType_SelectedIndexChanged(object sender, EventArgs e)
26752678
{
2676-
if ((string)cboxControlType.SelectedItem == "Virtual")
2679+
if (cboxControlType.SelectedItem != null && (string)cboxControlType.SelectedItem == "Virtual")
26772680
{
26782681
cboxAdditionalPackages.SelectedIndex = 1;
26792682
cboxAdditionalPackages.Enabled = false;
26802683
}
2684+
else
2685+
{
2686+
// Re-enable the additional packages dropdown for non-Virtual control types
2687+
cboxAdditionalPackages.Enabled = true;
2688+
}
26812689
}
26822690

26832691
#endregion

0 commit comments

Comments
 (0)