Clang-tidy: fix clang-tidy-20 issues #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
commented
Dec 5, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/job_dispatch.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
commented
Dec 5, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/job_dispatch.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
commented
Dec 5, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
…opology.hpp Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
commented
Dec 5, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
commented
Dec 5, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/job_dispatch.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
mgovers
commented
Dec 5, 2025
Member
Author
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
The final sonar cloud warning is a false positive
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
Member
Author
remaining sonar cloud warnings can't be resolved yet because our macos runners don't support |
mgovers
commented
Dec 8, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp
Show resolved
Hide resolved
TonyXiang8787
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2026 came out recently and it comes with LLVM 20. This fixes compatibility there:
static_cast; instead use either:std::ssize(directly obtain a signed value instead of unsigned for sizes)std::cmp_*(integer-safe comparison)IdxRangestd::views::zip/std::views::enumeratewhere index-based ranges were not necessary (only affected cases)portability-template-virtual-member-functionchecks because we already test on MSVC anyways so we do not need it, and it also resulted in false positives as a result of header-only stuff