From fbe6cfdc8fa59fc3b293627a1f02cce1c3d89886 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhovetskyi Date: Wed, 5 Nov 2025 10:12:14 +0100 Subject: [PATCH 1/5] add pr template and codeowners --- .github/pull_request_template.md | 10 ++++++++++ CODEOWNERS | 1 + 2 files changed, 11 insertions(+) create mode 100644 .github/pull_request_template.md create mode 100644 CODEOWNERS diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..5c2e160 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,10 @@ +## Describe your changes + +## Issue ticket number and link + +## Checklist before requesting a review + +- [ ] I have performed a self-review of my code +- [ ] If it is a core feature, I have added thorough tests +- [ ] Do we need to implement analytics? +- [ ] Will this be part of a product update? If yes, please write one phrase about this update diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000..13bdd95 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1 @@ +softservedata \ No newline at end of file From f269da39fadc7354b7366daff4cd181fcf9adea3 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhovetskyi Date: Wed, 5 Nov 2025 10:32:51 +0100 Subject: [PATCH 2/5] test webhook --- README.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6f95131..9308743 100644 --- a/README.md +++ b/README.md @@ -5,10 +5,12 @@ 2. Create branch `develop` as default branch. 3. Protect branches `main` and `develop` with these rules: + - user can't merge to both branches without pull request - allowed to merge to `develop` branch only if we have 2 approvals - merge to `main` branch allowed if only owner approved PR - assign the user `softservedata` as the code owner for all the files in the `main` branch + 4. Add template (pull_request_template.md) to `.github` directory for creating issue in format: ## Describe your changes @@ -16,6 +18,7 @@ ## Issue ticket number and link ## Checklist before requesting a review + - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests - [ ] Do we need to implement analytics? @@ -27,6 +30,7 @@ 7. Create discord server and add notification when PR was created. -8. For github actions: +8. For github actions: + - create PAT (Personal Access Token) with **Full control of private repositories** and **Full control of orgs and teams, read and write org projects** -- add to repository actions secrets key with the name `PAT` and the value of the created PAT +- add to repository actions secrets key with the name `PAT` and the value of the created PAT From 2eadbf0e1cb36846eac576be40bc82dac24918a9 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhovetskyi Date: Wed, 5 Nov 2025 10:39:41 +0100 Subject: [PATCH 3/5] fix codeowners --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 13bdd95..dfb3796 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1 +1 @@ -softservedata \ No newline at end of file +* @softservedata \ No newline at end of file From 1aee83f68efa9555a95b2c7c8916280f680ea503 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhovetskyi Date: Wed, 5 Nov 2025 10:48:28 +0100 Subject: [PATCH 4/5] test --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5c2e160..4ded5a6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -## Describe your changes +## Describe your changes: ## Issue ticket number and link From 084b536cf74406f99218ec6cddb47961dc2b2134 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhovetskyi Date: Wed, 5 Nov 2025 10:57:13 +0100 Subject: [PATCH 5/5] test --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4ded5a6..5c2e160 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -## Describe your changes: +## Describe your changes ## Issue ticket number and link