Preset: none

[ProgramMax]

@svgeesus suggested good idea to add a preset: none which will remove an existing cICP chunk.
This came up in #34. I'm adding a separate issue to track that idea.

An alternative name might be preset: remove.

[digitaltvguy]

Remove sounds contextually more accurate.

[ProgramMax]

I'm thinking of maybe changing the command line structure around to be more about actions.
Several tools do this. Take $git add or $ip link show. There is a verb in there.

To that end, maybe $cicp_inserter remove and $cicp_inserter add --preset srgb
I might even skip --preset to simplify things: $cicp_inserter add srgb

Taking this all a step further, $cicp_inserter remove is kind of weird. It isn't inserting. It is removing. Maybe the whole project should be renamed. png_cicp_tool? png_cicp_editor?

[digitaltvguy]

png_cicp_editor sounds good.

[ProgramMax]

The project has been renamed to png_cicp_editor.
The ability to remove the cICP chunk is still in the works.

[ProgramMax]

I think I'll go with:

$ png_cicp_editor add --preset srgb ~/file.png
This would add a cICP chunk but not overwrite an existing one.

$ png_cicp_editor overwrite --preset srgb ~/file.png
This would overwrite (or add if it didn't already exist--should it warn?).

$ png_cicp_editor remove ~/file.png

[digitaltvguy]

I think I'll go with:

$ png_cicp_editor add --preset srgb ~/file.png This would add a cICP chunk but not overwrite an existing one.

$ png_cicp_editor overwrite --preset srgb ~/file.png This would overwrite (or add if it didn't already exist--should it warn?).

$ png_cicp_editor remove ~/file.png

For "add", I don't think there should be multiple cICP chunks. Would it allow multiple cICP chunks to exist?

[ProgramMax]

Right, it wouldn't add a second.
If one already exists, the 'add' action will error.

[svgeesus]

remove is currently not working

chris@SuperNomad:/mnt/c/Users/chris/Documents/PNG/CICP$ pngcheck -c -v tmp.png
File: tmp.png (224 bytes)
  chunk IHDR at offset 0x0000c, length 13
    128 x 64 image, 32-bit RGB+alpha, non-interlaced
  chunk cICP at offset 0x00025, length 4
:   Display P3
    White x = 0.3127 y = 0.329,  Red x = 0.68 y = 0.32
    Green x = 0.265 y = 0.69,  Blue x = 0.15 y = 0.06
    Full range
  chunk IDAT at offset 0x00035, length 151
    zlib: deflated, 32K window, default compression
  chunk IEND at offset 0x000d8, length 0
No errors detected in tmp.png (4 chunks, 99.3% compression).
chris@SuperNomad:/mnt/c/Users/chris/Documents/PNG/CICP$ png_cicp_editor remove tmp.png
File path provided where a value was expected: remove

Guessing those aren't implemented yet?

[ProgramMax]

Correct, not yet.
I just cleaned up the command line processing a bit. This is my next big ticket item.
I wasn't rushing there, though. If you could use it sooner rather than later, I could prioritize it a bit more.

[svgeesus]

I just pulled the current repo and built it. --help now works.

However it crashed when adding a cICP chunk:

chris@SuperNomad:/mnt/c/Users/chris/Documents/PNG$ png_cicp_editor add --preset display-p3 WK-copy.png
Segmentation fault (core dumped)

[ProgramMax]

I ran into that, too. But I made a change and it stopped.
I should have undone the change to keep investigating. I wasn't convinced it was fixed.

I'll investigate & fix.

[ProgramMax]

Moving the segfault bug discussion to #68

[svgeesus]

segfault is fixed. remove gives a Remove not yet implemented message. add and overwrite seem to work correctly.

[ProgramMax]

Closed by #71