removing redundant code

Author: Akhilesh Negi

backend/app/tests/api/routes/documents/test_route_document_upload.py

@@ -8,13 +8,11 @@
 from moto import mock_aws
 from sqlmodel import Session, select
 from fastapi.testclient import TestClient
-from dotenv import find_dotenv
 
 from app.core.cloud import AmazonCloudStorageClient
 from app.core.config import settings
 from app.models import Document
 from app.tests.utils.document import Route, WebCrawler, httpx_to_standard
-from app.tests.utils.utils import load_environment
 
 
 class WebUploader(WebCrawler):
@@ -49,10 +47,6 @@ def uploader(client: TestClient, user_api_key_header: dict[str, str]):
 
 @pytest.fixture(scope="class")
 def aws_credentials():
-    # Load test environment to ensure correct bucket name
-    path = find_dotenv(".env.test")
-    load_environment(path)
-
     # Set AWS credentials for moto mock
     os.environ["AWS_ACCESS_KEY_ID"] = "testing"
     os.environ["AWS_SECRET_ACCESS_KEY"] = "testing"

backend/app/tests/conftest.py

@@ -1,9 +1,11 @@
 import pytest
 import logging
+
 from collections.abc import Generator
 from fastapi.testclient import TestClient
 from sqlmodel import Session
 from sqlalchemy import event
+from dotenv import find_dotenv
 
 from app.api.deps import get_db
 from app.main import app
@@ -23,7 +25,10 @@
 
 @pytest.fixture(scope="session", autouse=True)
 def seed_baseline():
-    load_environment("../.env.test")
+    # Load test environment to ensure correct bucket name
+    path = find_dotenv(".env.test")
+    load_environment(path)
+
     with Session(engine) as session:
         logger.info("Seeding baseline data...")
         seed_database(session)  # deterministic baseline

backend/app/tests/utils/utils.py

@@ -92,7 +92,7 @@ def get_project(session: Session, name: str | None = None) -> Project:
     return project
 
 
-def load_environment(env_test_path: str = "../.env.test"):
+def load_environment(env_test_path: str = "../.env.test") -> None:
     """Loads the test environment variables if the .env.test file exists.
 
     Raises an error if any required PostgreSQL credentials are missing or if the
@@ -128,8 +128,6 @@ def load_environment(env_test_path: str = "../.env.test"):
             f"{env_test_path} not found. Using default environment settings."
         )
 
-    return settings
-
 
 def get_assistant(session: Session, name: str | None = None) -> Assistant:
     """

backend/app/tests_pre_start.py

@@ -4,10 +4,6 @@
 from sqlmodel import Session, select
 from tenacity import after_log, before_log, retry, stop_after_attempt, wait_fixed
 
-from app.tests.utils.utils import load_environment
-
-load_environment("../.env.test")
-
 from app.core.db import engine
 
 logging.basicConfig(level=logging.INFO)