Rename toInteger and fromInteger to be more meaningful

Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>

Author: LKaemmerling

src/Prometheus/Storage/APC.php

@@ -30,7 +30,7 @@ public function updateHistogram(array $data): void
     {
         // Initialize the sum
         $sumKey = $this->histogramBucketValueKey($data, 'sum');
-        $new = apcu_add($sumKey, $this->toInteger(0));
+        $new = apcu_add($sumKey, $this->toBinaryRepresentationAsInteger(0));
 
         // If sum does not exist, assume a new histogram and store the metadata
         if ($new) {
@@ -43,7 +43,7 @@ public function updateHistogram(array $data): void
         while (!$done) {
             $old = apcu_fetch($sumKey);
             if ($old !== false) {
-                $done = apcu_cas($sumKey, $old, $this->toInteger($this->fromInteger($old) + $data['value']));
+                $done = apcu_cas($sumKey, $old, $this->toBinaryRepresentationAsInteger($this->fromBinaryRepresentationAsInteger($old) + $data['value']));
             }
         }
 
@@ -68,10 +68,10 @@ public function updateGauge(array $data): void
     {
         $valueKey = $this->valueKey($data);
         if ($data['command'] === Adapter::COMMAND_SET) {
-            apcu_store($valueKey, $this->toInteger($data['value']));
+            apcu_store($valueKey, $this->toBinaryRepresentationAsInteger($data['value']));
             apcu_store($this->metaKey($data), json_encode($this->metaData($data)));
         } else {
-            $new = apcu_add($valueKey, $this->toInteger(0));
+            $new = apcu_add($valueKey, $this->toBinaryRepresentationAsInteger(0));
             if ($new) {
                 apcu_store($this->metaKey($data), json_encode($this->metaData($data)));
             }
@@ -80,7 +80,7 @@ public function updateGauge(array $data): void
             while (!$done) {
                 $old = apcu_fetch($valueKey);
                 if ($old !== false) {
-                    $done = apcu_cas($valueKey, $old, $this->toInteger($this->fromInteger($old) + $data['value']));
+                    $done = apcu_cas($valueKey, $old, $this->toBinaryRepresentationAsInteger($this->fromBinaryRepresentationAsInteger($old) + $data['value']));
                 }
             }
         }
@@ -103,7 +103,7 @@ public function updateCounter(array $data): void
         while (!$done) {
             $old = apcu_fetch($valueKey);
             if ($old !== false) {
-                $done = apcu_cas($valueKey, $old, $this->toInteger($this->fromInteger($old) + $data['value']));
+                $done = apcu_cas($valueKey, $old, $this->toBinaryRepresentationAsInteger($this->fromBinaryRepresentationAsInteger($old) + $data['value']));
             }
         }
     }
@@ -190,7 +190,7 @@ private function collectCounters(): array
                     'name' => $metaData['name'],
                     'labelNames' => [],
                     'labelValues' => $this->decodeLabelValues($labelValues),
-                    'value' => $this->fromInteger($value['value']),
+                    'value' => $this->fromBinaryRepresentationAsInteger($value['value']),
                 ];
             }
             $this->sortSamples($data['samples']);
@@ -221,7 +221,7 @@ private function collectGauges(): array
                     'name' => $metaData['name'],
                     'labelNames' => [],
                     'labelValues' => $this->decodeLabelValues($labelValues),
-                    'value' => $this->fromInteger($value['value']),
+                    'value' => $this->fromBinaryRepresentationAsInteger($value['value']),
                 ];
             }
 
@@ -298,7 +298,7 @@ private function collectHistograms(): array
                     'name' => $metaData['name'] . '_sum',
                     'labelNames' => [],
                     'labelValues' => $decodedLabelValues,
-                    'value' => $this->fromInteger($histogramBuckets[$labelValues]['sum']),
+                    'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum']),
                 ];
             }
             $histograms[] = new MetricFamilySamples($data);
@@ -310,7 +310,7 @@ private function collectHistograms(): array
      * @param mixed $val
      * @return int
      */
-    private function toInteger($val): int
+    private function toBinaryRepresentationAsInteger($val): int
     {
         return unpack('Q', pack('d', $val))[1];
     }
@@ -319,7 +319,7 @@ private function toInteger($val): int
      * @param mixed $val
      * @return float
      */
-    private function fromInteger($val): float
+    private function fromBinaryRepresentationAsInteger($val): float
     {
         return unpack('d', pack('Q', $val))[1];
     }