Fix PHPStan Errors

Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>

Author: LKaemmerling

src/Prometheus/RenderTextFormat.php

@@ -54,7 +54,7 @@ private function escapeLabelValue(string $v): string
     }
 
     /**
-     * @param string[]  $labelNames
+     * @param string[] $labelNames
      * @param Sample $sample
      *
      * @return string[]
@@ -65,12 +65,8 @@ private function escapeAllLabels(array $labelNames, Sample $sample): array
 
         $labels = array_combine(array_merge($labelNames, $sample->getLabelNames()), $sample->getLabelValues());
 
-        if ($labels === false) {
-            return [];
-        }
-
         foreach ($labels as $labelName => $labelValue) {
-            $escapedLabels[] = $labelName . '="' . $this->escapeLabelValue((string) $labelValue) . '"';
+            $escapedLabels[] = $labelName . '="' . $this->escapeLabelValue((string)$labelValue) . '"';
         }
 
         return $escapedLabels;

tests/Test/Prometheus/AbstractCounterTest.php

@@ -205,7 +205,6 @@ public function isShouldAcceptAnySequenceOfBasicLatinCharactersForLabelValues($v
                 array_merge($metric->getLabelNames(), $sample->getLabelNames()),
                 $sample->getLabelValues()
             );
-            self::assertIsArray($labels);
             self::assertEquals($value, $labels[$label]);
         }
     }

tests/Test/Prometheus/AbstractGaugeTest.php

@@ -339,7 +339,6 @@ public function isShouldAcceptAnySequenceOfBasicLatinCharactersForLabelValues($v
                 array_merge($metric->getLabelNames(), $sample->getLabelNames()),
                 $sample->getLabelValues()
             );
-            self::assertIsArray($labels);
             self::assertEquals($value, $labels[$label]);
         }
     }

tests/Test/Prometheus/AbstractHistogramTest.php

@@ -490,7 +490,6 @@ public function isShouldAcceptAnySequenceOfBasicLatinCharactersForLabelValues($v
                 array_merge($metric->getLabelNames(), $sample->getLabelNames()),
                 $sample->getLabelValues()
             );
-            self::assertIsArray($labels);
             self::assertEquals($value, $labels[$label]);
         }
     }

tests/Test/Prometheus/AbstractSummaryTest.php

@@ -586,7 +586,6 @@ public function isShouldAcceptAnySequenceOfBasicLatinCharactersForLabelValues($v
                 array_merge($metric->getLabelNames(), $sample->getLabelNames()),
                 $sample->getLabelValues()
             );
-            self::assertIsArray($labels);
             self::assertEquals($value, $labels[$label]);
         }
     }

tests/Test/Prometheus/Storage/RedisTest.php

@@ -46,8 +46,8 @@ public function itShouldThrowExceptionWhenInjectedRedisIsNotConnected(): void
     {
         $connection = new \Redis();
 
-        $this->expectException(StorageException::class);
-        $this->expectExceptionMessage('Connection to Redis server not established');
+        self::expectException(StorageException::class);
+        self::expectExceptionMessage('Connection to Redis server not established');
 
         Redis::fromExistingConnection($connection);
     }
@@ -92,22 +92,22 @@ public function itShouldOnlyConnectOnceOnSubsequentCalls(): void
 
         $redis->collect();
 
-        $this->assertStringContainsString(
+        self::assertStringContainsString(
             $expectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
-        $this->assertStringNotContainsString(
+        self::assertStringNotContainsString(
             $notExpectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
 
         $redis->collect();
 
-        $this->assertStringContainsString(
+        self::assertStringContainsString(
             $expectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
-        $this->assertStringNotContainsString(
+        self::assertStringNotContainsString(
             $notExpectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
@@ -126,22 +126,22 @@ public function itShouldOnlyConnectOnceForInjectedRedisConnectionOnSubsequentCal
 
         $redis->collect();
 
-        $this->assertStringContainsString(
+        self::assertStringContainsString(
             $expectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
-        $this->assertStringNotContainsString(
+        self::assertStringNotContainsString(
             $notExpectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
 
         $redis->collect();
 
-        $this->assertStringContainsString(
+        self::assertStringContainsString(
             $expectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );
-        $this->assertStringNotContainsString(
+        self::assertStringNotContainsString(
             $notExpectedClientId,
             $this->redisConnection->rawCommand('client', 'list')
         );