Skip to content

Commit 01611b5

Browse files
committed
update
1 parent 4348bcb commit 01611b5

File tree

10 files changed

+54
-1711
lines changed

10 files changed

+54
-1711
lines changed

bin/puremvc-2.0.0.cjs.js

Lines changed: 0 additions & 1642 deletions
This file was deleted.

bin/puremvc-2.0.0.cjs.min.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

bin/puremvc-2.0.0.js

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,10 @@ class Observer {
116116
* <UL>
117117
* <LI>Maintain a cache of `Mediator` instances.</LI>
118118
* <LI>Provide methods for registering, retrieving, and removing `Mediators`.</LI>
119-
* <LI>Notifiying `Mediators` when they are registered or removed.</LI>
119+
* <LI>Notifying `Mediators` when they are registered or removed.</LI>
120120
* <LI>Managing the observer lists for each `Notification` in the application.</LI>
121-
* <LI>Providing a method for attaching `Observers` to an `Notification`'s observer list.</LI>
122-
* <LI>Providing a method for broadcasting an `Notification`.</LI>
121+
* <LI>Providing a method for attaching `Observers` to a `Notification`'s observer list.</LI>
122+
* <LI>Providing a method for broadcasting a `Notification`.</LI>
123123
* <LI>Notifying the `Observers` of a given `Notification` when it broadcast.</LI>
124124
* </UL>
125125
*
@@ -254,7 +254,7 @@ class View {
254254
}
255255

256256
/**
257-
* Register an `Mediator` instance with the `View`.
257+
* Register a `Mediator` instance with the `View`.
258258
*
259259
* <P>Registers the `Mediator` so that it can be retrieved by name,
260260
* and further interrogates the `Mediator` for its
@@ -296,7 +296,7 @@ class View {
296296
}
297297

298298
/**
299-
* Retrieve an `Mediator` from the `View`.
299+
* Retrieve a `Mediator` from the `View`.
300300
*
301301
* @param {string} mediatorName the name of the `Mediator` instance to retrieve.
302302
* @returns {Mediator} the `Mediator` instance previously registered with the given `mediatorName`.
@@ -306,7 +306,7 @@ class View {
306306
}
307307

308308
/**
309-
* Remove an `Mediator` from the `View`.
309+
* Remove a `Mediator` from the `View`.
310310
*
311311
* @param {string} mediatorName name of the `Mediator` instance to be removed.
312312
* @returns {Mediator} the `Mediator` that was removed from the `View`
@@ -345,7 +345,7 @@ class View {
345345
}
346346

347347
/**
348-
* Remove an View instance
348+
* Remove a View instance
349349
*
350350
* @static
351351
* @param key multitonKey of View instance to remove
@@ -385,7 +385,7 @@ class View {
385385
* are intended to handle which `Notifications`.</LI>
386386
* <LI> Registering itself as an `Observer` with
387387
* the `View` for each `Notification`
388-
* that it has an `Command` mapping for.</LI>
388+
* that it has a `Command` mapping for.</LI>
389389
* <LI> Creating a new instance of the proper `Command`
390390
* to handle a given `Notification` when notified by the `View`.</LI>
391391
* <LI> Calling the `Command`'s `execute`
@@ -478,10 +478,10 @@ class Controller {
478478
}
479479

480480
/**
481-
* <P>If an `Command` has previously been registered
481+
* <P>If a `Command` has previously been registered
482482
* to handle the given `Notification`, then it is executed.</P>
483483
*
484-
* @param {Notification} notification an `Notification`
484+
* @param {Notification} notification a `Notification`
485485
*/
486486
executeCommand(notification) {
487487
let factory = this.commandMap.get(notification.name);
@@ -501,7 +501,7 @@ class Controller {
501501
* used, the new `Command` is used instead.</P>
502502
*
503503
* <P>The Observer for the new Command is only created if this the
504-
* first time an Command has been regisered for this Notification name.</P>
504+
* first time a Command has been registered for this Notification name.</P>
505505
*
506506
* @param notificationName the name of the `Notification`
507507
* @param {function():SimpleCommand} factory
@@ -540,7 +540,7 @@ class Controller {
540540
}
541541

542542
/**
543-
* Remove an Controller instance
543+
* Remove a Controller instance
544544
*
545545
* @static
546546
* @param {string} key of Controller instance to remove
@@ -649,9 +649,9 @@ class Model {
649649
}
650650

651651
/**
652-
* Register an `Proxy` with the `Model`.
652+
* Register a `Proxy` with the `Model`.
653653
*
654-
* @param {Proxy} proxy an `Proxy` to be held by the `Model`.
654+
* @param {Proxy} proxy a `Proxy` to be held by the `Model`.
655655
*/
656656
registerProxy(proxy) {
657657
proxy.initializeNotifier(this.multitonKey);
@@ -660,7 +660,7 @@ class Model {
660660
}
661661

662662
/**
663-
* Retrieve an `Proxy` from the `Model`.
663+
* Retrieve a `Proxy` from the `Model`.
664664
*
665665
* @param {string} proxyName
666666
* @returns {Proxy} the `Proxy` instance previously registered with the given `proxyName`.
@@ -680,7 +680,7 @@ class Model {
680680
}
681681

682682
/**
683-
* Remove an `Proxy` from the `Model`.
683+
* Remove a `Proxy` from the `Model`.
684684
*
685685
* @param {string} proxyName name of the `Proxy` instance to be removed.
686686
* @returns {Proxy} the `Proxy` that was removed from the `Model`
@@ -972,7 +972,7 @@ class Facade {
972972
}
973973

974974
/**
975-
* Register an `Command` with the `Controller` by Notification name.
975+
* Register a `Command` with the `Controller` by Notification name.
976976
*
977977
* @param {string} notificationName the name of the `Notification` to associate the `Command` with
978978
* @param {function():SimpleCommand} factory a reference to the factory of the `Command`
@@ -1001,7 +1001,7 @@ class Facade {
10011001
}
10021002

10031003
/**
1004-
* Register an `Proxy` with the `Model` by name.
1004+
* Register a `Proxy` with the `Model` by name.
10051005
*
10061006
* @param {Proxy} proxy the `Proxy` instance to be registered with the `Model`.
10071007
*/
@@ -1010,7 +1010,7 @@ class Facade {
10101010
}
10111011

10121012
/**
1013-
* Remove an `Proxy` from the `Model` by name.
1013+
* Remove a `Proxy` from the `Model` by name.
10141014
*
10151015
* @param {string} proxyName the `Proxy` to remove from the `Model`.
10161016
* @returns {Proxy} the `Proxy` that was removed from the `Model`
@@ -1030,7 +1030,7 @@ class Facade {
10301030
}
10311031

10321032
/**
1033-
* Retrieve an `Proxy` from the `Model` by name.
1033+
* Retrieve a `Proxy` from the `Model` by name.
10341034
*
10351035
* @param {string} proxyName the name of the proxy to be retrieved.
10361036
* @returns {Proxy} the `Proxy` instance previously registered with the given `proxyName`.
@@ -1049,7 +1049,7 @@ class Facade {
10491049
}
10501050

10511051
/**
1052-
* Remove an `Mediator` from the `View`.
1052+
* Remove a `Mediator` from the `View`.
10531053
*
10541054
* @param {string} mediatorName name of the `Mediator` to be removed.
10551055
* @returns {Mediator} the `Mediator` that was removed from the `View`
@@ -1062,14 +1062,14 @@ class Facade {
10621062
* Check if a Mediator is registered or not
10631063
*
10641064
* @param {string} mediatorName
1065-
* @returns {Mediator} whether a Mediator is registered with the given `mediatorName`.
1065+
* @returns {boolean} whether a Mediator is registered with the given `mediatorName`.
10661066
*/
10671067
hasMediator(mediatorName) {
10681068
return this.view.hasMediator(mediatorName);
10691069
}
10701070

10711071
/**
1072-
* Retrieve an `Mediator` from the `View`.
1072+
* Retrieve a `Mediator` from the `View`.
10731073
*
10741074
* @param {string} mediatorName
10751075
* @returns {Mediator} the `Mediator` previously registered with the given `mediatorName`.
@@ -1084,7 +1084,7 @@ class Facade {
10841084
* <P>Keeps us from having to construct new notification
10851085
* instances in our implementation code.</P>
10861086
*
1087-
* @param {string} notificationName the name of the notiification to send
1087+
* @param {string} notificationName the name of the notification to send
10881088
* @param {Object} [body] body the body of the notification (optional)
10891089
* @param {string} [type] type the type of the notification (optional)
10901090
*/
@@ -1177,7 +1177,7 @@ class Facade {
11771177
* `sendNotification` that relieves implementation code of
11781178
* the necessity to actually construct `Notifications`.</P>
11791179
*
1180-
* <P>The `Notifier` class, which all of the above mentioned classes
1180+
* <P>The `Notifier` class, which all the above-mentioned classes
11811181
* extend, provides an initialized reference to the `Facade`
11821182
* Multiton, which is required for the convenience method
11831183
* for sending `Notifications`, but also eases implementation as these
@@ -1294,7 +1294,7 @@ class SimpleCommand extends Notifier {
12941294
* Fulfill the use-case initiated by the given `Notification`.
12951295
*
12961296
* <P>In the Command Pattern, an application use-case typically
1297-
* begins with some user action, which results in an `Notification` being broadcast, which
1297+
* begins with some user action, which results in a `Notification` being broadcast, which
12981298
* is handled by business logic in the `execute` method of an
12991299
* `Command`.</P>
13001300
*

build/rollup.conf.mjs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,8 @@ export default [
1111
{
1212
file: "bin/puremvc-2.0.0.min.js",
1313
format: "esm",
14-
plugins: [terser()],
14+
plugins: [terser()]
1515
},
1616
],
17-
},
18-
{
19-
input: "index.js",
20-
output: [
21-
{
22-
file: "bin/puremvc-2.0.0.cjs.js",
23-
format: "cjs",
24-
},
25-
{
26-
file: "bin/puremvc-2.0.0.cjs.min.js",
27-
format: "cjs",
28-
plugins: [terser()],
29-
},
30-
],
31-
},
17+
}
3218
];

src/core/Controller.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {Observer} from "../patterns/observer/Observer.js";
2121
* are intended to handle which `Notifications`.</LI>
2222
* <LI> Registering itself as an `Observer` with
2323
* the `View` for each `Notification`
24-
* that it has an `Command` mapping for.</LI>
24+
* that it has a `Command` mapping for.</LI>
2525
* <LI> Creating a new instance of the proper `Command`
2626
* to handle a given `Notification` when notified by the `View`.</LI>
2727
* <LI> Calling the `Command`'s `execute`
@@ -114,10 +114,10 @@ class Controller {
114114
}
115115

116116
/**
117-
* <P>If an `Command` has previously been registered
117+
* <P>If a `Command` has previously been registered
118118
* to handle the given `Notification`, then it is executed.</P>
119119
*
120-
* @param {Notification} notification an `Notification`
120+
* @param {Notification} notification a `Notification`
121121
*/
122122
executeCommand(notification) {
123123
let factory = this.commandMap.get(notification.name);
@@ -137,7 +137,7 @@ class Controller {
137137
* used, the new `Command` is used instead.</P>
138138
*
139139
* <P>The Observer for the new Command is only created if this the
140-
* first time an Command has been regisered for this Notification name.</P>
140+
* first time a Command has been registered for this Notification name.</P>
141141
*
142142
* @param notificationName the name of the `Notification`
143143
* @param {function():SimpleCommand} factory
@@ -176,7 +176,7 @@ class Controller {
176176
}
177177

178178
/**
179-
* Remove an Controller instance
179+
* Remove a Controller instance
180180
*
181181
* @static
182182
* @param {string} key of Controller instance to remove

src/core/Model.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ class Model {
8989
}
9090

9191
/**
92-
* Register an `Proxy` with the `Model`.
92+
* Register a `Proxy` with the `Model`.
9393
*
94-
* @param {Proxy} proxy an `Proxy` to be held by the `Model`.
94+
* @param {Proxy} proxy a `Proxy` to be held by the `Model`.
9595
*/
9696
registerProxy(proxy) {
9797
proxy.initializeNotifier(this.multitonKey);
@@ -100,7 +100,7 @@ class Model {
100100
}
101101

102102
/**
103-
* Retrieve an `Proxy` from the `Model`.
103+
* Retrieve a `Proxy` from the `Model`.
104104
*
105105
* @param {string} proxyName
106106
* @returns {Proxy} the `Proxy` instance previously registered with the given `proxyName`.
@@ -120,7 +120,7 @@ class Model {
120120
}
121121

122122
/**
123-
* Remove an `Proxy` from the `Model`.
123+
* Remove a `Proxy` from the `Model`.
124124
*
125125
* @param {string} proxyName name of the `Proxy` instance to be removed.
126126
* @returns {Proxy} the `Proxy` that was removed from the `Model`

0 commit comments

Comments
 (0)