impel array_controllers

Author: chrroberts-pure

internal/openmetrics-exporter/arrays_controllers_collector.go

@@ -0,0 +1,44 @@
+package collectors
+
+import (
+	client "purestorage/fa-openmetrics-exporter/internal/rest-client"
+
+	"github.com/prometheus/client_golang/prometheus"
+)
+
+type ControllersCollector struct {
+	ControllersDesc *prometheus.Desc
+	Client          *client.FAClient
+}
+
+func (c *ControllersCollector) Describe(ch chan<- *prometheus.Desc) {
+	prometheus.DescribeByCollect(c, ch)
+}
+
+func (c *ControllersCollector) Collect(ch chan<- prometheus.Metric) {
+	cl := c.Client.GetControllers()
+	if len(cl.Items) == 0 {
+		return
+	}
+	for _, d := range cl.Items {
+		ch <- prometheus.MustNewConstMetric(
+			c.ControllersDesc,
+			prometheus.GaugeValue,
+			// OpenMetrics timestamps MUST be in seconds, divide as an float64 to keep precision
+			(float64(d.ModeSince) / 1000),
+			d.Mode, d.Model, d.Name, d.Status, d.Type, d.Version,
+		)
+	}
+}
+
+func NewControllersCollector(fa *client.FAClient) *ControllersCollector {
+	return &ControllersCollector{
+		ControllersDesc: prometheus.NewDesc(
+			"purefa_hw_controller_mode_since_timestamp_seconds",
+			"FlashArray controller mode since",
+			[]string{"mode", "model", "name", "status", "type", "version"},
+			prometheus.Labels{},
+		),
+		Client: fa,
+	}
+}

internal/openmetrics-exporter/arrays_controllers_collector_test.go

@@ -0,0 +1,46 @@
+package collectors
+
+import (
+	"encoding/json"
+	"fmt"
+	"net/http"
+	"net/http/httptest"
+	"os"
+	"regexp"
+	"strings"
+	"testing"
+
+	client "purestorage/fa-openmetrics-exporter/internal/rest-client"
+)
+
+func TestArrayControllersCollector(t *testing.T) {
+
+	rdr, _ := os.ReadFile("../../test/data/controllers.json")
+	vers, _ := os.ReadFile("../../test/data/versions.json")
+	var contl client.ControllersList
+	json.Unmarshal(rdr, &contl)
+	server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		url := regexp.MustCompile(`^/api/([0-9]+.[0-9]+)?/controllers$`)
+		if r.URL.Path == "/api/api_version" {
+			w.Header().Set("Content-Type", "application/json")
+			w.WriteHeader(http.StatusOK)
+			w.Write([]byte(vers))
+		} else if url.MatchString(r.URL.Path) {
+			w.Header().Set("x-auth-token", "faketoken")
+			w.Header().Set("Content-Type", "application/json")
+			w.WriteHeader(http.StatusOK)
+			w.Write([]byte(rdr))
+		}
+	}))
+	endp := strings.Split(server.URL, "/")
+	e := endp[len(endp)-1]
+	want := make(map[string]bool)
+	for _, ctl := range contl.Items {
+		want[fmt.Sprintf("label:{name:\"mode\" value:\"%s\"} label:{name:\"model\"value:\"%s\"} label:{name:\"name\" value:\"%s\"} label:{name:\"status\" value:\"%s\"} label:{name:\"type\" value:\"%s\"} label:{name:\"version\" value:\"%s\"} gauge:{value:\"%g\"}", ctl.Mode, ctl.Model, ctl.Name, ctl.Status, ctl.Type, ctl.Version, (float64(ctl.ModeSince)/1000))] = true
+	}
+
+	c := client.NewRestClient(e, "fake-api-token", "latest", "test-user-agent-string", false)
+	dc := NewControllersCollector(c)
+	metricsCheck(t, dc, want)
+	server.Close()
+}

internal/openmetrics-exporter/collector.go

@@ -5,27 +5,29 @@ import (
 	client "purestorage/fa-openmetrics-exporter/internal/rest-client"
 
 	"github.com/prometheus/client_golang/prometheus"
-	"github.com/prometheus/client_golang/prometheus/collectors"
+	//"github.com/prometheus/client_golang/prometheus/collectors"
 )
 
 func Collector(ctx context.Context, metrics string, registry *prometheus.Registry, faclient *client.FAClient) bool {
 
 	arrayscoll := NewArraysCollector(faclient)
 	registry.MustRegister(
-		collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),
-		collectors.NewGoCollector(),
+		//collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),
+		//collectors.NewGoCollector(),
 		arrayscoll,
 	)
 	if metrics == "all" || metrics == "array" {
 		alertscoll := NewAlertsCollector(faclient)
 		arrayperfcoll := NewArraysPerformanceCollector(faclient)
 		arrayspacecoll := NewArraySpaceCollector(faclient)
 		hwcoll := NewHardwareCollector(faclient)
+		controllercol := NewControllersCollector(faclient)
 		drcoll := NewDriveCollector(faclient)
 		nicsperfcoll := NewNetworkInterfacesPerformanceCollector(faclient)
 		portscoll := NewPortsCollector(faclient)
 		interfacecoll := NewNetworkInterfacesCollector(faclient)
 		registry.MustRegister(
+			controllercol,
 			alertscoll,
 			arrayperfcoll,
 			arrayspacecoll,