Skip to content

Commit 21cbd28

Browse files
Jammy2211Jammy2211
authored andcommitted
fix unit tests reffering to Kernel2D
1 parent 30e20e0 commit 21cbd28

5 files changed

Lines changed: 20 additions & 14 deletions

File tree

autoarray/dataset/imaging/dataset.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ def __init__(
9898
over_sample_size_pixelization=over_sample_size_pixelization,
9999
)
100100

101-
self.use_normalized_psf = use_normalized_psf
102-
103101
if self.noise_map.native is not None and check_noise_map:
104102
if ((self.noise_map.native <= 0.0) * np.invert(self.noise_map.mask)).any():
105103
zero_entries = np.argwhere(self.noise_map.native <= 0.0)
@@ -121,7 +119,7 @@ def __init__(
121119

122120
state = ConvolverState(kernel=psf.kernel, mask=self.data.mask)
123121

124-
self.psf = Convolver(kernel=psf.kernel, state=state)
122+
self.psf = Convolver(kernel=psf.kernel, state=state, normalize=use_normalized_psf)
125123

126124
self.grids = GridsDataset(
127125
mask=self.data.mask,

test_autoarray/dataset/imaging/test_dataset.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def test__apply_mask(imaging_7x7, mask_2d_7x7, psf_3x3):
191191
(1.0 / 3.0) * psf_3x3.slim.array, 1.0e-4
192192
)
193193

194-
assert type(masked_imaging_7x7.psf) == aa.Kernel2D
194+
assert type(masked_imaging_7x7.psf) == aa.Convolver
195195

196196

197197
def test__apply_noise_scaling(imaging_7x7, mask_2d_7x7):
@@ -260,7 +260,9 @@ def test__apply_mask__noise_covariance_matrix():
260260

261261

262262
def test__different_imaging_without_mock_objects__customize_constructor_inputs():
263-
psf = aa.Kernel2D.ones(shape_native=(7, 7), pixel_scales=3.0)
263+
264+
kernel = aa.Array2D.ones(shape_native=(7, 7), pixel_scales=3.0)
265+
psf = aa.Convolver(kernel=kernel)
264266

265267
dataset = aa.Imaging(
266268
data=aa.Array2D.ones(shape_native=(19, 19), pixel_scales=3.0),
@@ -304,7 +306,8 @@ def test__psf_not_odd_x_odd_kernel__raises_error():
304306
with pytest.raises(exc.KernelException):
305307
image = aa.Array2D.ones(shape_native=(3, 3), pixel_scales=1.0)
306308
noise_map = aa.Array2D.ones(shape_native=(3, 3), pixel_scales=1.0)
307-
psf = aa.Kernel2D.no_mask(values=[[0.0, 1.0], [1.0, 2.0]], pixel_scales=1.0)
309+
kernel = aa.Array2D.no_mask(values=[[0.0, 1.0], [1.0, 2.0]], pixel_scales=1.0)
310+
psf = aa.Convolver(kernel=kernel)
308311

309312
dataset = aa.Imaging(
310313
data=image, noise_map=noise_map, psf=psf, disable_fft_pad=True

test_autoarray/dataset/imaging/test_simulator.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,11 @@ def test__via_image_from__psf_off__background_sky_on(image_central_delta_3x3):
9494
def test__via_image_from__psf_on__psf_blurs_image_with_edge_trimming(
9595
image_central_delta_3x3,
9696
):
97-
psf = aa.Kernel2D.no_mask(
97+
kernel = aa.Array2D.no_mask(
9898
values=np.array([[0.0, 1.0, 0.0], [1.0, 2.0, 1.0], [0.0, 1.0, 0.0]]),
9999
pixel_scales=1.0,
100100
)
101+
psf = aa.Convolver(kernel=kernel)
101102

102103
simulator = aa.SimulatorImaging(
103104
exposure_time=1.0,
@@ -118,10 +119,11 @@ def test__via_image_from__psf_on__psf_blurs_image_with_edge_trimming(
118119
def test__via_image_from__psf_on__disable_poisson_noise_in_data(
119120
image_central_delta_3x3,
120121
):
121-
psf = aa.Kernel2D.no_mask(
122+
kernel = aa.Array2D.no_mask(
122123
values=np.array([[0.0, 1.0, 0.0], [1.0, 2.0, 1.0], [0.0, 1.0, 0.0]]),
123124
pixel_scales=1.0,
124125
)
126+
psf = aa.Convolver(kernel=kernel)
125127

126128
simulator = aa.SimulatorImaging(
127129
exposure_time=20.0,
@@ -150,10 +152,11 @@ def test__via_image_from__psf_on__disable_poisson_noise_in_data(
150152
def test__via_image_from__psf_on__psf_and_noise_both_on(image_central_delta_3x3):
151153
image = image_central_delta_3x3 + 1.0
152154

153-
psf = aa.Kernel2D.no_mask(
155+
kernel = aa.Array2D.no_mask(
154156
values=np.array([[0.0, 1.0, 0.0], [1.0, 2.0, 1.0], [0.0, 1.0, 0.0]]),
155157
pixel_scales=1.0,
156158
)
159+
psf = aa.Convolver(kernel=kernel)
157160

158161
simulator = aa.SimulatorImaging(
159162
exposure_time=20.0,

test_autoarray/inversion/inversion/imaging/test_inversion_imaging_util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def test__data_vector_via_weighted_data_two_methods_agree():
192192
noise_map = np.random.uniform(size=mask.shape_native)
193193
noise_map = aa.Array2D(values=noise_map, mask=mask)
194194

195-
kernel = aa.Kernel2D.from_gaussian(
195+
kernel = aa.Convolver.from_gaussian(
196196
shape_native=(7, 7), pixel_scales=mask.pixel_scales, sigma=1.0, normalize=True
197197
)
198198

@@ -265,7 +265,7 @@ def test__curvature_matrix_via_psf_weighted_noise_two_methods_agree():
265265
noise_map = np.random.uniform(size=mask.shape_native)
266266
noise_map = aa.Array2D(values=noise_map, mask=mask)
267267

268-
kernel = aa.Kernel2D.from_gaussian(
268+
kernel = aa.Convolver.from_gaussian(
269269
shape_native=(7, 7), pixel_scales=mask.pixel_scales, sigma=1.0, normalize=True
270270
)
271271

test_autoarray/inversion/inversion/test_abstract.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ def test__curvature_matrix__via_sparse_operator__identical_to_mapping():
119119
image = aa.Array2D.no_mask(values=np.random.random((7, 7)), pixel_scales=1.0)
120120
noise_map = aa.Array2D.no_mask(values=np.random.random((7, 7)), pixel_scales=1.0)
121121
kernel = np.array([[0.0, 1.0, 0.0], [1.0, 1.0, 1.0], [0.0, 1.0, 0.0]])
122-
psf = aa.Kernel2D.no_mask(values=kernel, pixel_scales=1.0)
122+
psf = aa.Array2D.no_mask(values=kernel, pixel_scales=1.0)
123+
psf = aa.Convolver(kernel=kernel)
123124

124125
dataset = aa.Imaging(data=image, noise_map=noise_map, psf=psf)
125126

@@ -187,8 +188,9 @@ def test__curvature_matrix_via_sparse_operator__includes_source_interpolation__i
187188

188189
image = aa.Array2D.no_mask(values=np.random.random((7, 7)), pixel_scales=1.0)
189190
noise_map = aa.Array2D.no_mask(values=np.random.random((7, 7)), pixel_scales=1.0)
190-
kernel = np.array([[0.0, 1.0, 0.0], [1.0, 1.0, 1.0], [0.0, 1.0, 0.0]])
191-
psf = aa.Kernel2D.no_mask(values=kernel, pixel_scales=1.0)
191+
kernel = aa.Array2D.no_mask([[0.0, 1.0, 0.0], [1.0, 1.0, 1.0], [0.0, 1.0, 0.0]], pixel_scales=1.0)
192+
193+
psf = aa.Convolver(kernel=kernel, pixel_scales=1.0)
192194

193195
dataset = aa.Imaging(data=image, noise_map=noise_map, psf=psf)
194196

0 commit comments

Comments
 (0)