Skip to content

Commit 385fb9d

Browse files
committed
Merging complete
1 parent 3835abc commit 385fb9d

10 files changed

Lines changed: 57 additions & 56 deletions

File tree

autoarray/mask/mapping.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def grid_binned_from_sub_grid_1d(self, sub_grid_1d):
284284
grid_1d=np.stack((grid_1d_y, grid_1d_x), axis=-1), mask=self.mask_sub_1
285285
)
286286

287-
def trimmed_array_2d_from_padded_array_and_image_shape(
287+
def trimmed_array_from_padded_array_and_image_shape(
288288
self, padded_array, image_shape
289289
):
290290
""" Map a padded 1D array of values to its original 2D array, trimming all edge values.
@@ -297,10 +297,11 @@ def trimmed_array_2d_from_padded_array_and_image_shape(
297297

298298
pad_size_0 = self.mask.shape[0] - image_shape[0]
299299
pad_size_1 = self.mask.shape[1] - image_shape[1]
300-
return padded_array.in_2d_binned[
300+
trimmed_array = padded_array.in_2d_binned[
301301
pad_size_0 // 2 : self.mask.shape[0] - pad_size_0 // 2,
302302
pad_size_1 // 2 : self.mask.shape[1] - pad_size_1 // 2,
303303
]
304+
return arrays.Array.manual_2d(array=trimmed_array, pixel_scales=self.mask.pixel_scales, sub_size=1, origin=self.mask.origin)
304305

305306
def convolve_padded_array_1d_with_psf(self, padded_array_1d, psf):
306307
"""Convolve a 1d padded array of values (e.g. image before PSF blurring) with a PSF, and then trim \
@@ -329,7 +330,7 @@ def convolve_padded_array_1d_with_psf(self, padded_array_1d, psf):
329330
sub_size=1,
330331
)
331332

332-
def unmasked_blurred_array_2d_from_padded_array_psf_and_image_shape(
333+
def unmasked_blurred_array_from_padded_array_psf_and_image_shape(
333334
self, padded_array, psf, image_shape
334335
):
335336
"""For a padded grid and psf, compute an unmasked blurred image from an unmasked unblurred image.
@@ -347,7 +348,7 @@ def unmasked_blurred_array_2d_from_padded_array_psf_and_image_shape(
347348

348349
blurred_image = psf.convolved_array_from_array(array=padded_array)
349350

350-
return self.trimmed_array_2d_from_padded_array_and_image_shape(
351+
return self.trimmed_array_from_padded_array_and_image_shape(
351352
padded_array=blurred_image, image_shape=image_shape
352353
)
353354

autoarray/mask/mask.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ def elliptical_annular(
373373
)
374374

375375
@classmethod
376-
def from_fits(cls, file_path, hdu, pixel_scales, sub_size, origin=(0.0, 0.0)):
376+
def from_fits(cls, file_path, pixel_scales, hdu=0, sub_size=1, origin=(0.0, 0.0)):
377377
"""
378378
Loads the image from a .fits file.
379379
@@ -383,7 +383,7 @@ def from_fits(cls, file_path, hdu, pixel_scales, sub_size, origin=(0.0, 0.0)):
383383
The full path of the fits file.
384384
hdu : int
385385
The HDU number in the fits file containing the image image.
386-
pixel_scales : (float, float)
386+
pixel_scales : float or (float, float)
387387
The arc-second to pixel conversion factor of each pixel.
388388
"""
389389

autoarray/operators/inversion/inversions.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def errors(self):
119119

120120
@property
121121
def residual_map(self):
122-
return inversion_util.pixelization_residual_map_from_pixelization_values_and_reconstructed_data_1d(
122+
return inversion_util.inversion_residual_map_from_pixelization_values_and_reconstructed_data_1d(
123123
pixelization_values=self.reconstruction,
124124
reconstructed_data_1d=self.mapped_reconstructed_image,
125125
mask_1d_index_for_sub_mask_1d_index=self.mapper.grid.mask.regions._mask_1d_index_for_sub_mask_1d_index,
@@ -128,7 +128,7 @@ def residual_map(self):
128128

129129
@property
130130
def normalized_residual_map(self):
131-
return inversion_util.pixelization_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
131+
return inversion_util.inversion_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
132132
pixelization_values=self.reconstruction,
133133
reconstructed_data_1d=self.mapped_reconstructed_image,
134134
noise_map_1d=self.noise_map,
@@ -138,7 +138,7 @@ def normalized_residual_map(self):
138138

139139
@property
140140
def chi_squared_map(self):
141-
return inversion_util.pixelization_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
141+
return inversion_util.inversion_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
142142
pixelization_values=self.reconstruction,
143143
reconstructed_data_1d=self.mapped_reconstructed_image,
144144
noise_map_1d=self.noise_map,

autoarray/plotters/inversion_plotters.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ def residual_map(
437437
xyticksize=16,
438438
output_path=None,
439439
output_format="show",
440-
output_filename="inversion_pixelization_residual_map",
440+
output_filename="inversion_inversion_residual_map",
441441
):
442442

443443
if output_format is "fits":
@@ -516,7 +516,7 @@ def normalized_residual_map(
516516
xyticksize=16,
517517
output_path=None,
518518
output_format="show",
519-
output_filename="inversion_pixelization_normalized_residual_map",
519+
output_filename="inversion_inversion_normalized_residual_map",
520520
):
521521

522522
if output_format is "fits":
@@ -595,7 +595,7 @@ def chi_squared_map(
595595
xyticksize=16,
596596
output_path=None,
597597
output_format="show",
598-
output_filename="inversion_pixelization_chi_squared_map",
598+
output_filename="inversion_inversion_chi_squared_map",
599599
):
600600

601601
if output_format is "fits":
@@ -674,7 +674,7 @@ def regularization_weights(
674674
xyticksize=16,
675675
output_path=None,
676676
output_format="show",
677-
output_filename="inversion_pixelization_regularization_weights",
677+
output_filename="inversion_inversion_regularization_weights",
678678
):
679679

680680
if output_format is "fits":

autoarray/plotters/plotter_util.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
matplotlib.use(backend)
66
import matplotlib.pyplot as plt
77
import numpy as np
8+
from autoarray import exc
9+
from autoarray.util import array_util
810

911

1012
def get_subplot_rows_columns_figsize(number_subplots):
@@ -120,7 +122,7 @@ def output_figure(array, as_subplot, output_path, output_filename, output_format
120122
elif output_format is "png":
121123
plt.savefig(output_path + output_filename + ".png", bbox_inches="tight")
122124
elif output_format is "fits":
123-
aa.util.array.numpy_array_2d_to_fits(
125+
array_util.numpy_array_2d_to_fits(
124126
array_2d=array,
125127
file_path=output_path + output_filename + ".fits",
126128
overwrite=True,

autoarray/structures/arrays.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def zeros(cls, shape_2d, pixel_scales=None, sub_size=1, origin=(0.0, 0.0)):
311311

312312
@classmethod
313313
def from_fits(
314-
cls, file_path, hdu, pixel_scales=None, sub_size=1, origin=(0.0, 0.0)
314+
cls, file_path, hdu=0, pixel_scales=None, sub_size=1, origin=(0.0, 0.0)
315315
):
316316
array_2d = array_util.numpy_array_2d_from_fits(file_path=file_path, hdu=hdu)
317317
return cls.manual_2d(

autoarray/util/inversion_util.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def reconstructed_data_vector_from_blurred_mapping_matrix_and_solution_vector(
122122
return reconstructed_data_vector
123123

124124

125-
def pixelization_residual_map_from_pixelization_values_and_reconstructed_data_1d(
125+
def inversion_residual_map_from_pixelization_values_and_reconstructed_data_1d(
126126
pixelization_values,
127127
reconstructed_data_1d,
128128
mask_1d_index_for_sub_mask_1d_index,
@@ -149,7 +149,7 @@ def pixelization_residual_map_from_pixelization_values_and_reconstructed_data_1d
149149
return pixelization_residuals
150150

151151

152-
def pixelization_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
152+
def inversion_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
153153
pixelization_values,
154154
reconstructed_data_1d,
155155
noise_map_1d,
@@ -179,7 +179,7 @@ def pixelization_normalized_residual_map_from_pixelization_values_and_reconstruc
179179
return pixelization_normalized_residuals
180180

181181

182-
def pixelization_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
182+
def inversion_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
183183
pixelization_values,
184184
reconstructed_data_1d,
185185
noise_map_1d,

test_autoarray/unit/mask/test_mapping.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -559,11 +559,11 @@ def test__trimmed_array_2d_from_padded_array_1d_and_image_shape(self):
559559
mask=mask,
560560
)
561561

562-
array_2d = mask.mapping.trimmed_array_2d_from_padded_array_and_image_shape(
562+
array = mask.mapping.trimmed_array_from_padded_array_and_image_shape(
563563
padded_array=array_1d, image_shape=(2, 2)
564564
)
565565

566-
assert (array_2d == np.array([[6.0, 7.0], [1.0, 2.0]])).all()
566+
assert (array.in_2d == np.array([[6.0, 7.0], [1.0, 2.0]])).all()
567567

568568
mask = aa.mask.unmasked(shape_2d=(5, 3))
569569

@@ -572,11 +572,11 @@ def test__trimmed_array_2d_from_padded_array_1d_and_image_shape(self):
572572
mask=mask,
573573
)
574574

575-
array_2d = mask.mapping.trimmed_array_2d_from_padded_array_and_image_shape(
575+
array = mask.mapping.trimmed_array_from_padded_array_and_image_shape(
576576
padded_array=array_1d, image_shape=(3, 1)
577577
)
578578

579-
assert (array_2d == np.array([[5.0], [8.0], [2.0]])).all()
579+
assert (array.in_2d == np.array([[5.0], [8.0], [2.0]])).all()
580580

581581
mask = aa.mask.unmasked(shape_2d=(3, 5))
582582

@@ -585,11 +585,11 @@ def test__trimmed_array_2d_from_padded_array_1d_and_image_shape(self):
585585
mask=mask,
586586
)
587587

588-
array_2d = mask.mapping.trimmed_array_2d_from_padded_array_and_image_shape(
588+
array = mask.mapping.trimmed_array_from_padded_array_and_image_shape(
589589
padded_array=array_1d, image_shape=(1, 3)
590590
)
591591

592-
assert (array_2d == np.array([[7.0, 8.0, 9.0]])).all()
592+
assert (array.in_2d == np.array([[7.0, 8.0, 9.0]])).all()
593593

594594

595595
class TestMappingExceptions:

test_autoarray/unit/test_files/config/visualize.ini

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
[figures]
22
plot_mask_on_images = True
3-
extract_images_from_mask = True
4-
zoom_around_mask_of_images = True
53
plot_positions_on_images = True
64
plot_image_plane_adaptive_pixelization_grid = True
75
plot_units = arcsec
@@ -27,27 +25,27 @@ plot_ray_tracing_potential = False
2725
plot_ray_tracing_deflections = False
2826
plot_ray_tracing_magnification = False
2927

30-
plot_lens_fit_all_at_end_png = True
31-
plot_lens_fit_all_at_end_fits = True
32-
plot_lens_fit_as_subplot = True
33-
plot_lens_fit_of_planes_as_subplot=True
34-
plot_lens_fit_inversion_as_subplot = True
35-
plot_lens_fit_image = False
36-
plot_lens_fit_noise_map = False
37-
plot_lens_fit_signal_to_noise_map = False
38-
plot_lens_fit_lens_subtracted_image = False
39-
plot_lens_fit_model_image = False
40-
plot_lens_fit_residual_map = False
41-
plot_lens_fit_normalized_residual_map = False
42-
plot_lens_fit_chi_squared_map = False
43-
plot_lens_fit_contribution_maps = False
44-
plot_lens_fit_pixelization_residual_map = False
45-
plot_lens_fit_pixelization_normalized_residual_map = False
46-
plot_lens_fit_pixelization_chi_squared_map = False
47-
plot_lens_fit_pixelization_regularization_weight_map = False
48-
plot_lens_fit_subtracted_images_of_planes = False
49-
plot_lens_fit_model_images_of_planes = False
50-
plot_lens_fit_plane_images_of_planes = False
28+
plot_fit_all_at_end_png = True
29+
plot_fit_all_at_end_fits = True
30+
plot_fit_as_subplot = True
31+
plot_fit_of_planes_as_subplot=True
32+
plot_fit_inversion_as_subplot = True
33+
plot_fit_image = False
34+
plot_fit_noise_map = False
35+
plot_fit_signal_to_noise_map = False
36+
plot_fit_lens_subtracted_image = False
37+
plot_fit_model_image = False
38+
plot_fit_residual_map = False
39+
plot_fit_normalized_residual_map = False
40+
plot_fit_chi_squared_map = False
41+
plot_fit_contribution_maps = False
42+
plot_fit_inversion_residual_map = False
43+
plot_fit_inversion_normalized_residual_map = False
44+
plot_fit_inversion_chi_squared_map = False
45+
plot_fit_inversion_regularization_weight_map = False
46+
plot_fit_subtracted_images_of_planes = False
47+
plot_fit_model_images_of_planes = False
48+
plot_fit_plane_images_of_planes = False
5149

5250
plot_hyper_galaxy_subplot = False
5351
plot_hyper_model_image = False

test_autoarray/unit/util/test_inversion_util.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def test__pixelization_perfectly_reconstructed_data__quantities_like_residuals_a
144144
[2, 2, 2],
145145
]
146146

147-
pixelization_residuals = aa.util.inversion.pixelization_residual_map_from_pixelization_values_and_reconstructed_data_1d(
147+
pixelization_residuals = aa.util.inversion.inversion_residual_map_from_pixelization_values_and_reconstructed_data_1d(
148148
pixelization_values=pixelization_values,
149149
reconstructed_data_1d=reconstructed_data_1d,
150150
mask_1d_index_for_sub_mask_1d_index=mask_1d_index_for_sub_mask_1d_index,
@@ -164,7 +164,7 @@ def test__pixelization_not_perfect_fit__quantities_like_residuals_non_zero(self)
164164
[6, 7, 8],
165165
]
166166

167-
pixelization_residuals = aa.util.inversion.pixelization_residual_map_from_pixelization_values_and_reconstructed_data_1d(
167+
pixelization_residuals = aa.util.inversion.inversion_residual_map_from_pixelization_values_and_reconstructed_data_1d(
168168
pixelization_values=pixelization_values,
169169
reconstructed_data_1d=reconstructed_data_1d,
170170
mask_1d_index_for_sub_mask_1d_index=mask_1d_index_for_sub_mask_1d_index,
@@ -182,7 +182,7 @@ def test__pixelization_not_perfect_fit__quantities_like_residuals_non_zero(self)
182182
[6, 7, 8],
183183
]
184184

185-
pixelization_residuals = aa.util.inversion.pixelization_residual_map_from_pixelization_values_and_reconstructed_data_1d(
185+
pixelization_residuals = aa.util.inversion.inversion_residual_map_from_pixelization_values_and_reconstructed_data_1d(
186186
pixelization_values=pixelization_values,
187187
reconstructed_data_1d=reconstructed_data_1d,
188188
mask_1d_index_for_sub_mask_1d_index=mask_1d_index_for_sub_mask_1d_index,
@@ -207,7 +207,7 @@ def test__pixelization_perfectly_reconstructed_data__quantities_like_residuals_a
207207
[2, 2, 2],
208208
]
209209

210-
pixelization_normalized_residuals = aa.util.inversion.pixelization_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
210+
pixelization_normalized_residuals = aa.util.inversion.inversion_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
211211
pixelization_values=pixelization_values,
212212
reconstructed_data_1d=reconstructed_data_1d,
213213
noise_map_1d=noise_map_1d,
@@ -229,7 +229,7 @@ def test__pixelization_not_perfect_fit__quantities_like_residuals_non_zero(self)
229229
[6, 7, 8],
230230
]
231231

232-
pixelization_normalized_residuals = aa.util.inversion.pixelization_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
232+
pixelization_normalized_residuals = aa.util.inversion.inversion_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
233233
pixelization_values=pixelization_values,
234234
reconstructed_data_1d=reconstructed_data_1d,
235235
noise_map_1d=noise_map_1d,
@@ -249,7 +249,7 @@ def test__pixelization_not_perfect_fit__quantities_like_residuals_non_zero(self)
249249
[6, 7, 8],
250250
]
251251

252-
pixelization_normalized_residuals = aa.util.inversion.pixelization_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
252+
pixelization_normalized_residuals = aa.util.inversion.inversion_normalized_residual_map_from_pixelization_values_and_reconstructed_data_1d(
253253
pixelization_values=pixelization_values,
254254
reconstructed_data_1d=reconstructed_data_1d,
255255
noise_map_1d=noise_map_1d,
@@ -275,7 +275,7 @@ def test__pixelization_perfectly_reconstructed_data__quantities_like_residuals_a
275275
[2, 2, 2],
276276
]
277277

278-
pixelization_chi_squareds = aa.util.inversion.pixelization_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
278+
pixelization_chi_squareds = aa.util.inversion.inversion_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
279279
pixelization_values=pixelization_values,
280280
reconstructed_data_1d=reconstructed_data_1d,
281281
noise_map_1d=noise_map_1d,
@@ -297,7 +297,7 @@ def test__pixelization_not_perfect_fit__quantities_like_residuals_non_zero(self)
297297
[6, 7, 8],
298298
]
299299

300-
pixelization_chi_squareds = aa.util.inversion.pixelization_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
300+
pixelization_chi_squareds = aa.util.inversion.inversion_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
301301
pixelization_values=pixelization_values,
302302
reconstructed_data_1d=reconstructed_data_1d,
303303
noise_map_1d=noise_map_1d,
@@ -317,7 +317,7 @@ def test__pixelization_not_perfect_fit__quantities_like_residuals_non_zero(self)
317317
[6, 7, 8],
318318
]
319319

320-
pixelization_chi_squareds = aa.util.inversion.pixelization_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
320+
pixelization_chi_squareds = aa.util.inversion.inversion_chi_squared_map_from_pixelization_values_and_reconstructed_data_1d(
321321
pixelization_values=pixelization_values,
322322
reconstructed_data_1d=reconstructed_data_1d,
323323
noise_map_1d=noise_map_1d,

0 commit comments

Comments
 (0)