Skip to content

Commit d1afb2e

Browse files
committed
making clippy suggested changes
1 parent 381ef5c commit d1afb2e

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

exercises_downloader/src/main.rs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ members = [\nworkspace_members]"
3939
Ok(())
4040
}
4141

42-
fn write_toml(path: &Path, slug: &String, libraries: &String) -> std::io::Result<()> {
42+
fn write_toml(path: &Path, slug: &str, libraries: &String) -> std::io::Result<()> {
4343
// exercise Cargo.toml template
4444
let content = "[package]
4545
name = \"package_name\"
4646
version = \"0.1.0\"
4747
edition = \"2024\"\n
4848
[dependencies]\n"
49-
.replace("package_name", slug.as_str());
49+
.replace("package_name", slug);
5050

5151
let filename = path.join("Cargo.toml");
5252
let mut file = File::create(filename)?;
@@ -79,10 +79,10 @@ fn write_exercise(path: &Path, template: &String) -> std::io::Result<()> {
7979

8080
fn write_markdown(
8181
path: &Path,
82-
name: &String,
83-
description: &String,
84-
level: &String,
85-
author: &String,
82+
name: &str,
83+
description: &str,
84+
level: &str,
85+
author: &str,
8686
) -> std::io::Result<()> {
8787
// exercise markdown template
8888
let content = "# package_name
@@ -91,10 +91,10 @@ fn write_markdown(
9191
- Author: package_author\n
9292
## Instructions
9393
package_description\n"
94-
.replace("package_name", name.as_str())
95-
.replace("package_description", description.as_str())
96-
.replace("package_level", level.as_str())
97-
.replace("package_author", author.as_str());
94+
.replace("package_name", name)
95+
.replace("package_description", description)
96+
.replace("package_level", level)
97+
.replace("package_author", author);
9898

9999
let filename = path.join("README.md");
100100
let mut file = File::create(filename)?;
@@ -136,21 +136,21 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
136136
for bite in &bites {
137137
print!("{:#?}", bite.name);
138138
let slug = &bite.slug;
139-
let exercise_path = &base_path.join(&bite.level).join(&slug);
139+
let exercise_path = &base_path.join(&bite.level).join(slug);
140140

141141
// make sure the exercise directory exists
142-
fs::create_dir_all(&exercise_path)?;
142+
fs::create_dir_all(exercise_path)?;
143143
// re-write/update the toml and md files but make a backup copy of the
144144
// exercise file if it exists, in case it was already solved
145-
write_toml(&exercise_path, &slug, &bite.libraries)?;
145+
write_toml(exercise_path, slug, &bite.libraries)?;
146146
write_markdown(
147-
&exercise_path,
147+
exercise_path,
148148
&bite.name,
149149
&bite.description,
150150
&bite.level,
151151
&bite.author,
152152
)?;
153-
write_exercise(&exercise_path, &bite.template)?;
153+
write_exercise(exercise_path, &bite.template)?;
154154
println!(" ✅");
155155
}
156156

0 commit comments

Comments
 (0)