migrate_connections.py result list returned empty

[dan-gut1]

Hey @katzy687 @amosshachar

In migrate_connections.py the returned list of '_recursive_get_connections' returned empty due to recursive calls it get re-initiated.
I'm trying to push an easy fix but I don't have write access.

My easy fix is to move line 19 'result = []' to line 11 and make the list global. it maybe not the best of a solution but a one time run script and it did the job for me.

[katzy687]

Hey Dan, you are correct that is a bug.. the function as is will work for resource with flat ports but will fail for resource with more hierarchy when it actually does a recursive call.

Adding a global result list at the top works. A different option is to do something like this:

def _get_recursive_connections(child_resources, result=None):
result = result if result else []

That way on first call to function when result is None you get the new list but then pass along the same list on the recursive calls. This way the result list stays scoped to the recursive function and can't be accidentally updated somewhere else.

As general note, to push changes back to this repo, you can fork the repo to your github, clone locally, make change and push to fork, then make a PR back to the upstream repo from your fork

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request