Skip to content

[kernel] rt_thread_suspend_to_list函数补充 #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kurngsy wants to merge 2 commits into
base: master
Choose a base branch
from
+32 −5
Open

[kernel] rt_thread_suspend_to_list函数补充 #10970

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321277e
Enhance thread suspend function with stricter checks
Kurngsy Nov 21, 2025
1297b89
Clean up formatting in thread.c
Kurngsy Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions src/thread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,30 +943,58 @@ rt_err_t rt_thread_suspend_to_list(rt_thread_t thread, rt_list_t *susp_list, int
RT_ASSERT(thread != RT_NULL);
RT_ASSERT(rt_object_get_type((rt_object_t)thread) == RT_Object_Class_Thread);

LOG_D("thread suspend: %s", thread->parent.name);
LOG_D("thread suspend: %s", thread->parent.name);

rt_sched_lock(&slvl);

stat = rt_sched_thread_get_stat(thread);
if (stat == RT_THREAD_SUSPEND)
/* Already suspended, just set the status to success. */
if (stat & RT_THREAD_SUSPEND_MASK)
{
if (RT_SCHED_CTX(thread).sched_flag_ttmr_set == 1)
Copy link
Member

@Rbb666 Rbb666 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的修改我理解是为了判断：某一线程去主动挂起已经休眠中的线程，并停止该线程的定时器？

Copy link
Author

@Kurngsy Kurngsy Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是，改为默认使新挂起不被唤醒，原逻辑中，新挂起会被delay的旧挂起唤醒

{
/* The new suspend operation will halt the tick timer. */
LOG_D("Thread [%s]'s timer has been halted.\n", thread->parent.name);
rt_sched_thread_timer_stop(thread);

}
/* Map suspend_flag to corresponding thread suspend state value */
rt_uint8_t new_suspend_state;
switch (suspend_flag)
{
case RT_INTERRUPTIBLE:
new_suspend_state = RT_THREAD_SUSPEND_INTERRUPTIBLE;
break;
case RT_KILLABLE:
new_suspend_state = RT_THREAD_SUSPEND_KILLABLE;
break;
case RT_UNINTERRUPTIBLE:
default:
new_suspend_state = RT_THREAD_SUSPEND_UNINTERRUPTIBLE;
break;
}
/* Compare the suspend state portion of stat with the new suspend state */
if (stat < new_suspend_state)
{
/* Update if suspend_flag is stricter */
_thread_set_suspend_state(thread, suspend_flag);
}

rt_sched_unlock(slvl);
/* Already suspended, just set status to success. */
return RT_EOK;
}
else if ((stat != RT_THREAD_READY) && (stat != RT_THREAD_RUNNING))
{
LOG_D("thread suspend: thread disorder, 0x%2x", RT_SCHED_CTX(thread).stat);
LOG_W("thread suspend: thread disorder, 0x%02x", RT_SCHED_CTX(thread).stat);
rt_sched_unlock(slvl);
return -RT_ERROR;
}

if (stat == RT_THREAD_RUNNING)
{
/* not suspend running status thread on other core */
RT_ASSERT(thread == rt_thread_self());
}

#ifdef RT_USING_SMART
if (thread->lwp)
{
Expand Down
Loading