-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[DM][HWCRYPTO] Make Kconfig import for DM #11005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-02 13:59 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds conditional Kconfig sourcing for Device Manager (DM) hardware crypto drivers, allowing SOC-specific hardware crypto configurations to be dynamically imported when both DM and HWCRYPTO are enabled.
Key changes:
- Adds conditional import of SOC-specific hardware crypto Kconfig files when both RT_USING_DM and RT_USING_HWCRYPTO are enabled
| endif | ||
| endif | ||
|
|
||
| if RT_USING_DM && RT_USING_HWCRYPTO |
Copilot
AI
Dec 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SOC_DM_HWCRYPTO_DIR variable is referenced but not documented. Consider adding a comment explaining where this variable should be defined and what it should contain, to help BSP developers who need to integrate DM hardware crypto support.
| if RT_USING_DM && RT_USING_HWCRYPTO | |
| if RT_USING_DM && RT_USING_HWCRYPTO | |
| # SOC_DM_HWCRYPTO_DIR should be defined in your BSP's Kconfig or build system. | |
| # It must contain the path to the directory with the DM hardware crypto Kconfig file. | |
| # Example: set SOC_DM_HWCRYPTO_DIR to "bsp/your_board/drivers/dm_hwcrypto" |
拉取/合并请求描述:(PR description)
[
Make Kconfig import for DM
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up