Fixed Windows process launching, About dialog

globals.cpp
+ include <string> to silence VS's warnings
+ Application version string for about dialog
~ call wxExecute instead of custom code to launch the processes

interface_derived.cpp
+ new dedicated About dialog, with clickable link and revised text
~ Removed platform-specific defines in the command builder, since they are no longer needed with the new launch_process

create_dialog_derived.cpp
~ replaced WinEscapePath with quotes to fix wxExecute

Author: Ravbug

source/create_dialog_derived.cpp

@@ -86,7 +86,7 @@ void CreateProjectDialogD::OnCreate(wxCommandEvent& event){
 		#elif defined _WIN32
 			string fullProj = "\"" + projPath + dirsep + projName + "\"";
 			string fullTemplate = "\"" + executableTemplatesPath + templatePrefix + "." + templateName + "\"";
-			string command = WinEscapePath(executablePath) + " -createproject " + fullProj + " -cloneFromTemplate " + fullTemplate;
+			string command = "\"" + executablePath + "\" -createproject " + fullProj + " -cloneFromTemplate " + fullTemplate;
 		#endif
 		//TODO: return this command to what summoned this dialog
 		project p = {projName,e.name,"",projPath + dirsep + projName};

source/globals.cpp

@@ -10,11 +10,13 @@ using namespace std;
 
 #include <sys/stat.h>
 #include <wx/listctrl.h>
+#include <string>
 
 //data file names
 static const string projectsFile = "projects.txt";
 static const string editorPathsFile = "editorPaths.txt";
 static const string templatePrefix = "com.unity.template";
+static const string AppVersion = "v1.1";
 
 //structure for representing an editor and for locating it
 struct editor{
@@ -46,6 +48,7 @@ struct editor{
 #include <windows.h>
 #include <gdiplus.h>	
 #include <thread>
+#include <wx/wx.h>
 	static const string datapath = getenv("HOMEPATH") + string("\\AppData\\Roaming\\UnityHubNative");
 	static const char dirsep = '\\';
 
@@ -146,23 +149,9 @@ inline void launch_process(const string& command) {
 	pclose(stream);
 
 #elif _WIN32
-	//On Windows, create an independent thread
-	//this method has the side effect of creating a cmd window, and when Unity is launched from it, the cmd window
-	//does not dissapear automatically, and UnityHubNative cannot launch more processes until that window is closed
-	auto bg_exec = [](string com) {
-		FILE* stream = popen(com.c_str(), "r");
-		//read the buffer to the end of the buffer
-		char buffer[1024];
-		if (stream) {
-			while (!feof(stream)) {
-				fgets(buffer,1024,stream);
-			}
-			//close the buffer when at the end
-			pclose(stream);
-		}
-	};
-	thread run(bg_exec,command);
-	run.detach();
+	//call wxExecute with the Async flag
+	wxExecute(wxString(command),0);
+
 #endif
 }
 
@@ -172,8 +161,7 @@ inline void reveal_in_explorer(const string& path){
 
 #elif defined _WIN32
 	//do not surround the paths in quotes, it will not work
-	string command = "\\Windows\\explorer.exe " + path;
-	command = WinEscapePath(command);
+	string command = "\\Windows\\explorer.exe \"" + path + "\"";
 #endif
 	launch_process(command);
 }

source/interface_derived.cpp

@@ -10,6 +10,7 @@
 #include <fstream>
 #include <wx/msgdlg.h>
 #include <wx/dirdlg.h>
+#include <wx/aboutdlg.h>
 #if defined _WIN32
 #include "dirent.h" 
 #else
@@ -106,11 +107,14 @@ MainFrameDerived::MainFrameDerived() : MainFrame(NULL){
 //definitions for the events
 void MainFrameDerived::OnAbout(wxCommandEvent& event)
 {
-	string winfix = "";
-#if defined _WIN32
-	winfix = "About Unity Hub Native\n\n";
-#endif
-	wxMessageBox(winfix + "Unity Hub Native is a custom Unity Hub, designed to be more efficient than Unity's official hub. Rather than Electron and web technologies, this application uses native GUI on each platform. \n\nThis app is not a replacement for the Unity Hub.\n\nVisit github.com/ravbug/UnityHubNative for more information and for updates. \n\nCreated by Ravbug, written in C++. Uses the wxWidgets GUI library.", "About Unity Hub Native", wxOK | wxICON_INFORMATION );
+	wxAboutDialogInfo aboutInfo;
+	aboutInfo.SetName("Unity Hub Native");
+	aboutInfo.SetVersion(AppVersion);
+	aboutInfo.SetDescription(_("Unity Hub Native is a custom Unity Hub, designed to be more efficient than Unity's official hub.\nRather than use Electron and web technologies for the GUI, this application uses native GUI on each platform.\nThis app is not a replacement for the official Unity Hub.\n\nCreated by Ravbug, written in C++. Uses the wxWidgets GUI library." ));
+	aboutInfo.SetCopyright("(C) 2019");
+	aboutInfo.SetWebSite("https://github.com/ravbug/UnityHubNative");
+	aboutInfo.AddDeveloper("Ravbug (github.com/ravbug)");
+	wxAboutBox(aboutInfo);
 }
 
 void MainFrameDerived::OnAddProject(wxCommandEvent& event){
@@ -269,13 +273,8 @@ void MainFrameDerived::OpenProject(const long& index){
 
 		//check that the unity editor exists at that location
 		if (file_exists(editorPath)){
-			
-			//platform specific paths
-			#if defined __APPLE__
+					
 			string cmd = "\"" + editorPath + "\" -projectpath \"" + p.path + "\"";
-			#elif defined _WIN32
-			string cmd = WinEscapePath(editorPath) + " -projectpath " + "\"" + p.path + "\"";
-			#endif
 
 			//start the process
 			launch_process(cmd);