Fix another path bug

Author: Ravbug

source/create_dialog_derived.cpp

@@ -88,12 +88,12 @@ void CreateProjectDialogD::OnCreate(wxCommandEvent& event){
 		#elif defined _WIN32
 			auto fullProj = std::filesystem::path("\"") / projPath / projName / "\"";
 			auto fullTemplate = std::filesystem::path("\"") / executableTemplatesPath / (templatePrefix + "." + templateName + "\"");
-			string command = "\"" + executablePath.string() + "\" -createproject " + fullProj.string() + " -cloneFromTemplate " + fullTemplate.string();
+			string command = "\"" + executablePath.string() + "\" -createproject " + fullProj.string() + " -cloneFromTemplate \"" + fullTemplate.string();
 		#elif defined __linux__
 			string command = "\"" + executablePath + "\" -createproject \"" + projPath + dirsep + projName + "\" -cloneFromTemplate \"" + executableTemplatesPath + templatePrefix + "." + templateName + "\"";
 		#endif
 		//TODO: return this command to what summoned this dialog
-		project p = {projName,e.name,"",projPath + dirsep + projName};
+		project p = {projName,e.name,"",filesystem::path(projPath) / filesystem::path(projName)};
 		this->callback(command,p);
 
 		//close and dispose self

source/globals.h

@@ -141,17 +141,6 @@ struct project{
 	std::filesystem::path path;
 };
 
-/**
- Determines if a file exists at a path using stat()
- @param name the path to the file
- @return true if the file exists, false if it does not
- */
-inline bool file_exists(const std::string& name){
-	struct stat buffer;
-	return (stat (name.c_str(), &buffer) == 0);
-}
-
-
 /**
  Launches a shell command as a separate, non-connected process. The output of this
  command is not captured (sent to the system's null device)

source/interface_derived.cpp

@@ -373,17 +373,18 @@ string MainFrameDerived::GetPathFromDialog(const string& message)
  @note Surround this function in a try/catch, because it throws if it cannot succeed.
  */
 project MainFrameDerived::LoadProject(const string &path){
+	std::filesystem::path p_as_fs(path);
 	//error if the file does not exist
-	if (!file_exists(path)){
+	if (!filesystem::exists(p_as_fs)){
 		throw runtime_error(path + " does not exist.");
 	}
 
 	//the name is the final part of the path
 	string name = path.substr(path.find_last_of(dirsep)+1);
 
 	//Load ProjectSettings/ProjectVersion.txt to get the editor version, if it exists
-	string projSettings = string(path + dirsep + "ProjectSettings" + dirsep + "ProjectVersion.txt");
-	if (!file_exists(projSettings)){
+	std::filesystem::path projSettings = std::filesystem::path(path) / "ProjectSettings" / "ProjectVersion.txt";
+	if (!filesystem::exists(projSettings)){
 		throw runtime_error("No ProjectVersion.txt found at " + path + "\n\nEnsure the folder you selected is the root folder of a complete Unity project.");
 	}