[0.8] fix flow tests (#501)

fix flow tests (#494)

* fix flow tests

use ml_dtypes for bfloat
update numpy to latest

 bindings/cmake:
 * add min version
 * make VecSim library PRIVATE

 add verbose option to make flow_test

* add verbose to pull request event

* update cmake version

* enable temp flow

* run flow tests

* try using poetry action

* install poetry script

* don't install curl on rocky

* minimum cmake version cmake 25

(cherry picked from commit 8d5bd88)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>

Author: github-actions[bot]

.github/workflows/event-pull_request.yml

@@ -32,7 +32,7 @@ jobs:
       - name: unit tests
         run: make unit_test
       - name: flow tests
-        run: make flow_test
+        run: make flow_test VERBOSE=1
 
   coverage:
     needs: [basic-tests, check-if-docs-only]

.github/workflows/flow-temp.yml

@@ -11,21 +11,46 @@ on:
   push:
     branches-ignore: ['**'] # ignore all branches. Comment this line to run your workflow below on every push.
 jobs:
-  rocky8:
+  jammy:
     uses: ./.github/workflows/task-unit-test.yml
     with:
-      container: rockylinux:8
+      container: ubuntu:jammy
       run-valgrind: false
-      run-codecov: false
-  rocky9:
+  focal:
     uses: ./.github/workflows/task-unit-test.yml
     with:
-      container: rockylinux:9
+      container: ubuntu:focal
       run-valgrind: false
-      run-codecov: false
-  focal:
+  bionic:
     uses: ./.github/workflows/task-unit-test.yml
     with:
       container: ubuntu:focal
       run-valgrind: false
-      run-codecov: true
+  bullseye:
+    uses: ./.github/workflows/task-unit-test.yml
+    with:
+      container: debian:bullseye
+      run-valgrind: false
+  amazonlinux2:
+    uses: ./.github/workflows/task-unit-test.yml
+    with:
+      container: amazonlinux:2
+      pre-checkout-script: yum install -y tar gzip
+      run-valgrind: false
+  mariner2:
+    uses: ./.github/workflows/mariner2.yml
+  rocky8:
+    uses: ./.github/workflows/task-unit-test.yml
+    with:
+      container: rockylinux:8
+      run-valgrind: false
+  rocky9:
+    uses: ./.github/workflows/task-unit-test.yml
+    with:
+      container: rockylinux:9
+      run-valgrind: false
+  macos:
+    uses: ./.github/workflows/macos.yml
+  arm:
+    uses: ./.github/workflows/arm.yml
+    secrets: inherit

Makefile

@@ -75,6 +75,7 @@ make unit_test     # run unit tests
 make valgrind      # build for Valgrind and run tests
 make flow_test     # run flow tests (with pytest)
   TEST=file::name    # run specific test
+  VERBOSE=1        # print detailed bindings build info
 make mod_test      # run Redis module intergration tests (with RLTest)
   TEST=file:name     # run specific test
   VERBOSE=1          # show more test detail
@@ -190,9 +191,12 @@ valgrind:
 .PHONY: unit_test valgrind
 
 #----------------------------------------------------------------------------------------------
+ifeq ($(VERBOSE),1)
+POETRY_ARGS += -vv
+endif
 
 flow_test:
-	$(SHOW)poetry install
+	$(SHOW)poetry install $(POETRY_ARGS)
 	$(SHOW)poetry run pytest tests/flow/$(TEST) -v -s
 
 .PHONY: flow_test

pyproject.toml

@@ -26,12 +26,12 @@ classifiers = [
 python = "^3.10"
 
 [tool.poetry.dev-dependencies]
-numpy = "^1.26"
+numpy = "*"
 hnswlib = "^0.6.2"
 pytest = "^6.2.4"
 scipy = "^1.10.1"
 h5py = "^3.7.0"
-bfloat16 = "^1.1"
+ml_dtypes = "*"
 
 
 [build-system]

src/python_bindings/CMakeLists.txt

@@ -1,3 +1,4 @@
+cmake_minimum_required(VERSION 3.25)
 project(VecSim LANGUAGES CXX)
 set(CMAKE_CXX_STANDARD 20)
 
@@ -25,6 +26,6 @@ include_directories(${root}/src ${root}/tests/utils)
 
 pybind11_add_module(VecSim ../../tests/utils/mock_thread_pool.cpp bindings.cpp)
 
-target_link_libraries(VecSim VectorSimilarity)
+target_link_libraries(VecSim PRIVATE VectorSimilarity)
 
 add_dependencies(VecSim VectorSimilarity)

tests/flow/common.py

@@ -8,7 +8,7 @@
 from numpy.testing import assert_allclose, assert_equal
 import time
 import math
-from bfloat16 import bfloat16
+from ml_dtypes import bfloat16
 
 def create_hnsw_params(dim, num_elements, metric, data_type, ef_construction=200, m=16, ef_runtime=10, epsilon=0.01,
                       is_multi=False):