[8.2] [MOD-10833] [MOD-10236] SVS Library Update: Fix Zero Vector Handling and Alpine C++20 Compatibility (#774)

[MOD-10833] [MOD-10236] SVS Library Update: Fix Zero Vector Handling and Alpine C++20 Compatibility (#752)

* SVS updates for SVS_LAZY and inf/nan

* add a test for zero vector

* fix valgrind issue

* use v0.0.10 SVS libs

* move test

---------


(cherry picked from commit 4e58260)

Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com>
Co-authored-by: meiravgri <meirav.grimberg@redis.com>

Author: 3 people

cmake/svs.cmake

@@ -56,16 +56,16 @@ if(USE_SVS)
     cmake_dependent_option(SVS_SHARED_LIB "Use SVS pre-compiled shared library" ON "USE_SVS AND GLIBC_FOUND AND SVS_LVQ_SUPPORTED" OFF)
     if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         if (GLIBC_2_28_FOUND)
-            set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.9/svs-shared-library-0.0.9-reduced-clang.tar.gz" CACHE STRING "SVS URL")
+            set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.10/svs-shared-library-0.0.10-reduced-clang.tar.gz" CACHE STRING "SVS URL")
         else()
             message(STATUS "GLIBC>=2.28 is required for Clang build - disabling SVS_SHARED_LIB")
             set(SVS_SHARED_LIB OFF)
         endif()
     else()
         if (GLIBC_2_28_FOUND)
-            set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.9/svs-shared-library-0.0.9-reduced.tar.gz" CACHE STRING "SVS URL")
+            set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.10/svs-shared-library-0.0.10-reduced.tar.gz" CACHE STRING "SVS URL")
         elseif(GLIBC_2_26_FOUND)
-            set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.9/svs-shared-library-0.0.9-reduced-glibc2_26.tar.gz" CACHE STRING "SVS URL")
+            set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.0.10/svs-shared-library-0.0.10-reduced-glibc2_26.tar.gz" CACHE STRING "SVS URL")
         else()
             message(STATUS "GLIBC>=2.26 is required for SVS shared library - disabling SVS_SHARED_LIB")
             set(SVS_SHARED_LIB OFF)

deps/ScalableVectorSearch

@@ -1771,6 +1771,31 @@ TYPED_TEST(SVSTest, batchIteratorSwapIndices) {
     VecSimIndex_Free(index);
 }
 
+// This test verifies a bug fix where zero vectors would cause division by zero during
+// normalization (vector/norm where norm=0), resulting in NaN/Inf values that crashed the SVS
+// library. The fix was introduced in PR #752, bumping up SVS library to version that includes the
+// fix.
+TYPED_TEST(SVSTest, test_index_zeros_vector_cosine) {
+    const size_t dim = 4;
+
+    SVSParams params = {
+        .dim = dim,
+        .metric = VecSimMetric_Cosine,
+    };
+    this->SetTypeParams(params);
+    VecSimParams index_params = CreateParams(params);
+    VecSimIndex *index = this->CreateNewIndex(index_params);
+    ASSERT_INDEX(index);
+
+    auto svs_index = this->CastToSVS(index);
+    ASSERT_NE(svs_index, nullptr);
+
+    GenerateAndAddVector<TEST_DATA_T>(index, dim, 0, 0);
+
+    ASSERT_EQ(VecSimIndex_IndexSize(index), 1);
+    VecSimIndex_Free(index);
+}
+
 TYPED_TEST(SVSTest, svs_vector_search_test_cosine) {
     // Scalar quantization accuracy is insufficient for this test.
     if (this->isFallbackToSQ()) {