[0.8] Meiravg_feature_bfloat16 (#464)

* upgrade codcov instance to c7i

(cherry picked from commit b5cc93b)

* [MOD-6763] bfloat16 - distance calculation functions (#445)

(cherry picked from commit 850d6a8)

* update arch_opt macros in bf16 BM

(cherry picked from commit 253dcd3)

* fix macro check

(cherry picked from commit 26b047d)

* Remove arch_opt enum and use cpu features flags instead (#459)

(cherry picked from commit f98793a)

* FP16 distance functions (#453)

(cherry picked from commit 9420e77)

* [MOD-6764] Introduce bfloat16 datatype (#454)

* Introduce bfloat16 datatype

add Datatype to `VecSimIndexAbstract` template args.

add template to SetDistFunc and have specialized implemntation for each <dataType, distType> combintation
now the dist function pointer argument is not neseccesary, we can simple return the function.

move using dist_func_t to spaces_aux.h (should be in a file included by both L2_spaces.h/IP.spaces.h and spaces.h)

* move getdistance imp to spaces.cpp

* move normalize function from vec_utils to spaces:

spaces.h: get normalize function.
spaces.cpp: specialized templates according to the datatype for the normalization functions
spaces/normalize/normalize_naive.h: templated naive implementations of normalization functions

VecSimIndexAbstract must have both DataType and DistType

add VecSimType_BFLOAT16
update vec_utile accordingly

bfloat16.h: add bfloat16_to_float32 for little and big

TieredFactory::NewIndex calls TieredHNSWFactory::TieredFactory::NewIndex instead of implmentation duplication

add bfloat to index factory for NewIndex and EstimateInitialSize

* add no_opt functions tests for bfloat16

also add normalization function test for bf16

* fixed nohrmalized value

* add bf16 benchmarks:

add serialized hnsw bf16 files

hnswfactory: add ctor from file for bf16

add fitMemory and run it at the begining of each benchmark to tighten memory.

* update bm_files script

* add flow tests to bf16

bruteforce:
L2
batch iterator
range query
multivalue

hnsw:
serialization
L2
batch iterator
range
multi

tiered:
create
search and insert

* add bfloat16 module to toml

* upgrade scipy nupy

* also use python 3.10

* upgrade PR python to 3.10

* update serializer

* bm: fix casts

unit tests: add test_bf16

* more unit tests

* tiered tests

* add index_type assertion ti hnsw serialization test

add desgnated classes for bf and flat in bf16 unit test

* unit test final

* repalce cast to dynamic casts

* add get neighors test to tiered
add normalize test for bfloat16 in testcommon

* use bit_cast

* upgrade codecov machine

* Revert "upgrade codecov machine"

This reverts commit 7619b05.

* Revert "use bit_cast"

This reverts commit 59b8fab.

* fix alignment intialization by changing the order

* make bfloat16_to_float32 templated accroding to system's endianess

* eliminate default in GetDistFunc
add test for invalid metric

* add test fot fit memory

* split fit memory tests

(cherry picked from commit e018d91)

* run merge queue flow

(cherry picked from commit 4670c59)

* add override to fit memory

(cherry picked from commit f994c79)

* upload valgrind artifacts on failure

(cherry picked from commit 7ece68d)

* _mm256_loadu_epi16 is supported as of gcc1, use _mm256_lddqu_si256 instead

(cherry picked from commit c521d82)

* fix fit memory test (#461)

* fix fit memory test

* remove xenial checks

* remove irrelevant comment

* free index in seralization test

(cherry picked from commit a0b70c8)

* Remove avx512_BW_VL (#460)

* remove bw_vl arch (not needed, avx512 is enough)

* remove xenial from merge queue flow

* fix fit memory test (#461)

* fix fit memory test

* remove xenial checks

* remove irrelevant comment

* free index in seralization test

* install gcc10 bionic

* install newer vg ubuntu18

* exit valgrind directory

(cherry picked from commit d2e1d4f)

* [MOD-6775] introduce fp16 type! (#462)

* remove bw_vl arch (not needed, avx512 is enough)

* remove xenial from merge queue flow

* introduce fp16 type!

change bfloat and fp16 to struct typedef to avoid ambiguty between them

* added flow tests

* fp16 benchmarks

* fix hnsw flow test

* add float616 to serializing script

add fp16 files to bm files

decrease testSizeEstimation dim size to make it run fasetr in debug

* set log call back to null in benchmarks

* remove struct typedef
add default ctor

* add comma seriaizer file

* disable temp flow

* disabe for real

* remove constexpr from bfloat default ctor

declaring a default ctor as constexpr is allowed as of c++20, and this feature in particular is supported as of gcc10

I don't see any benefit using this feature...

* test focal

* disable temp flow

(cherry picked from commit 704282b)

---------

Co-authored-by: meiravgri <meirav.grimberg@redis.com>
Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
Co-authored-by: alonre24 <alonreshef24@gmail.com>

Author: 3 people

.github/workflows/benchmark.yml

@@ -27,7 +27,7 @@ jobs:
           github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
           # Ubuntu 22.04 128GB Storage AMI
           ec2-image-id: ami-0ba430d4b7b64de57
-          ec2-instance-type: r6i.xlarge
+          ec2-instance-type: r7i.xlarge
           subnet-id: ${{ secrets.AWS_EC2_SUBNET_ID }}
           security-group-id: ${{ secrets.AWS_EC2_SG_ID }}
 

.github/workflows/coverage.yml

@@ -20,9 +20,9 @@ jobs:
         with:
           mode: start
           github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
-          # Ubuntu 20.04 AMI
-          ec2-image-id: ami-0f4feb99425e13b50
-          ec2-instance-type: t3.xlarge
+          # Ubuntu 22.04 AMI
+          ec2-image-id: ami-036cafe742923b3d9
+          ec2-instance-type: c7i.xlarge
           subnet-id: ${{ secrets.AWS_EC2_SUBNET_ID }}
           security-group-id: ${{ secrets.AWS_EC2_SG_ID }}
 

.github/workflows/event-merge-to-queue.yml

@@ -2,6 +2,7 @@ name: Merge a Pull-Request Flow
 run-name: Validate ${{ github.ref_name }}
 
 on:
+  workflow_call:
   merge_group:
     types: [checks_requested]
 
@@ -27,12 +28,6 @@ jobs:
     uses: ./.github/workflows/task-unit-test.yml
     with:
       container: ubuntu:bionic
-  xenial:
-    needs: [check-if-docs-only]
-    if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
-    uses: ./.github/workflows/task-unit-test.yml
-    with:
-      container: ubuntu:xenial
   bullseye:
     needs: [check-if-docs-only]
     if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
@@ -87,7 +82,6 @@ jobs:
       - jammy
       - focal
       - bionic
-      - xenial
       - bullseye
       - centos7
       - amazonlinux2

.github/workflows/event-nightly.yml

@@ -26,11 +26,6 @@ jobs:
     with:
       container: ubuntu:bionic
       run-valgrind: false
-  xenial:
-    uses: ./.github/workflows/task-unit-test.yml
-    with:
-      container: ubuntu:xenial
-      run-valgrind: false
   bullseye:
     uses: ./.github/workflows/task-unit-test.yml
     with:

.github/workflows/event-pull_request.yml

@@ -22,7 +22,7 @@ jobs:
       - name: setup python
         uses: actions/setup-python@v4
         with:
-          python-version: '3.8'
+          python-version: '3.10'
       - name: install dependencies
         run: sudo .install/install_script.sh
       - name: install python packages

.github/workflows/flow-temp.yml

@@ -0,0 +1,22 @@
+name: temporary testing
+
+# This file is useful for triggering actions when you implement them.
+# When the `branches-ignore` line is commented out, this workflow will run on every push.
+# It is better to use this file for testing your new flows than creating a new one, to avoid cluttering the repo
+# action tab with unused workflows.
+# Don't worry about conflicts with other PRs - there is no "right" content of this file.
+# Make sure the `branches-ignore` line is not commented out when you merge your PR.
+
+on:
+  push:
+    branches-ignore: ['**'] # ignore all branches. Comment this line to run your workflow below on every push.
+
+jobs:
+  check-if-docs-only:
+    uses: ./.github/workflows/task-check-docs.yml
+  focal:
+    needs: [check-if-docs-only]
+    if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
+    uses: ./.github/workflows/task-unit-test.yml
+    with:
+      container: ubuntu:focal

.github/workflows/task-unit-test.yml

@@ -37,7 +37,7 @@ jobs:
         if: ${{ inputs.run-valgrind }}
         run: make valgrind
       - name: Archive valgrind tests reports
-        if: ${{ inputs.run-valgrind }}
+        if: ${{ inputs.run-valgrind }} && failure()
         uses: actions/upload-artifact@v3
         with:
           name: valgrind tests reports

.install/ubuntu_18.04.sh

@@ -9,6 +9,15 @@ $MODE apt-get dist-upgrade -yqq
 $MODE apt install -yqq software-properties-common
 $MODE add-apt-repository ppa:ubuntu-toolchain-r/test -y
 $MODE apt update
-$MODE apt-get install -yqq git wget make valgrind gcc-9 g++-9
+$MODE apt-get install -yqq git wget make gcc-9 g++-9 libc6-dbg
 $MODE update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-9 60 --slave /usr/bin/g++ g++ /usr/bin/g++-9
+
+wget https://sourceware.org/pub/valgrind/valgrind-3.18.0.tar.bz2
+tar -xjf valgrind-3.18.0.tar.bz2
+cd valgrind-3.18.0
+./configure
+make
+$MODE make install
+cd ..
+
 source install_cmake.sh $MODE

.install/ubuntu_22.04.sh

@@ -3,6 +3,6 @@ set -e
 export DEBIAN_FRONTEND=noninteractive
 MODE=$1 # whether to install using sudo or not
 
-$MODE apt-get update -qq
+$MODE apt-get update -qq || true
 $MODE apt-get install -yqq git wget build-essential valgrind lcov
 source install_cmake.sh $MODE

Makefile

@@ -193,7 +193,7 @@ valgrind:
 
 flow_test:
 	$(SHOW)poetry install
-	$(SHOW)poetry run pytest tests/flow -v -s
+	$(SHOW)poetry run pytest tests/flow/$(TEST) -v -s
 
 .PHONY: flow_test
 
@@ -278,7 +278,7 @@ $(COVERAGE_REPORT)
 endef
 
 coverage:
-	$(SHOW)$(MAKE) build COV=1
+	$(SHOW)$(MAKE) build COV=1 FP_64=1
 	$(SHOW)$(COVERAGE_RESET)
 	$(SHOW)cd $(TESTDIR) && GTEST_COLOR=1 ctest $(_CTEST_ARGS)
 	$(SHOW)$(COVERAGE_COLLECT_REPORT)