Skip to content

Commit 45eb411

Browse files
[0.8] Enhance bm files download and add dispatcher to bm flow (#493)
Enhance bm files download and add dispatcher to bm flow (#486) * add dispatcher to bm flow * remove some * include all bm * add description and default * download in parallel * don't use quite mode with wget * don't limit xarg parrallism * revert quite wget * enable logs * remove commented line * fix string in serializer script (cherry picked from commit 34ac6e3) Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
1 parent 1fc057b commit 45eb411

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed

.github/workflows/benchmark.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,33 @@ on:
44
setup:
55
type: string
66
required: true
7+
workflow_dispatch:
8+
inputs:
9+
setup:
10+
type: choice
11+
options:
12+
- benchmarks-all
13+
- benchmarks-default
14+
- bm-basics-fp32-single
15+
- bm-basics-fp32-multi
16+
- bm-basics-fp64-single
17+
- bm-basics-fp64-multi
18+
- bm-basics-bf16-single
19+
- bm-basics-bf16-multi
20+
- bm-basics-fp16-single
21+
- bm-basics-fp16-multi
22+
- bm-batch-iter-fp32-single
23+
- bm-batch-iter-fp32-multi
24+
- bm-batch-iter-fp64-single
25+
- bm-batch-iter-fp64-multi
26+
- bm-batch-iter-bf16-single
27+
- bm-batch-iter-bf16-multi
28+
- bm-batch-iter-fp16-single
29+
- bm-batch-iter-fp16-multi
30+
- bm-updated-fp32-single
31+
- bm-spaces
32+
description: 'Benchmarks set to run'
33+
default: benchmarks-all
734

835
jobs:
936
start-runner:

tests/benchmark/bm_files.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ elif [ "$BM_TYPE" = "bm-updated-fp32-single" ]; then
3232
file_name="updated"
3333
fi
3434

35-
wget --no-check-certificate -q -i tests/benchmark/data/hnsw_indices/hnsw_indices_$file_name.txt -P tests/benchmark/data
35+
cat tests/benchmark/data/hnsw_indices/hnsw_indices_$file_name.txt | xargs -n 1 -P 0 wget --no-check-certificate -P tests/benchmark/data

tests/benchmark/data/serializer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def serialize(files=DEFAULT_FILES):
191191
serialized_raw_name = serialized_raw_name + '-bf16'
192192
elif hnswparams.type == VecSimType_FLOAT16:
193193
serialized_file_name = serialized_file_name + '-fp16'
194-
serialized_raw_name = serialized_raw_name + '-fp16
194+
serialized_raw_name = serialized_raw_name + '-fp16'
195195

196196
print('first, exporting test set to binary')
197197
if not file.get('skipRaw', False):

0 commit comments

Comments
 (0)