Skip to content

Commit 1ab97c4

Browse files
author
Yorgos Saslis
committed
Moved docker image generation to package maven phase
the bindings to the `pre-integration-test` and `post-integration-test` phases only really make sense if/when we want to start some containers during the `verify` phase. I am keeping those execution bindings in, so we have the hooks ready. However, you can *safely remove* the `start` and `stop` executions of the fabric8 docker maven plugin with no problems.
1 parent f8ef975 commit 1ab97c4

File tree

1 file changed

+16
-8
lines changed
  • release/restcomm-assembly-as7

1 file changed

+16
-8
lines changed

release/restcomm-assembly-as7/pom.xml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,16 @@
126126
</configuration>
127127
<executions>
128128
<execution>
129-
<id>start</id>
130-
<phase>pre-integration-test</phase>
129+
<id>build</id>
130+
<phase>package</phase>
131131
<goals>
132-
<!-- "build" should be used to create the images with the
133-
artifact -->
134132
<goal>build</goal>
133+
</goals>
134+
</execution>
135+
<execution>
136+
<id>start</id>
137+
<phase>package</phase>
138+
<goals>
135139
<!--<goal>start</goal> not running any containers yet-->
136140
</goals>
137141
</execution>
@@ -231,12 +235,16 @@
231235
</configuration>
232236
<executions>
233237
<execution>
234-
<id>start</id>
235-
<phase>pre-integration-test</phase>
238+
<id>build</id>
239+
<phase>package</phase>
236240
<goals>
237-
<!-- "build" should be used to create the images with the
238-
artifact -->
239241
<goal>build</goal>
242+
</goals>
243+
</execution>
244+
<execution>
245+
<id>start</id>
246+
<phase>package</phase>
247+
<goals>
240248
<!--<goal>start</goal> not running any containers yet-->
241249
</goals>
242250
</execution>

0 commit comments

Comments
 (0)