@Spikeone While fixing #1963 I found another issue that has checked behavior in a test but is not fully clear:
What happens when a carrier is walking towards a flag carrying something?
We currently have an "expel" there: All people there or going from/to there are sent wandering once a soldier reaches a flag. "Wandering" means they move randomly and periodically search for a flag that leads back to a warehouse for them.
What does the original do:
- Do carriers really get sent away?
- Do they return to their road when the attack is over or soldier moved on? (expelling is done at any flag even on the way to the attacked building)
- Do they loose wares carried at that moment? Or e.g. drop them when they reach a flag after wandering?
The test mentioned above checks for a carrier that is walking a coin from the flag to the building right when the attacker arrives at the flag. The current behavior (asserted there) is that he will start wandering and the coin will not reach the building and is lost.
@Spikeone While fixing #1963 I found another issue that has checked behavior in a test but is not fully clear:
What happens when a carrier is walking towards a flag carrying something?
We currently have an "expel" there: All people there or going from/to there are sent wandering once a soldier reaches a flag. "Wandering" means they move randomly and periodically search for a flag that leads back to a warehouse for them.
What does the original do:
The test mentioned above checks for a carrier that is walking a coin from the flag to the building right when the attacker arrives at the flag. The current behavior (asserted there) is that he will start wandering and the coin will not reach the building and is lost.