fix(sync): prevent sync race condition with replace option#1
Draft
google-labs-jules[bot] wants to merge 2 commits into
Draft
fix(sync): prevent sync race condition with replace option#1google-labs-jules[bot] wants to merge 2 commits into
google-labs-jules[bot] wants to merge 2 commits into
Conversation
When using the `replace=true` sync option on a resource that is initially missing, a race condition can occur. The first sync correctly creates the resource, but the second sync attempts to create it again, resulting in an "already exists" error. This commit fixes the race condition by marking the resource as `Succeeded` immediately after it has been created with the `replace=true` option. This prevents the resource from being synced again in the same operation.
When using the `replace=true` sync option on a resource that is initially missing, a race condition can occur. The first sync correctly creates the resource, but the second sync attempts to create it again, resulting in an "already exists" error. This commit fixes the race condition by marking the resource as `Succeeded` immediately after it has been created with the `replace=true` option. This prevents the resource from being synced again in the same operation. A new test case has been added to verify the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
replace=truesync option on a resource that isinitially missing, a race condition can occur. The first sync
correctly creates the resource, but the second sync attempts to
create it again, resulting in an "already exists" error.
This commit fixes the race condition by marking the resource as
Succeededimmediately after it has been created with thereplace=trueoption. This prevents the resource from beingsynced again in the same operation.