<NUMBERDECIMAL> uses long, <NUMBERINTEGER> uses double

[eduarddrenth]

Parser does this:

(
    t = <NUMBER_DECIMAL>
    { 
        if(nativeNumbers) {
            return new Long(t.image);
        } else {
            return new BigDecimal(t.image); 
        }
    }
) | (
    t = <NUMBER_INTEGER>
    { 
        if(nativeNumbers) {
            return new Double(t.image);
        } else {
            return new BigInteger(substringBefore(t.image, '.')); 
        }
    }

I think it should be:

(
    t = <NUMBER_DECIMAL>
    { 
        if(nativeNumbers) {
            return new Double(t.image);
        } else {
            return new BigDecimal(t.image); 
        }
    }
) | (
    t = <NUMBER_INTEGER>
    { 
        if(nativeNumbers) {
            return new Long(t.image);
        } else {
            return new BigInteger(substringBefore(t.image, '.')); 
        }
    }
)

[RobertFischer]

That is true. The substring before logic should also be shared.

[eduarddrenth]

I see, I missed that part of it....Will you fix, or shall I?

[eduarddrenth]

On the other hand.... If you have a NUMBER_INTEGER there will be no dot, or will there?

So, shouldn't it be something like:

Number number(): {
Token t;
}{
(
t = <NUMBER_DECIMAL>
{
if(nativeNumbers) {
return new Double(t.image);
} else {
return new BigDecimal(t.image);
}
}
) | (
t = <NUMBER_INTEGER>
{
if(nativeNumbers) {
return new Long(t.image);
} else {
return new BigDecimal(t.image);
}
}
)
}

[RobertFischer]

No. 1.0 is interpreted as an integer value. There’s no difference in the JSON spec between number types. Consuming code should use the Java Number class.

~~ Robert.

On Apr 13, 2015, at 11:44 AM, Eduard Drenth notifications@github.com wrote:

On the other hand.... If you have a NUMBER_INTEGER there will be no dot, or will there?

So, shouldn't it be something like:

Number number(): {
Token t;
}{
(
t =
{
if(nativeNumbers) {
return new Double(t.image);
} else {
return new BigDecimal(t.image);
}
}
) | (
t =
{
if(nativeNumbers) {
return new Long(t.image);
} else {
return new BigDecimal(t.image);
}
}
)
}

—
Reply to this email directly or view it on GitHub #2 (comment).

[eduarddrenth]

right

On 13-04-15 17:46, Robert Fischer wrote:

No. 1.0 is interpreted as an integer value. There’s no difference in
the JSON spec between number types. Consuming code should use the Java
Number class.

~~ Robert.

On Apr 13, 2015, at 11:44 AM, Eduard Drenth
notifications@github.com wrote:

On the other hand.... If you have a NUMBER_INTEGER there will be no
dot, or will there?

So, shouldn't it be something like:

Number number(): {
Token t;
}{
(
t =
{
if(nativeNumbers) {
return new Double(t.image);
} else {
return new BigDecimal(t.image);
}
}
) | (
t =
{
if(nativeNumbers) {
return new Long(t.image);
} else {
return new BigDecimal(t.image);
}
}
)
}

—
Reply to this email directly or view it on GitHub
#2 (comment).

—
Reply to this email directly or view it on GitHub
#2 (comment).

[monicaduane]

Hey Robert!