Skip to content

Commit 29dad2e

Browse files
committed
refactor: removed lab specific wrappers
1 parent 222d8b3 commit 29dad2e

File tree

2 files changed

+1
-94
lines changed

2 files changed

+1
-94
lines changed

python/rcs/envs/creators.py

Lines changed: 0 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,13 @@
2323
)
2424
from rcs.envs.hw import FR3HW
2525
from rcs.envs.sim import (
26-
CamRobot,
2726
CollisionGuard,
2827
GripperWrapperSim,
2928
PickCubeSuccessWrapper,
3029
RandomCubePos,
3130
RobotSimWrapper,
3231
SimWrapper,
3332
)
34-
from rcs.envs.space_utils import VecType
3533
from rcs.envs.utils import (
3634
default_fr3_hw_gripper_cfg,
3735
default_fr3_hw_robot_cfg,
@@ -352,68 +350,3 @@ def __call__( # type: ignore
352350
}
353351

354352
return SimTaskEnvCreator()("fr3_simple_pick_up", render_mode, control_mode, delta_actions, cameras)
355-
356-
357-
class FR3SimplePickUpSimDigitHandEnvCreator(EnvCreator):
358-
def __call__( # type: ignore
359-
self,
360-
render_mode: str = "human",
361-
control_mode: ControlMode = ControlMode.CARTESIAN_TRPY,
362-
resolution: tuple[int, int] | None = None,
363-
frame_rate: int = 0,
364-
delta_actions: bool = True,
365-
) -> gym.Env:
366-
if resolution is None:
367-
resolution = (256, 256)
368-
369-
cameras = {
370-
"wrist": SimCameraConfig(
371-
identifier="wrist_0",
372-
type=CameraType.fixed,
373-
resolution_height=resolution[1],
374-
resolution_width=resolution[0],
375-
frame_rate=frame_rate,
376-
)
377-
}
378-
379-
return SimTaskEnvCreator()("fr3_simple_pick_up_digit_hand", render_mode, control_mode, delta_actions, cameras)
380-
381-
382-
class FR3LabPickUpSimDigitHandEnvCreator(EnvCreator):
383-
def __call__( # type: ignore
384-
self,
385-
cam_robot_joints: VecType,
386-
render_mode: str = "human",
387-
control_mode: ControlMode = ControlMode.CARTESIAN_TRPY,
388-
resolution: tuple[int, int] | None = None,
389-
frame_rate: int = 0,
390-
delta_actions: bool = True,
391-
) -> gym.Env:
392-
if resolution is None:
393-
resolution = (256, 256)
394-
395-
cameras = {
396-
"wrist": SimCameraConfig(
397-
identifier="wrist_0",
398-
type=CameraType.fixed,
399-
resolution_height=resolution[1],
400-
resolution_width=resolution[0],
401-
frame_rate=frame_rate,
402-
),
403-
"side": SimCameraConfig(
404-
identifier="wrist_1",
405-
type=CameraType.fixed,
406-
resolution_height=resolution[1],
407-
resolution_width=resolution[0],
408-
frame_rate=frame_rate,
409-
),
410-
}
411-
412-
env_rel = SimTaskEnvCreator()(
413-
"lab_simple_pick_up_digit_hand",
414-
render_mode,
415-
control_mode,
416-
delta_actions,
417-
cameras,
418-
)
419-
return CamRobot(env_rel, cam_robot_joints, "lab_simple_pick_up_digit_hand")

python/rcs/envs/sim.py

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import rcs
77
from rcs import sim
88
from rcs.envs.base import ControlMode, GripperWrapper, MultiRobotWrapper, RobotEnv
9-
from rcs.envs.space_utils import ActObsInfoWrapper, VecType
9+
from rcs.envs.space_utils import ActObsInfoWrapper
1010
from rcs.envs.utils import default_fr3_sim_robot_cfg
1111

1212
logger = logging.getLogger(__name__)
@@ -313,29 +313,3 @@ def step(self, action: dict[str, Any]):
313313
# normalize
314314
reward /= 5 # type: ignore
315315
return obs, reward, success, truncated, info
316-
317-
318-
class CamRobot(gym.Wrapper):
319-
"""Use this wrapper in lab setups where the second arm is used as a camera holder."""
320-
321-
def __init__(self, env, cam_robot_joints: VecType, scene: str = "lab_simple_pick_up_digit_hand"):
322-
super().__init__(env)
323-
self.unwrapped: RobotEnv
324-
assert isinstance(self.unwrapped.robot, sim.SimRobot), "Robot must be a sim.SimRobot instance."
325-
self.sim = env.get_wrapper_attr("sim")
326-
cfg = default_fr3_sim_robot_cfg(scene, "1")
327-
self.cam_robot = rcs.sim.SimRobot(
328-
self.sim, env.unwrapped.robot.get_ik(), cfg, register_convergence_callback=False
329-
)
330-
self.cam_robot.set_parameters(default_fr3_sim_robot_cfg(scene))
331-
self.cam_robot_joints = cam_robot_joints
332-
333-
def step(self, action: dict):
334-
self.cam_robot.set_joints_hard(self.cam_robot_joints)
335-
obs, reward, done, truncated, info = super().step(action)
336-
return obs, reward, done, truncated, info
337-
338-
def reset(self, *, seed=None, options=None):
339-
re = super().reset(seed=seed, options=options)
340-
self.cam_robot.reset()
341-
return re

0 commit comments

Comments
 (0)