Skip to content

Added Support for Draco Compression in 3D Inference#167

Merged
Sirsho1997 merged 1 commit into
mainfrom
feature-trellis-dracoCompression
Jun 9, 2026
Merged

Added Support for Draco Compression in 3D Inference#167
Sirsho1997 merged 1 commit into
mainfrom
feature-trellis-dracoCompression

Conversation

@Sirsho1997

Copy link
Copy Markdown
Contributor
image

@Sirsho1997 Sirsho1997 requested a review from Copilot June 9, 2026 12:12
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b1d85be-e0a0-4429-927f-aab12fedb20b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature-trellis-dracoCompression

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the ComfyUI-Runware 3D pipeline to support Draco compression configuration for 3D inference outputs, adds a dedicated 3D model search/selection node, and updates the frontend + example workflow to wire these capabilities together.

Changes:

  • Added a new “Runware 3D Inference Settings Draco Compression” node and plumbed its output into Runware 3D Inference Settings as settings.dracoCompression.
  • Added a new “Runware 3D Model Search” node and changed Runware 3D Inference to consume a RUNWARE3DMODEL link instead of a built-in model dropdown.
  • Updated client-side initialization and widget toggling to support the new node types, plus added a new 3D workflow example using Draco compression.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
workflows/Runware_3D_Inference_Trellis_2_Draco_Compression.json New example workflow wiring 3D model search + dracoCompression settings into 3D inference.
modules/threeDModelSearch.py New node to select/emit a 3D model AIR code as RUNWARE3DMODEL.
modules/threeDInferenceSettingsDracoCompression.py New node that builds the nested dracoCompression settings object.
modules/threeDInferenceSettings.py Accepts and forwards dracoCompression into the final settings payload.
modules/threeDInferenceInputs.py Adjusts multi-view image slot naming/handling for 3D inputs.
modules/threeDInference.py Switches 3D inference Model input to a RUNWARE3DMODEL link input.
clientlibs/utils.js Adds UI toggle handler for Draco compression settings node + 3D model list filtering by architecture.
clientlibs/types.js Registers new node types/properties for 3D model search and Draco settings nodes.
clientlibs/main.js Wires new node handlers into extension initialization.
init.py Registers the new Python node classes with ComfyUI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/threeDInferenceInputs.py
Comment thread modules/threeDInferenceInputs.py
Comment thread modules/threeDInferenceInputs.py
Comment thread modules/threeDInference.py
Comment thread workflows/Runware_3D_Inference_Trellis_2_Draco_Compression.json
Comment thread modules/threeDModelSearch.py
@Sirsho1997 Sirsho1997 merged commit 00af555 into main Jun 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants