Multiple windows per one synchronizer

[reddec]

Good day!

Is it possible to use one synchronizer with multiple windows and multiple limiters (ie: multiple clients)?

Pseudo code

synchronizer := NewNonBlockingSynchronizer()
for _, key := range keys {
  limiter, stop := slidingwindow.NewLimiter(interval, rate, func() (slidingwindow.Window, slidingwindow.StopFunc) {
    return slidingwindow.NewSyncWindow(key, synchronizer)
  })
}

SyncWindow code always starts Synchronizer

slidingwindow/window.go

Line 94 in 535bb99

w.syncer.Start()

however, in NonBlockingSynchronizer there are no checks for a double launch

slidingwindow/synchronizer.go

Line 131 in 535bb99

go s.syncLoop()

So I suspect that the number of goroutines will be roughly equal to the number of limiters, that sounds quite overkill.
Is it a bug, feature, or I missed something?

[RussellLuo]

Hi @reddec

So I suspect that the number of goroutines will be roughly equal to the number of limiters

Yes, you are right.

Is it possible to use one synchronizer with multiple windows and multiple limiters (ie: multiple clients)?

It is possible, but not implemented yet due to the complexity. Feel free to contribute if you are interested :-)