-
Notifications
You must be signed in to change notification settings - Fork 216
feat: Add global fast_math flag to CudaBuilder #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
koreaygj
wants to merge
1
commit into
Rust-GPU:main
Choose a base branch
from
koreaygj:feat/add-fast-math
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,6 +148,10 @@ pub struct CudaBuilder { | |
| /// Enable FMA (fused multiply-add) contraction. | ||
| /// `true` by default. | ||
| pub fma_contraction: bool, | ||
| /// Enable fast math approximations globally (equivalent to NVCC's --use_fast_math). | ||
| /// This implies ftz=true, prec-div=false, prec-sqrt=false, and fmad=true. | ||
| /// `false` by default. | ||
| pub fast_math: bool, | ||
| /// Whether to emit a certain IR. Emitting LLVM IR is useful to debug any codegen | ||
| /// issues. If you are submitting a bug report try to include the LLVM IR file of | ||
| /// the program that contains the offending function. | ||
|
|
@@ -206,6 +210,7 @@ impl CudaBuilder { | |
| nvvm_opts: true, | ||
| arch: NvvmArch::default(), | ||
| ftz: false, | ||
| fast_math: false, | ||
| fast_sqrt: false, | ||
| fast_div: false, | ||
| fma_contraction: true, | ||
|
|
@@ -266,6 +271,19 @@ impl CudaBuilder { | |
| self | ||
| } | ||
|
|
||
| /// Enable fast math approximations globally (equivalent to NVCC's --use_fast_math). | ||
| /// This implies ftz=true, prec-div=false, prec-sqrt=false, and fmad=true. | ||
| pub fn fast_math(mut self, fast_math: bool) -> Self { | ||
| self.fast_math = fast_math; | ||
| if fast_math { | ||
| self.ftz = true; | ||
| self.fast_sqrt = true; | ||
| self.fast_div = true; | ||
| self.fma_contraction = true; | ||
| } | ||
| self | ||
| } | ||
|
|
||
| /// Use a fast approximation for single-precision floating point square root. | ||
| pub fn fast_sqrt(mut self, fast_sqrt: bool) -> Self { | ||
| self.fast_sqrt = fast_sqrt; | ||
|
|
@@ -725,6 +743,10 @@ fn invoke_rustc(builder: &CudaBuilder) -> Result<PathBuf, CudaBuilderError> { | |
| llvm_args.push("-ftz=1".to_string()); | ||
| } | ||
|
|
||
| if builder.fast_math { | ||
| llvm_args.push("--use_fast_math".to_string()); | ||
| } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be plumbed through to NVCC, or should it be handled by CudaBuilder which then specifies the individual flags? |
||
|
|
||
| if builder.fast_sqrt { | ||
| llvm_args.push("-prec-sqrt=0".to_string()); | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a redundant representation. You're storing
fast_mathand also the individual flags. It should do one or the other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, nothing happens if
fast_mathis false. Is that intended?