reviews

Author: Jonas-Isr

cloudplatform/connectivity-destination-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationService.java

@@ -122,7 +122,7 @@ static ResilienceConfiguration createResilienceConfiguration(
     {
         if( Cache.preLookupCheckEnabled && !preLookupCheckSuccessful(destinationName) ) {
             final String msg = "Destination %s was not found among the destinations of the current tenant.";
-            return Try.failure(new DestinationAccessException(String.format(msg, destinationName)));
+            return Try.failure(new DestinationNotFoundException(String.format(msg, destinationName)));
         }
         return Cache.getOrComputeDestination(this, destinationName, options, this::loadAndParseDestination);
     }
@@ -455,17 +455,6 @@ static boolean isChangeDetectionEnabled()
             return changeDetectionEnabled;
         }
 
-        /**
-         * Enables checking if a destination exists before trying to call it directly when invoking
-         * {@link #tryGetDestination}.
-         *
-         * @since 5.25.0
-         */
-        public static void enablePreLookupCheck()
-        {
-            preLookupCheckEnabled = true;
-        }
-
         /**
          * Disables checking if a destination exists before trying to call it directly when invoking
          * {@link #tryGetDestination}.

cloudplatform/connectivity-destination-service/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationServiceTest.java

@@ -1926,15 +1926,16 @@ private String createHttpDestinationServiceResponse( final String name, final St
     @Test
     void testPrependGetAllDestinationsCall()
     {
+        // Reset Cache to re-enable the PreLookupCheck
+        DestinationService.Cache.reset();
+
         doReturn(responseServiceInstanceDestination)
             .when(destinationServiceAdapter)
             .getConfigurationAsJson(eq("/v1/instanceDestinations"), any());
         doReturn(responseSubaccountDestination)
             .when(destinationServiceAdapter)
             .getConfigurationAsJson(eq("/v1/subaccountDestinations"), any());
 
-        DestinationService.Cache.enablePreLookupCheck();
-
         Destination result = loader.tryGetDestination(destinationName).get();
 
         verify(destinationServiceAdapter, times(1)).getConfigurationAsJson(eq("/v1/instanceDestinations"), any());
@@ -1947,17 +1948,18 @@ void testPrependGetAllDestinationsCall()
     @Test
     void testPrependGetAllDestinationsCallWithMissingDestination()
     {
+        // Reset Cache to re-enable the PreLookupCheck
+        DestinationService.Cache.reset();
+
         doReturn(responseServiceInstanceDestination)
             .when(destinationServiceAdapter)
             .getConfigurationAsJson(eq("/v1/instanceDestinations"), any());
         doReturn(responseSubaccountDestination)
             .when(destinationServiceAdapter)
             .getConfigurationAsJson(eq("/v1/subaccountDestinations"), any());
 
-        DestinationService.Cache.enablePreLookupCheck();
-
         assertThatThrownBy(() -> loader.tryGetDestination("thisDestinationDoesNotExist").get())
-            .isInstanceOf(DestinationAccessException.class)
+            .isInstanceOf(DestinationNotFoundException.class)
             .hasMessageContaining("was not found among the destinations of the current tenant.");
 
         verify(destinationServiceAdapter, times(1)).getConfigurationAsJson(eq("/v1/instanceDestinations"), any());