Skip to content

Commit ffbdd19

Browse files
committed
withOpenApiResponseListen -> withResponseListener and marked Beta
1 parent aa1f126 commit ffbdd19

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

datamodel/openapi/openapi-core/src/main/java/com/sap/cloud/sdk/services/openapi/apache/ApiClient.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public class ApiClient
9393
@Nullable
9494
private final String tempFolderPath;
9595

96-
@With
96+
@Nullable
9797
private final OpenApiResponseListener openApiResponseListener;
9898

9999
// Methods that can have a request body
@@ -139,6 +139,12 @@ public static ApiClient create()
139139
return fromHttpClient((CloseableHttpClient) ApacheHttpClient5Accessor.getHttpClient());
140140
}
141141

142+
@Beta
143+
public ApiClient withResponseListener( @Nonnull final OpenApiResponseListener listener )
144+
{
145+
return new ApiClient(this.httpClient, this.basePath, this.objectMapper, this.tempFolderPath, listener);
146+
}
147+
142148
@Nonnull
143149
private static ObjectMapper createDefaultObjectMapper()
144150
{

datamodel/openapi/openapi-core/src/test/java/com/sap/cloud/sdk/services/openapi/apiclient/ApacheApiClientResponseHandlingTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ void testResponseMetadataListener( final WireMockRuntimeInfo wmInfo )
4747

4848
final AtomicReference<OpenApiResponse> metadata = new AtomicReference<>();
4949
final ApiClient apiClient =
50-
ApiClient.create().withBasePath(wmInfo.getHttpBaseUrl()).withOpenApiResponseListener(metadata::set);
50+
ApiClient.create().withBasePath(wmInfo.getHttpBaseUrl()).withResponseListener(metadata::set);
5151

5252
final TestApi api = new TestApi(apiClient);
5353
final TestResponse result = api.executeRequest();
@@ -75,7 +75,7 @@ void testCaseInsensitiveHeaderLookup( final WireMockRuntimeInfo wmInfo )
7575

7676
final AtomicReference<OpenApiResponse> capturedResponse = new AtomicReference<>();
7777
final ApiClient apiClient =
78-
ApiClient.create().withBasePath(wmInfo.getHttpBaseUrl()).withOpenApiResponseListener(capturedResponse::set);
78+
ApiClient.create().withBasePath(wmInfo.getHttpBaseUrl()).withResponseListener(capturedResponse::set);
7979

8080
final TestApi api = new TestApi(apiClient);
8181
api.executeRequest();

0 commit comments

Comments
 (0)