-
Notifications
You must be signed in to change notification settings - Fork 83
Open
Description
There are a few issues with them
- They aren't easy to find in the script
- There is no config file or --option to set them at run time
- The defaults are not sane on a few counts. directories in root in UNIX/UNIX-like is a no no. Capitalization is also a no no.
Affected:
appdir="/SYWorks/WIDS/"
macoui="/SYWorks/WIDS/mac-oui.db"
LogFile=appdir + "log.txt"
Recommendations
- Expected SANE defaults:
appdir="/usr/share/wids/"
macoui="/usr/share/wids/mac-oui.db"
LogFile= "/var/log/wids.log"
-
Put these variables at the top of the script before exporting them as globals. Make them easier to find.
-
add --options for setting these at run time, and parse a config perhaps /etc/wids.conf or something.
Further, its recommended you use argparse for parsing --options.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels