Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 08369bd

Browse files
committed
pr feedback
1 parent d97dbe0 commit 08369bd

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

spring-auto-restdocs-core/src/main/java/capital/scalable/restdocs/jackson/FieldDocumentationVisitorContext.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static capital.scalable.restdocs.util.TypeUtil.isPrimitive;
2525
import static org.apache.commons.lang3.StringUtils.isBlank;
2626
import static org.apache.commons.lang3.StringUtils.isNotBlank;
27+
import static org.apache.commons.lang3.StringUtils.trimToEmpty;
2728
import static org.slf4j.LoggerFactory.getLogger;
2829
import static org.springframework.restdocs.payload.PayloadDocumentation.fieldWithPath;
2930

@@ -169,10 +170,12 @@ private List<String> resolveConstraintDescriptions(Class<?> javaBaseClass,
169170

170171
private String resolveDeprecatedMessage(Class<?> javaBaseClass, String javaFieldName) {
171172
Field field = ReflectionUtils.findField(javaBaseClass, javaFieldName);
172-
boolean isDeprecated = field == null
173-
? false
174-
: field.getAnnotation(Deprecated.class) != null;
173+
boolean isDeprecated = field != null && field.getAnnotation(Deprecated.class) != null;
175174
String comment = javadocReader.resolveFieldTag(javaBaseClass, javaFieldName, "deprecated");
176-
return isDeprecated || isNotBlank(comment) ? comment : null;
175+
if (isDeprecated || isNotBlank(comment)) {
176+
return trimToEmpty(comment);
177+
} else {
178+
return null;
179+
}
177180
}
178181
}

0 commit comments

Comments
 (0)