default to no reuse

Author: Wimmerer

src/factorization.jl

@@ -35,7 +35,8 @@ function init_cacheval(alg::LUFactorization, A, b, u)
 end
 
 # This could be a GenericFactorization perhaps?
-struct UMFPACKFactorization <: AbstractFactorization
+Base.@kwdef struct UMFPACKFactorization <: AbstractFactorization
+    reuse_symbolic::Bool = false
 end
 
 function init_cacheval(::UMFPACKFactorization, A, b, u)
@@ -55,7 +56,7 @@ function SciMLBase.solve(cache::LinearCache, alg::UMFPACKFactorization)
         A = A.A
     end
     if cache.isfresh
-        if cache.cacheval !== nothing
+        if cache.cacheval !== nothing && alg.reuse_symbolic
             # If we have a cacheval already, run umfpack_symbolic to ensure the symbolic factorization exists
             # This won't recompute if it does.
             SuiteSparse.UMFPACK.umfpack_symbolic!(cache.cacheval)

test/runtests.jl

@@ -74,7 +74,7 @@ end
     test_interface(UMFPACKFactorization(), prob1, prob2)
 
     # Test that refactoring wrong throws.
-    cache = SciMLBase.init(prob1,UMFPACKFactorization(); cache_kwargs...) # initialize cache
+    cache = SciMLBase.init(prob1,UMFPACKFactorization(reuse_symbolic=true); cache_kwargs...) # initialize cache
     y = solve(cache)
     cache = LinearSolve.set_A(cache,sprand(n, n, 0.8))
     @test_throws ArgumentError solve(cache)