Merge pull request #221 from JuliaCI/remove-unwrap-val

switch to `SciMLBase`s version of `_unwrap_val`

Author: ChrisRackauckas

Project.toml

@@ -33,7 +33,7 @@ Krylov = "0.7.11, 0.8"
 KrylovKit = "0.5, 0.6"
 RecursiveFactorization = "0.2.8"
 Reexport = "1"
-SciMLBase = "1.32"
+SciMLBase = "1.68"
 Setfield = "0.7, 0.8, 1"
 SnoopPrecompile = "1"
 UnPack = "1"

src/LinearSolve.jl

@@ -23,6 +23,7 @@ import IterativeSolvers
 
 using Reexport
 @reexport using SciMLBase
+using SciMLBase: _unwrap_val
 
 abstract type SciMLLinearSolveAlgorithm <: SciMLBase.AbstractLinearAlgorithm end
 abstract type AbstractFactorization <: SciMLLinearSolveAlgorithm end

src/common.jl

@@ -1,13 +1,10 @@
 struct OperatorAssumptions{issquare} end
 function OperatorAssumptions(issquare = nothing)
-    OperatorAssumptions{_unwrap_val(issquare)}()
+    issquare = something(_unwrap_val(issquare), Nothing)
+    OperatorAssumptions{issquare}()
 end
 issquare(::OperatorAssumptions{issq}) where {issq} = issq
 
-_unwrap_val(::Val{B}) where {B} = B
-_unwrap_val(B::Nothing) = Nothing
-_unwrap_val(B::Bool) = B
-
 struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issquare}
     A::TA
     b::Tb