Merge pull request #232 from rveltz/main

correct mistake in constructor of KrylovKitJL

Author: ChrisRackauckas

src/iterative_wrappers.jl

@@ -291,27 +291,28 @@ end
 function KrylovKitJL(args...;
                      KrylovAlg = KrylovKit.GMRES, gmres_restart = 0,
                      kwargs...)
-    return KrylovJL(KrylovAlg, gmres_restart, args, kwargs)
+    return KrylovKitJL(KrylovAlg, gmres_restart, args, kwargs)
 end
 
 function KrylovKitJL_CG(args...; kwargs...)
-    KrylovKitJL(args...; KrylovAlg = KrylovKit.CG, kwargs...)
+    KrylovKitJL(args...; KrylovAlg = KrylovKit.CG, kwargs..., isposdef = true)
 end
+
 function KrylovKitJL_GMRES(args...; kwargs...)
     KrylovKitJL(args...; KrylovAlg = KrylovKit.GMRES, kwargs...)
 end
 
-function SciMLBase.solve(cache::LinearCache, alg::KrylovKitJL, kwargs...)
+function SciMLBase.solve(cache::LinearCache, alg::KrylovKitJL; kwargs...)
     atol = float(cache.abstol)
     rtol = float(cache.reltol)
     maxiter = cache.maxiters
     verbosity = cache.verbose ? 1 : 0
-    krylovdim = (alg.gmres_restart == 0) ? min(20, size(A, 1)) : alg.gmres_restart
+    krylovdim = (alg.gmres_restart == 0) ? min(20, size(cache.A, 1)) : alg.gmres_restart
 
     kwargs = (atol = atol, rtol = rtol, maxiter = maxiter, verbosity = verbosity,
               krylovdim = krylovdim, alg.kwargs...)
 
-    x, info = KrylovKit.linsolve(cache.A, cache.b, cache.u, alg.KrylovAlg)
+    x, info = KrylovKit.linsolve(cache.A, cache.b, cache.u; kwargs...)
 
     copy!(cache.u, x)
     resid = info.normres

test/basictests.jl

@@ -193,6 +193,7 @@ end
                     ("CG", KrylovKitJL_CG(kwargs...)),
                     ("GMRES", KrylovKitJL_GMRES(kwargs...)))
             @testset "$(alg[1])" begin test_interface(alg[2], prob1, prob2) end
+            @test alg[2] isa KrylovKitJL
         end
     end