Skip to content

Commit 3395c97

Browse files
committed
Updated rubyzip, bundler, rubygems version number and tests for them.
1 parent 229eaaf commit 3395c97

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ source "http://rubygems.org"
22
# Add dependencies required to use your gem here.
33
# Example:
44
# gem "activesupport", ">= 2.3.5"
5-
gem "rubyzip", "<1.0.0"
5+
gem "rubyzip", ">= 1.1.6"
66

77
# Add dependencies to develop your gem here.
88
# Include everything needed to run rake, tests, features, etc.
99
group :development do
1010
gem "rspec", "~> 2.11.0"
11-
gem "bundler", ">= 1.1.5"
11+
gem "bundler", ">= 1.3.0"
1212
gem "jeweler", "~> 1.8.7"
1313
gem "yard", require: false
1414
gem "redcarpet"

Gemfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ GEM
5353
rspec-expectations (2.11.3)
5454
diff-lcs (~> 1.1.3)
5555
rspec-mocks (2.11.3)
56-
rubyzip (0.9.9)
56+
rubyzip (1.1.6)
5757
simplecov (0.7.1)
5858
multi_json (~> 1.0)
5959
simplecov-html (~> 0.7.1)
@@ -64,10 +64,10 @@ PLATFORMS
6464
ruby
6565

6666
DEPENDENCIES
67-
bundler (>= 1.1.5)
67+
bundler (>= 1.3.0)
6868
jeweler (~> 1.8.7)
6969
redcarpet
7070
rspec (~> 2.11.0)
71-
rubyzip (< 1.0.0)
71+
rubyzip (>= 1.1.6)
7272
simplecov
7373
yard

lib/android/apk.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require 'zip/zip' # need rubyzip gem -> doc: http://rubyzip.sourceforge.net/
1+
require 'zip' # need rubyzip gem -> doc: http://rubyzip.sourceforge.net/
22
require 'digest/md5'
33
require 'digest/sha1'
44
require 'digest/sha2'
@@ -40,8 +40,8 @@ def initialize(filepath)
4040
@path = filepath
4141
raise NotFoundError, "'#{filepath}'" unless File.exist? @path
4242
begin
43-
@zip = Zip::ZipFile.open(@path)
44-
rescue Zip::ZipError => e
43+
@zip = Zip::File.open(@path)
44+
rescue Zip::Error => e
4545
raise NotApkFileError, e.message
4646
end
4747

ruby_apk.gemspec

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
Gem::Specification.new do |s|
77
s.name = "ruby_apk"
8-
s.version = "0.7.1"
8+
s.version = "0.7.2"
99

1010
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
1111
s.authors = ["SecureBrain"]
@@ -61,33 +61,33 @@ Gem::Specification.new do |s|
6161
s.homepage = "https://github.com/SecureBrain/ruby_apk/"
6262
s.licenses = ["MIT"]
6363
s.require_paths = ["lib"]
64-
s.rubygems_version = "2.0.6"
64+
s.rubygems_version = "2.4.1"
6565
s.summary = "static analysis tool for android apk"
6666

6767
if s.respond_to? :specification_version then
6868
s.specification_version = 4
6969

7070
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
71-
s.add_runtime_dependency(%q<rubyzip>, ["< 1.0.0"])
71+
s.add_runtime_dependency(%q<rubyzip>, [">= 1.1.6"])
7272
s.add_development_dependency(%q<rspec>, ["~> 2.11.0"])
73-
s.add_development_dependency(%q<bundler>, [">= 1.1.5"])
73+
s.add_development_dependency(%q<bundler>, [">= 1.3.0"])
7474
s.add_development_dependency(%q<jeweler>, ["~> 1.8.7"])
7575
s.add_development_dependency(%q<yard>, [">= 0"])
7676
s.add_development_dependency(%q<redcarpet>, [">= 0"])
7777
s.add_development_dependency(%q<simplecov>, [">= 0"])
7878
else
79-
s.add_dependency(%q<rubyzip>, ["< 1.0.0"])
79+
s.add_dependency(%q<rubyzip>, [">= 1.1.6"])
8080
s.add_dependency(%q<rspec>, ["~> 2.11.0"])
81-
s.add_dependency(%q<bundler>, [">= 1.1.5"])
81+
s.add_dependency(%q<bundler>, [">= 1.3.0"])
8282
s.add_dependency(%q<jeweler>, ["~> 1.8.7"])
8383
s.add_dependency(%q<yard>, [">= 0"])
8484
s.add_dependency(%q<redcarpet>, [">= 0"])
8585
s.add_dependency(%q<simplecov>, [">= 0"])
8686
end
8787
else
88-
s.add_dependency(%q<rubyzip>, ["< 1.0.0"])
88+
s.add_dependency(%q<rubyzip>, [">= 1.1.6"])
8989
s.add_dependency(%q<rspec>, ["~> 2.11.0"])
90-
s.add_dependency(%q<bundler>, [">= 1.1.5"])
90+
s.add_dependency(%q<bundler>, [">= 1.3.0"])
9191
s.add_dependency(%q<jeweler>, ["~> 1.8.7"])
9292
s.add_dependency(%q<yard>, [">= 0"])
9393
s.add_dependency(%q<redcarpet>, [">= 0"])

spec/apk_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
22
require 'tempfile'
3-
require 'zip/zip'
3+
require 'zip'
44
require 'digest/sha1'
55
require 'digest/sha2'
66
require 'digest/md5'
@@ -18,12 +18,12 @@ def destroy!
1818
File.unlink(@path) if File.exist? @path
1919
end
2020
def append(entry_name, data)
21-
Zip::ZipFile.open(@path, Zip::ZipFile::CREATE) { |zip|
21+
Zip::File.open(@path, Zip::File::CREATE) { |zip|
2222
zip.get_output_stream(entry_name) {|f| f.write data }
2323
}
2424
end
2525
def remove(entry_name)
26-
Zip::ZipFile.open(@path, Zip::ZipFile::CREATE) { |zip|
26+
Zip::File.open(@path, Zip::File::CREATE) { |zip|
2727
zip.remove(entry_name)
2828
}
2929
end
@@ -228,14 +228,14 @@ def remove(entry_name)
228228
before do
229229
tmp_apk.append("hoge.txt", "aaaaaaa")
230230
end
231-
it { expect { |b| apk.each_entry(&b) }.to yield_successive_args(Zip::ZipEntry, Zip::ZipEntry, Zip::ZipEntry) }
231+
it { expect { |b| apk.each_entry(&b) }.to yield_successive_args(Zip::Entry, Zip::Entry, Zip::Entry) }
232232
end
233233

234234
describe '#entry' do
235235
subject { apk.entry(entry_name) }
236236
context 'assigns exist entry' do
237237
let(:entry_name) { 'AndroidManifest.xml' }
238-
it { should be_instance_of Zip::ZipEntry }
238+
it { should be_instance_of Zip::Entry }
239239
end
240240
context 'assigns not exist entry name' do
241241
let(:entry_name) { 'not_exist_path' }

0 commit comments

Comments
 (0)