Avoid using ON on Cross Joins which fails in SqlServer

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.Join.cs

@@ -84,12 +84,12 @@ private SqlExpression<T> InternalJoin<Source, Target>(string joinType,
             return InternalJoin(joinType, joinExpr, sourceDef, targetDef);
         }
 
-        private string InternalCreateSqlFromExpression(Expression joinExpr) 
+        private string InternalCreateSqlFromExpression(Expression joinExpr, bool isCrossJoin) 
         {
-            return "ON {0}".Fmt(Visit(joinExpr).ToString());
+            return "{0} {1}".Fmt((isCrossJoin ? "WHERE" : "ON"), Visit(joinExpr).ToString());
         }
 
-        private string InternalCreateSqlFromDefinitions(ModelDefinition sourceDef, ModelDefinition targetDef, bool allowMissingOnClause) 
+        private string InternalCreateSqlFromDefinitions(ModelDefinition sourceDef, ModelDefinition targetDef, bool isCrossJoin) 
         {
             var parentDef = sourceDef;
             var childDef = targetDef;
@@ -104,13 +104,14 @@ private string InternalCreateSqlFromDefinitions(ModelDefinition sourceDef, Model
 
             if (refField == null) 
             {
-                if(!allowMissingOnClause)
+                if(!isCrossJoin)
                     throw new ArgumentException("Could not infer relationship between {0} and {1}".Fmt(sourceDef.ModelName, targetDef.ModelName));
 
                 return string.Empty;
             }
 
-            return "ON\n({0}.{1} = {2}.{3})".Fmt(
+            return "{0}\n({1}.{2} = {3}.{4})".Fmt(
+                isCrossJoin ? "WHERE" : "ON",
                 DialectProvider.GetQuotedTableName(parentDef),
                 SqlColumn(parentDef.PrimaryKey.FieldName),
                 DialectProvider.GetQuotedTableName(childDef),
@@ -126,9 +127,10 @@ private SqlExpression<T> InternalJoin(string joinType,
             useFieldName = true;
             sep = " ";
 
+            var isCrossJoin = "CROSS JOIN".Equals(joinType);
             var sqlExpr = joinExpr != null 
-                ? InternalCreateSqlFromExpression(joinExpr) 
-                : InternalCreateSqlFromDefinitions(sourceDef, targetDef, "CROSS JOIN".Equals(joinType));
+                ? InternalCreateSqlFromExpression(joinExpr, isCrossJoin)
+                : InternalCreateSqlFromDefinitions(sourceDef, targetDef, isCrossJoin);
 
             var joinDef = tableDefs.Contains(targetDef) && !tableDefs.Contains(sourceDef)
                               ? sourceDef