Add DefaultStringLength as the default size for String db params

Author: mythz

src/ServiceStack.OrmLite.SqlServerTests/CustomSqlTests.cs

@@ -0,0 +1,83 @@
+using System.Data;
+using NUnit.Framework;
+using ServiceStack.DataAnnotations;
+
+namespace ServiceStack.OrmLite.SqlServerTests
+{
+    public class LetterFrequency
+    {
+        [AutoIncrement]
+        public int Id { get; set; }
+
+        public string Letter { get; set; }
+    }
+
+    [TestFixture]
+    public class CustomSqlTests : OrmLiteTestBase
+    {
+        private const string DropProcedureSql = @"
+            IF OBJECT_ID('spSearchLetters') IS NOT NULL
+                    DROP PROCEDURE spSearchLetters";
+
+        private const string CreateProcedureSql = @"
+            CREATE PROCEDURE spSearchLetters 
+            (
+                @pLetter varchar(10),
+                @pTotal int OUT
+            )
+            AS
+            BEGIN
+                SELECT @pTotal = COUNT(*) FROM LetterFrequency WHERE Letter = @pLetter
+                SELECT * FROM LetterFrequency WHERE Letter = @pLetter
+            END";
+
+        [Test]
+        public void Can_execute_stored_procedure_using_SqlList_with_out_params()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<LetterFrequency>();
+
+                var rows = "A,B,B,C,C,C,D,D,E".Split(',').Map(x => new LetterFrequency { Letter = x });
+                db.InsertAll(rows);
+
+                db.ExecuteSql(DropProcedureSql);
+                db.ExecuteSql(CreateProcedureSql);
+
+                IDbDataParameter pTotal = null;
+                var results = db.SqlList<LetterFrequency>("spSearchLetters",
+                    cmd =>
+                    {
+                        cmd.CommandType = CommandType.StoredProcedure;
+                        cmd.AddParam("pLetter", "C");
+                        pTotal = cmd.AddParam("pTotal", direction: ParameterDirection.Output);
+                    });
+
+                Assert.That(results.Count, Is.EqualTo(3));
+                Assert.That(pTotal.Value, Is.EqualTo("3"));
+            }
+        }
+
+        [Test]
+        public void Can_execute_stored_procedure_using_SqlProc_with_out_params()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<LetterFrequency>();
+
+                var rows = "A,B,B,C,C,C,D,D,E".Split(',').Map(x => new LetterFrequency { Letter = x });
+                db.InsertAll(rows);
+
+                db.ExecuteSql(DropProcedureSql);
+                db.ExecuteSql(CreateProcedureSql);
+
+                var cmd = db.SqlProc("spSearchLetters", new { pLetter = "C" });
+                var pTotal = cmd.AddParam("pTotal", direction: ParameterDirection.Output);
+                var results = cmd.ConvertToList<LetterFrequency>();
+
+                Assert.That(results.Count, Is.EqualTo(3));
+                Assert.That(pTotal.Value, Is.EqualTo("3"));
+            }
+        }
+    }
+}

src/ServiceStack.OrmLite.SqlServerTests/ServiceStack.OrmLite.SqlServerTests.csproj

@@ -74,6 +74,7 @@
     <Compile Include="..\GlobalAssemblyInfo.cs">
       <Link>Properties\GlobalAssemblyInfo.cs</Link>
     </Compile>
+    <Compile Include="CustomSqlTests.cs" />
     <Compile Include="Datetime2Tests.cs" />
     <Compile Include="DateTimeOffsetTests.cs" />
     <Compile Include="EnsureUtcTest.cs" />

src/ServiceStack.OrmLite/OrmLiteReadCommandExtensions.cs

@@ -908,6 +908,10 @@ public static IDbDataParameter CreateParam(this IDbCommand dbCmd,
             }
             if (dbType != null)
                 p.DbType = dbType.Value;
+
+            if (p.DbType == DbType.String)
+                p.Size = dialectProvider.DefaultStringLength;
+
             return p;
         }